X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Finiteffects.cpp;h=a9dd406bf302b2489c558395a4a98d60f8c330df;hb=f3e4009355bff682d8e0494e188abb539874541f;hp=74ea0a83dfa9f19c5980c4a836833b57637a79dd;hpb=d49eeed017c543f0311bea311cb10286fde11e86;p=kdenlive diff --git a/src/initeffects.cpp b/src/initeffects.cpp index 74ea0a83..a9dd406b 100644 --- a/src/initeffects.cpp +++ b/src/initeffects.cpp @@ -27,7 +27,7 @@ #include #include -#include +#include #include #include @@ -94,7 +94,7 @@ void initEffects::refreshLumas() } QDomElement lumaTransition = MainWindow::transitions.getEffectByTag("luma", "luma"); QDomNodeList params = lumaTransition.elementsByTagName("parameter"); - for (int i = 0; i < params.count(); i++) { + for (int i = 0; i < params.count(); ++i) { QDomElement e = params.item(i).toElement(); if (e.attribute("tag") == "resource") { e.setAttribute("paramlistdisplay", imagenamelist.join(",")); @@ -105,7 +105,7 @@ void initEffects::refreshLumas() QDomElement compositeTransition = MainWindow::transitions.getEffectByTag("composite", "composite"); params = compositeTransition.elementsByTagName("parameter"); - for (int i = 0; i < params.count(); i++) { + for (int i = 0; i < params.count(); ++i) { QDomElement e = params.item(i).toElement(); if (e.attribute("tag") == "luma") { e.setAttribute("paramlistdisplay", imagenamelist.join(",")); @@ -116,7 +116,7 @@ void initEffects::refreshLumas() } // static -QDomDocument initEffects::getUsedCustomEffects(QMap effectids) +QDomDocument initEffects::getUsedCustomEffects(const QMap & effectids) { QMapIterator i(effectids); int ix; @@ -200,8 +200,10 @@ void initEffects::parseEffectFiles(const QString &locale) while (!in.atEnd()) { QString black = in.readLine().simplified(); if (!black.isEmpty() && !black.startsWith('#') && - mltFiltersList.contains(black)) + mltFiltersList.contains(black)) { mltFiltersList.removeAll(black); + } + } file2.close(); } @@ -229,8 +231,7 @@ void initEffects::parseEffectFiles(const QString &locale) MainWindow::transitions.clearList(); foreach(const QDomElement & effect, effectsMap) MainWindow::transitions.append(effect); - effectsMap.clear(); - + effectsMap.clear(); // Create effects from MLT foreach(const QString & filtername, mltFiltersList) { QDomDocument doc = createDescriptionFromMlt(repository, "filters", filtername); @@ -243,7 +244,9 @@ void initEffects::parseEffectFiles(const QString &locale) if (desc.startsWith("Process audio using a SoX")) { // Remove MLT's SOX generated effects since the parameters properties are unusable for us } - else audioEffectsMap.insert(doc.documentElement().firstChildElement("name").text().toLower().toUtf8().data(), doc.documentElement()); + else { + audioEffectsMap.insert(doc.documentElement().firstChildElement("name").text().toLower().toUtf8().data(), doc.documentElement()); + } } } else @@ -341,7 +344,7 @@ void initEffects::parseCustomEffectsFile() } effectsMap.insert(groupName.toLower().toUtf8().data(), base); } else if (base.tagName() == "effect") { - effectsMap.insert(e.firstChildElement("name").text().toLower().toUtf8().data(), base); + effectsMap.insert(base.firstChildElement("name").text().toLower().toUtf8().data(), base); } else kDebug() << "Unsupported effect file: " << itemName; } @@ -350,7 +353,7 @@ void initEffects::parseCustomEffectsFile() } // static -void initEffects::parseEffectFile(EffectsList *customEffectList, EffectsList *audioEffectList, EffectsList *videoEffectList, QString name, QStringList filtersList, QStringList producersList, Mlt::Repository *repository) +void initEffects::parseEffectFile(EffectsList *customEffectList, EffectsList *audioEffectList, EffectsList *videoEffectList, const QString &name, QStringList filtersList, QStringList producersList, Mlt::Repository *repository) { QDomDocument doc; QFile file(name); @@ -388,8 +391,8 @@ void initEffects::parseEffectFile(EffectsList *customEffectList, EffectsList *au for (int j = 0; j < params.count(); j++) { QDomNamedNodeMap attrs = params.at(j).attributes(); for (int k = 0; k < attrs.count(); k++) { - QString name = attrs.item(k).nodeName(); - if (name != "type" && name != "name") { + QString nodeName = attrs.item(k).nodeName(); + if (nodeName != "type" && nodeName != "name") { QString val = attrs.item(k).nodeValue(); if (val.contains(oldSeparator)) { QString newVal = val.replace(oldSeparator, separator); @@ -474,7 +477,7 @@ QDomDocument initEffects::createDescriptionFromMlt(Mlt::Repository* repository, Mlt::Properties tags((mlt_properties) metadata->get_data("tags")); if (QString(tags.get(0)) == "Audio") eff.setAttribute("type", "audio"); - /*for (int i = 0; i < tags.count(); i++) + /*for (int i = 0; i < tags.count(); ++i) kDebug()<get_data("parameters")); @@ -482,16 +485,23 @@ QDomDocument initEffects::createDescriptionFromMlt(Mlt::Repository* repository, QDomElement params = ret.createElement("parameter"); Mlt::Properties paramdesc((mlt_properties) param_props.get_data(param_props.get_name(j))); - params.setAttribute("name", paramdesc.get("identifier")); + if (params.attribute("name") == "argument") { + // This parameter has to be given as attribute when using command line, do not show it in Kdenlive + continue; + } if (paramdesc.get("maximum")) params.setAttribute("max", paramdesc.get("maximum")); if (paramdesc.get("minimum")) params.setAttribute("min", paramdesc.get("minimum")); QString paramType = paramdesc.get("type"); - if (paramType == "integer") - params.setAttribute("type", "constant"); + if (paramType == "integer") { + if (params.attribute("min") == "0" && params.attribute("max") == "1") + params.setAttribute("type", "bool"); + else params.setAttribute("type", "constant"); + + } else if (paramType == "float") { params.setAttribute("type", "constant"); // param type is float, set default decimals to 3 @@ -516,6 +526,12 @@ QDomDocument initEffects::createDescriptionFromMlt(Mlt::Repository* repository, QDomElement pname = ret.createElement("name"); pname.appendChild(ret.createTextNode(paramdesc.get("title"))); params.appendChild(pname); + + if (paramdesc.get("description")) { + QDomElement desc = ret.createElement("comment"); + desc.appendChild(ret.createTextNode(paramdesc.get("description"))); + params.appendChild(desc); + } eff.appendChild(params); } @@ -601,8 +617,12 @@ void initEffects::fillTransitionsList(Mlt::Repository *repository, EffectsList * if (paramdesc.get("minimum")) params.setAttribute("min", paramdesc.get("minimum")); if (QString(paramdesc.get("type")) == "integer") { - params.setAttribute("type", "constant"); - params.setAttribute("factor", "100"); + if (params.attribute("min") == "0" && params.attribute("max") == "1") + params.setAttribute("type", "bool"); + else { + params.setAttribute("type", "constant"); + params.setAttribute("factor", "100"); + } } if (QString(paramdesc.get("type")) == "boolean") params.setAttribute("type", "bool"); @@ -725,7 +745,7 @@ void initEffects::fillTransitionsList(Mlt::Repository *repository, EffectsList * transitions->append(ret.documentElement());*/ } -QDomElement initEffects::quickParameterFill(QDomDocument & doc, QString name, QString tag, QString type, QString def, QString min, QString max, QString list, QString listdisplaynames, QString factor, QString namedesc, QString format, QString opacity) +QDomElement initEffects::quickParameterFill(QDomDocument & doc, const QString &name, const QString &tag, const QString &type, const QString &def, const QString &min, const QString &max, const QString &list, const QString &listdisplaynames, const QString &factor, const QString &namedesc, const QString &format, const QString &opacity) { QDomElement parameter = doc.createElement("parameter"); parameter.setAttribute("tag", tag); @@ -752,3 +772,5 @@ QDomElement initEffects::quickParameterFill(QDomDocument & doc, QString name, QS return parameter; } + +#include "initeffects.moc"