X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Finput%2Fvar.c;h=781ce7c10287a12f2b16ce3517c067f04cba4e98;hb=6ff5a488a41ed665a285276dde65e28d751aa4e7;hp=96c9d72f93aa3b962d5130b450185e88414bf7dd;hpb=f3b32f6f56727dcb71e7fdfe45f4a476f5e98a9a;p=vlc diff --git a/src/input/var.c b/src/input/var.c index 96c9d72f93..781ce7c102 100644 --- a/src/input/var.c +++ b/src/input/var.c @@ -24,22 +24,16 @@ /***************************************************************************** * Preamble *****************************************************************************/ -#include +#ifdef HAVE_CONFIG_H +# include "config.h" +#endif + +#include #include #include #include "input_internal.h" -/***************************************************************************** - * Exported prototypes - *****************************************************************************/ -void input_ControlVarInit ( input_thread_t * ); -void input_ControlVarClean( input_thread_t * ); -void input_ControlVarNavigation( input_thread_t * ); -void input_ControlVarTitle( input_thread_t *p_input, int i_title ); - -void input_ConfigVarInit ( input_thread_t *p_input ); - /***************************************************************************** * Callbacks *****************************************************************************/ @@ -67,6 +61,67 @@ static int EsDelayCallback ( vlc_object_t *p_this, char const *psz_cmd, static int BookmarkCallback( vlc_object_t *p_this, char const *psz_cmd, vlc_value_t oldval, vlc_value_t newval, void * ); +static int RecordCallback( vlc_object_t *p_this, char const *psz_cmd, + vlc_value_t oldval, vlc_value_t newval, + void *p_data ); +static int FrameNextCallback( vlc_object_t *p_this, char const *psz_cmd, + vlc_value_t oldval, vlc_value_t newval, + void *p_data ); + +typedef struct +{ + const char *psz_name; + vlc_callback_t callback; +} vlc_input_callback_t; + +static void InputAddCallbacks( input_thread_t *, const vlc_input_callback_t * ); +static void InputDelCallbacks( input_thread_t *, const vlc_input_callback_t * ); + +#ifdef CALLBACK /* For windows */ +# undef CALLBACK /* We don't care of this one here */ +#endif +/* List all callbacks added by input */ +#define CALLBACK(name,cb) { name, cb } +static const vlc_input_callback_t p_input_callbacks[] = +{ + CALLBACK( "state", StateCallback ), + CALLBACK( "rate", RateCallback ), + CALLBACK( "rate-slower", RateCallback ), + CALLBACK( "rate-faster", RateCallback ), + CALLBACK( "position", PositionCallback ), + CALLBACK( "position-offset", PositionCallback ), + CALLBACK( "time", TimeCallback ), + CALLBACK( "time-offset", TimeCallback ), + CALLBACK( "bookmark", BookmarkCallback ), + CALLBACK( "program", ProgramCallback ), + CALLBACK( "title", TitleCallback ), + CALLBACK( "chapter", SeekpointCallback ), + CALLBACK( "audio-delay", EsDelayCallback ), + CALLBACK( "spu-delay", EsDelayCallback ), + CALLBACK( "video-es", ESCallback ), + CALLBACK( "audio-es", ESCallback ), + CALLBACK( "spu-es", ESCallback ), + CALLBACK( "record", RecordCallback ), + CALLBACK( "frame-next", FrameNextCallback ), + + CALLBACK( NULL, NULL ) +}; +static const vlc_input_callback_t p_input_navigation_callbacks[] = +{ + CALLBACK( "next-title", TitleCallback ), + CALLBACK( "prev-title", TitleCallback ), + + CALLBACK( NULL, NULL ) +}; +static const vlc_input_callback_t p_input_title_callbacks[] = +{ + CALLBACK( "next-chapter", SeekpointCallback ), + CALLBACK( "prev-chapter", SeekpointCallback ), + + CALLBACK( NULL, NULL ) +}; +#undef CALLBACK + /***************************************************************************** * input_ControlVarInit: * Create all control object variables with their callbacks @@ -75,49 +130,39 @@ void input_ControlVarInit ( input_thread_t *p_input ) { vlc_value_t val, text; - /* XXX we put callback only in non preparsing mode. We need to create the variable - * unless someone want to check all var_Get/var_Change return value ... */ -#define ADD_CALLBACK( name, callback ) do { if( !p_input->b_preparsing ) { var_AddCallback( p_input, name, callback, NULL ); } } while(0) /* State */ var_Create( p_input, "state", VLC_VAR_INTEGER ); - val.i_int = p_input->i_state; + val.i_int = p_input->p->i_state; var_Change( p_input, "state", VLC_VAR_SETVALUE, &val, NULL ); - ADD_CALLBACK( "state", StateCallback ); /* Rate */ - var_Create( p_input, "rate", VLC_VAR_INTEGER ); - val.i_int = p_input->p->i_rate; + var_Create( p_input, "rate", VLC_VAR_FLOAT ); + val.f_float = (float)INPUT_RATE_DEFAULT / (float)p_input->p->i_rate; var_Change( p_input, "rate", VLC_VAR_SETVALUE, &val, NULL ); - ADD_CALLBACK( "rate", RateCallback ); var_Create( p_input, "rate-slower", VLC_VAR_VOID ); - ADD_CALLBACK( "rate-slower", RateCallback ); var_Create( p_input, "rate-faster", VLC_VAR_VOID ); - ADD_CALLBACK( "rate-faster", RateCallback ); + + var_Create( p_input, "frame-next", VLC_VAR_VOID ); /* Position */ var_Create( p_input, "position", VLC_VAR_FLOAT ); var_Create( p_input, "position-offset", VLC_VAR_FLOAT ); val.f_float = 0.0; var_Change( p_input, "position", VLC_VAR_SETVALUE, &val, NULL ); - ADD_CALLBACK( "position", PositionCallback ); - ADD_CALLBACK( "position-offset", PositionCallback ); /* Time */ var_Create( p_input, "time", VLC_VAR_TIME ); var_Create( p_input, "time-offset", VLC_VAR_TIME ); /* relative */ val.i_time = 0; var_Change( p_input, "time", VLC_VAR_SETVALUE, &val, NULL ); - ADD_CALLBACK( "time", TimeCallback ); - ADD_CALLBACK( "time-offset", TimeCallback ); /* Bookmark */ var_Create( p_input, "bookmark", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE | VLC_VAR_ISCOMMAND ); val.psz_string = _("Bookmark"); var_Change( p_input, "bookmark", VLC_VAR_SETTEXT, &val, NULL ); - ADD_CALLBACK( "bookmark", BookmarkCallback ); /* Program */ var_Create( p_input, "program", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE | @@ -127,7 +172,6 @@ void input_ControlVarInit ( input_thread_t *p_input ) var_Change( p_input, "program", VLC_VAR_DELCHOICE, &val, NULL ); text.psz_string = _("Program"); var_Change( p_input, "program", VLC_VAR_SETTEXT, &text, NULL ); - ADD_CALLBACK( "program", ProgramCallback ); /* Programs */ var_Create( p_input, "programs", VLC_VAR_LIST | VLC_VAR_DOINHERIT ); @@ -138,13 +182,11 @@ void input_ControlVarInit ( input_thread_t *p_input ) var_Create( p_input, "title", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE ); text.psz_string = _("Title"); var_Change( p_input, "title", VLC_VAR_SETTEXT, &text, NULL ); - ADD_CALLBACK( "title", TitleCallback ); /* Chapter */ var_Create( p_input, "chapter", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE ); text.psz_string = _("Chapter"); var_Change( p_input, "chapter", VLC_VAR_SETTEXT, &text, NULL ); - ADD_CALLBACK( "chapter", SeekpointCallback ); /* Navigation The callback is added after */ var_Create( p_input, "navigation", VLC_VAR_VARIABLE | VLC_VAR_HASCHOICE ); @@ -153,31 +195,28 @@ void input_ControlVarInit ( input_thread_t *p_input ) /* Delay */ var_Create( p_input, "audio-delay", VLC_VAR_TIME ); - val.i_time = 0; + val.i_time = INT64_C(1000) * var_GetInteger( p_input, "audio-desync" ); var_Change( p_input, "audio-delay", VLC_VAR_SETVALUE, &val, NULL ); - ADD_CALLBACK( "audio-delay", EsDelayCallback ); var_Create( p_input, "spu-delay", VLC_VAR_TIME ); val.i_time = 0; var_Change( p_input, "spu-delay", VLC_VAR_SETVALUE, &val, NULL ); - ADD_CALLBACK( "spu-delay", EsDelayCallback ); /* Video ES */ var_Create( p_input, "video-es", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE ); text.psz_string = _("Video Track"); var_Change( p_input, "video-es", VLC_VAR_SETTEXT, &text, NULL ); - ADD_CALLBACK( "video-es", ESCallback ); /* Audio ES */ var_Create( p_input, "audio-es", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE ); text.psz_string = _("Audio Track"); var_Change( p_input, "audio-es", VLC_VAR_SETTEXT, &text, NULL ); - ADD_CALLBACK( "audio-es", ESCallback ); /* Spu ES */ var_Create( p_input, "spu-es", VLC_VAR_INTEGER | VLC_VAR_HASCHOICE ); text.psz_string = _("Subtitles Track"); var_Change( p_input, "spu-es", VLC_VAR_SETTEXT, &text, NULL ); - ADD_CALLBACK( "spu-es", ESCallback ); + + var_Create( p_input, "sub-margin", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT ); /* Special read only objects variables for intf */ var_Create( p_input, "bookmarks", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); @@ -186,66 +225,45 @@ void input_ControlVarInit ( input_thread_t *p_input ) val.i_time = 0; var_Change( p_input, "length", VLC_VAR_SETVALUE, &val, NULL ); + var_Create( p_input, "bit-rate", VLC_VAR_INTEGER ); + var_Create( p_input, "sample-rate", VLC_VAR_INTEGER ); + if( !p_input->b_preparsing ) { - /* Special "intf-change" variable, it allows intf to set up a callback - * to be notified of some changes. - * TODO list all changes warn by this callbacks */ - var_Create( p_input, "intf-change", VLC_VAR_BOOL ); - var_SetBool( p_input, "intf-change", VLC_TRUE ); - - /* item-change variable */ - var_Create( p_input, "item-change", VLC_VAR_INTEGER ); + /* Special "intf-event" variable. */ + var_Create( p_input, "intf-event", VLC_VAR_INTEGER ); } -#undef ADD_CALLBACK + + /* Add all callbacks + * XXX we put callback only in non preparsing mode. We need to create the variable + * unless someone want to check all var_Get/var_Change return value ... */ + if( !p_input->b_preparsing ) + InputAddCallbacks( p_input, p_input_callbacks ); } /***************************************************************************** - * input_ControlVarClean: + * input_ControlVarStop: *****************************************************************************/ -void input_ControlVarClean( input_thread_t *p_input ) +void input_ControlVarStop( input_thread_t *p_input ) { - var_Destroy( p_input, "state" ); - var_Destroy( p_input, "rate" ); - var_Destroy( p_input, "rate-slower" ); - var_Destroy( p_input, "rate-faster" ); - var_Destroy( p_input, "position" ); - var_Destroy( p_input, "position-offset" ); - var_Destroy( p_input, "time" ); - var_Destroy( p_input, "time-offset" ); - - var_Destroy( p_input, "audio-delay" ); - var_Destroy( p_input, "spu-delay" ); - - var_Destroy( p_input, "bookmark" ); - - var_Destroy( p_input, "program" ); - if( p_input->p->i_title > 1 ) - { - /* TODO Destroy sub navigation var ? */ + if( !p_input->b_preparsing ) + InputDelCallbacks( p_input, p_input_callbacks ); - var_Destroy( p_input, "next-title" ); - var_Destroy( p_input, "prev-title" ); - } if( p_input->p->i_title > 0 ) { - /* FIXME title > 0 doesn't mean current title has more than 1 seekpoint */ - var_Destroy( p_input, "next-chapter" ); - var_Destroy( p_input, "prev-chapter" ); - } - var_Destroy( p_input, "title" ); - var_Destroy( p_input, "chapter" ); - var_Destroy( p_input, "navigation" ); - - var_Destroy( p_input, "video-es" ); - var_Destroy( p_input, "audio-es" ); - var_Destroy( p_input, "spu-es" ); + char name[sizeof("title ") + 5 ]; + int i; - var_Destroy( p_input, "bookmarks" ); - var_Destroy( p_input, "length" ); + InputDelCallbacks( p_input, p_input_navigation_callbacks ); + InputDelCallbacks( p_input, p_input_title_callbacks ); - var_Destroy( p_input, "intf-change" ); - } + for( i = 0; i < p_input->p->i_title; i++ ) + { + snprintf( name, sizeof(name), "title %2i", i ); + var_DelCallback( p_input, name, NavigationCallback, (void *)(intptr_t)i ); + } + } +} /***************************************************************************** * input_ControlVarNavigation: @@ -272,9 +290,12 @@ void input_ControlVarNavigation( input_thread_t *p_input ) /* Create title and navigation */ val.psz_string = malloc( sizeof("title ") + 5 ); + if( !val.psz_string ) + return; + for( i = 0; i < p_input->p->i_title; i++ ) { - vlc_value_t val2, text, text2; + vlc_value_t val2, text2; int j; /* Add Navigation entries */ @@ -288,8 +309,9 @@ void input_ControlVarNavigation( input_thread_t *p_input ) if( p_input->p->title[i]->psz_name == NULL || *p_input->p->title[i]->psz_name == '\0' ) { - asprintf( &text.psz_string, _("Title %i"), - i + p_input->p->i_title_offset ); + if( asprintf( &text.psz_string, _("Title %i"), + i + p_input->p->i_title_offset ) == -1 ) + continue; } else { @@ -311,8 +333,9 @@ void input_ControlVarNavigation( input_thread_t *p_input ) *p_input->p->title[i]->seekpoint[j]->psz_name == '\0' ) { /* Default value */ - asprintf( &text2.psz_string, _("Chapter %i"), - j + p_input->p->i_seekpoint_offset ); + if( asprintf( &text2.psz_string, _("Chapter %i"), + j + p_input->p->i_seekpoint_offset ) == -1 ) + continue; } else { @@ -322,7 +345,7 @@ void input_ControlVarNavigation( input_thread_t *p_input ) var_Change( p_input, val.psz_string, VLC_VAR_ADDCHOICE, &val2, &text2 ); - if( text2.psz_string ) free( text2.psz_string ); + free( text2.psz_string ); } } @@ -336,7 +359,7 @@ void input_ControlVarNavigation( input_thread_t *p_input ) void input_ControlVarTitle( input_thread_t *p_input, int i_title ) { input_title_t *t = p_input->p->title[i_title]; - vlc_value_t val; + vlc_value_t text; int i; /* Create/Destroy command variables */ @@ -345,10 +368,8 @@ void input_ControlVarTitle( input_thread_t *p_input, int i_title ) var_Destroy( p_input, "next-chapter" ); var_Destroy( p_input, "prev-chapter" ); } - else if( var_Get( p_input, "next-chapter", &val ) != VLC_SUCCESS ) + else if( var_Type( p_input, "next-chapter" ) == 0 ) { - vlc_value_t text; - var_Create( p_input, "next-chapter", VLC_VAR_VOID ); text.psz_string = _("Next chapter"); var_Change( p_input, "next-chapter", VLC_VAR_SETTEXT, &text, NULL ); @@ -364,15 +385,16 @@ void input_ControlVarTitle( input_thread_t *p_input, int i_title ) var_Change( p_input, "chapter", VLC_VAR_CLEARCHOICES, NULL, NULL ); for( i = 0; i < t->i_seekpoint; i++ ) { - vlc_value_t text; + vlc_value_t val; val.i_int = i; if( t->seekpoint[i]->psz_name == NULL || *t->seekpoint[i]->psz_name == '\0' ) { /* Default value */ - asprintf( &text.psz_string, _("Chapter %i"), - i + p_input->p->i_seekpoint_offset ); + if( asprintf( &text.psz_string, _("Chapter %i"), + i + p_input->p->i_seekpoint_offset ) == -1 ) + continue; } else { @@ -380,7 +402,7 @@ void input_ControlVarTitle( input_thread_t *p_input, int i_title ) } var_Change( p_input, "chapter", VLC_VAR_ADDCHOICE, &val, &text ); - if( text.psz_string ) free( text.psz_string ); + free( text.psz_string ); } } @@ -390,8 +412,6 @@ void input_ControlVarTitle( input_thread_t *p_input, int i_title ) *****************************************************************************/ void input_ConfigVarInit ( input_thread_t *p_input ) { - vlc_value_t val; - /* Create Object Variables for private use only */ if( !p_input->b_preparsing ) @@ -430,16 +450,14 @@ void input_ConfigVarInit ( input_thread_t *p_input ) var_Create( p_input, "input-repeat", VLC_VAR_INTEGER|VLC_VAR_DOINHERIT ); - var_Create( p_input, "start-time", VLC_VAR_INTEGER|VLC_VAR_DOINHERIT ); - var_Create( p_input, "stop-time", VLC_VAR_INTEGER|VLC_VAR_DOINHERIT ); - var_Create( p_input, "run-time", VLC_VAR_INTEGER|VLC_VAR_DOINHERIT ); + var_Create( p_input, "start-time", VLC_VAR_FLOAT|VLC_VAR_DOINHERIT ); + var_Create( p_input, "stop-time", VLC_VAR_FLOAT|VLC_VAR_DOINHERIT ); + var_Create( p_input, "run-time", VLC_VAR_FLOAT|VLC_VAR_DOINHERIT ); + var_Create( p_input, "input-fast-seek", VLC_VAR_BOOL|VLC_VAR_DOINHERIT ); var_Create( p_input, "input-slave", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); - var_Create( p_input, "minimize-threads", - VLC_VAR_BOOL|VLC_VAR_DOINHERIT ); - var_Create( p_input, "audio-desync", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT ); var_Create( p_input, "cr-average", @@ -448,18 +466,46 @@ void input_ConfigVarInit ( input_thread_t *p_input ) VLC_VAR_INTEGER | VLC_VAR_DOINHERIT); } - var_Create( p_input, "demuxed-id3", VLC_VAR_BOOL ); /* FIXME beurk */ - val.b_bool = VLC_FALSE; - var_Change( p_input, "demuxed-id3", VLC_VAR_SETVALUE, &val, NULL ); + var_Create( p_input, "can-seek", VLC_VAR_BOOL ); + var_SetBool( p_input, "can-seek", true ); /* Fixed later*/ + + var_Create( p_input, "can-pause", VLC_VAR_BOOL ); + var_SetBool( p_input, "can-pause", true ); /* Fixed later*/ + + var_Create( p_input, "can-rate", VLC_VAR_BOOL ); + var_SetBool( p_input, "can-rate", false ); + + var_Create( p_input, "can-rewind", VLC_VAR_BOOL ); + var_SetBool( p_input, "can-rewind", false ); + + var_Create( p_input, "can-record", VLC_VAR_BOOL ); + var_SetBool( p_input, "can-record", false ); /* Fixed later*/ + + var_Create( p_input, "record", VLC_VAR_BOOL ); + var_SetBool( p_input, "record", false ); + + var_Create( p_input, "teletext-es", VLC_VAR_INTEGER ); + var_SetInteger( p_input, "teletext-es", -1 ); + + var_Create( p_input, "signal-quality", VLC_VAR_FLOAT ); + var_SetFloat( p_input, "signal-quality", -1 ); + + var_Create( p_input, "signal-strength", VLC_VAR_FLOAT ); + var_SetFloat( p_input, "signal-strength", -1 ); + + var_Create( p_input, "program-scrambled", VLC_VAR_BOOL ); + var_SetBool( p_input, "program-scrambled", false ); - var_Create( p_input, "seekable", VLC_VAR_BOOL ); - val.b_bool = VLC_TRUE; /* Fixed later*/ - var_Change( p_input, "seekable", VLC_VAR_SETVALUE, &val, NULL ); + var_Create( p_input, "cache", VLC_VAR_FLOAT ); + var_SetFloat( p_input, "cache", 0.0 ); + + /* */ + var_Create( p_input, "input-record-native", VLC_VAR_BOOL | VLC_VAR_DOINHERIT ); /* */ - var_Create( p_input, "access-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); var_Create( p_input, "access", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); var_Create( p_input, "demux", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); + var_Create( p_input, "stream-filter", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); /* Meta */ var_Create( p_input, "meta-title", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); @@ -472,6 +518,29 @@ void input_ConfigVarInit ( input_thread_t *p_input ) var_Create( p_input, "meta-url", VLC_VAR_STRING | VLC_VAR_DOINHERIT ); } +/***************************************************************************** + * Callbacks managements: + *****************************************************************************/ +static void InputAddCallbacks( input_thread_t *p_input, + const vlc_input_callback_t *p_callbacks ) +{ + int i; + for( i = 0; p_callbacks[i].psz_name != NULL; i++ ) + var_AddCallback( p_input, + p_callbacks[i].psz_name, + p_callbacks[i].callback, NULL ); +} + +static void InputDelCallbacks( input_thread_t *p_input, + const vlc_input_callback_t *p_callbacks ) +{ + int i; + for( i = 0; p_callbacks[i].psz_name != NULL; i++ ) + var_DelCallback( p_input, + p_callbacks[i].psz_name, + p_callbacks[i].callback, NULL ); +} + /***************************************************************************** * All Callbacks: *****************************************************************************/ @@ -480,7 +549,7 @@ static int StateCallback( vlc_object_t *p_this, char const *psz_cmd, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - (void)psz_cmd; (void)oldval; (void)p_data; + VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data); if( newval.i_int == PLAYING_S || newval.i_int == PAUSE_S ) { @@ -495,9 +564,11 @@ static int RateCallback( vlc_object_t *p_this, char const *psz_cmd, vlc_value_t oldval, vlc_value_t newval, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - (void)oldval; (void)p_data; + VLC_UNUSED(oldval); VLC_UNUSED(p_data); + + /* Problem with this way: the "rate" variable is updated after the + * input thread did the change */ - /* Problem with this way: the "rate" variable is update after the input thread do the change */ if( !strcmp( psz_cmd, "rate-slower" ) ) { input_ControlPush( p_input, INPUT_CONTROL_SET_RATE_SLOWER, NULL ); @@ -508,9 +579,9 @@ static int RateCallback( vlc_object_t *p_this, char const *psz_cmd, } else { + newval.i_int = INPUT_RATE_DEFAULT / newval.f_float; input_ControlPush( p_input, INPUT_CONTROL_SET_RATE, &newval ); } - return VLC_SUCCESS; } @@ -519,32 +590,32 @@ static int PositionCallback( vlc_object_t *p_this, char const *psz_cmd, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - vlc_value_t val, length; - (void)oldval; (void)p_data; + VLC_UNUSED(oldval); VLC_UNUSED(p_data); if( !strcmp( psz_cmd, "position-offset" ) ) { - input_ControlPush( p_input, INPUT_CONTROL_SET_POSITION_OFFSET, &newval ); - - val.f_float = var_GetFloat( p_input, "position" ) + newval.f_float; - if( val.f_float < 0.0 ) val.f_float = 0.0; - if( val.f_float > 1.0 ) val.f_float = 1.0; - var_Change( p_input, "position", VLC_VAR_SETVALUE, &val, NULL ); + float f_position = var_GetFloat( p_input, "position" ) + newval.f_float; + if( f_position < 0.0 ) + f_position = 0.0; + else if( f_position > 1.0 ) + f_position = 1.0; + var_SetFloat( p_this, "position", f_position ); } else { - val.f_float = newval.f_float; - input_ControlPush( p_input, INPUT_CONTROL_SET_POSITION, &newval ); - } + /* Update "length" for better intf behavour */ + const mtime_t i_length = var_GetTime( p_input, "length" ); + if( i_length > 0 && newval.f_float >= 0.0 && newval.f_float <= 1.0 ) + { + vlc_value_t val; - /* Update "position" for better intf behavour */ - var_Get( p_input, "length", &length ); - if( length.i_time > 0 && val.f_float >= 0.0 && val.f_float <= 1.0 ) - { - val.i_time = length.i_time * val.f_float; - var_Change( p_input, "time", VLC_VAR_SETVALUE, &val, NULL ); - } + val.i_time = i_length * newval.f_float; + var_Change( p_input, "time", VLC_VAR_SETVALUE, &val, NULL ); + } + /* */ + input_ControlPush( p_input, INPUT_CONTROL_SET_POSITION, &newval ); + } return VLC_SUCCESS; } @@ -552,31 +623,30 @@ static int TimeCallback( vlc_object_t *p_this, char const *psz_cmd, vlc_value_t oldval, vlc_value_t newval, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - vlc_value_t val, length; - (void)oldval; (void)p_data; + VLC_UNUSED(oldval); VLC_UNUSED(p_data); if( !strcmp( psz_cmd, "time-offset" ) ) { - input_ControlPush( p_input, INPUT_CONTROL_SET_TIME_OFFSET, &newval ); - val.i_time = var_GetTime( p_input, "time" ) + newval.i_time; - if( val.i_time < 0 ) val.i_time = 0; - /* TODO maybe test against i_length ? */ - var_Change( p_input, "time", VLC_VAR_SETVALUE, &val, NULL ); + mtime_t i_time = var_GetTime( p_input, "time" ) + newval.i_time; + if( i_time < 0 ) + i_time = 0; + var_SetTime( p_this, "time", i_time ); } else { - val.i_time = newval.i_time; - input_ControlPush( p_input, INPUT_CONTROL_SET_TIME, &newval ); - } + /* Update "position" for better intf behavour */ + const mtime_t i_length = var_GetTime( p_input, "length" ); + if( i_length > 0 && newval.i_time >= 0 && newval.i_time <= i_length ) + { + vlc_value_t val; - /* Update "position" for better intf behavour */ - var_Get( p_input, "length", &length ); - if( length.i_time > 0 && val.i_time >= 0 && val.i_time <= length.i_time ) - { - val.f_float = (double)val.i_time/(double)length.i_time; - var_Change( p_input, "position", VLC_VAR_SETVALUE, &val, NULL ); - } + val.f_float = (double)newval.i_time/(double)i_length; + var_Change( p_input, "position", VLC_VAR_SETVALUE, &val, NULL ); + } + /* */ + input_ControlPush( p_input, INPUT_CONTROL_SET_TIME, &newval ); + } return VLC_SUCCESS; } @@ -585,7 +655,7 @@ static int ProgramCallback( vlc_object_t *p_this, char const *psz_cmd, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - (void)psz_cmd; (void)oldval; (void)p_data; + VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data); input_ControlPush( p_input, INPUT_CONTROL_SET_PROGRAM, &newval ); @@ -598,7 +668,7 @@ static int TitleCallback( vlc_object_t *p_this, char const *psz_cmd, { input_thread_t *p_input = (input_thread_t*)p_this; vlc_value_t val, count; - (void)oldval; (void)p_data; + VLC_UNUSED(oldval); VLC_UNUSED(p_data); if( !strcmp( psz_cmd, "next-title" ) ) { @@ -631,7 +701,7 @@ static int SeekpointCallback( vlc_object_t *p_this, char const *psz_cmd, { input_thread_t *p_input = (input_thread_t*)p_this; vlc_value_t val, count; - (void)oldval; (void)p_data; + VLC_UNUSED(oldval); VLC_UNUSED(p_data); if( !strcmp( psz_cmd, "next-chapter" ) ) { @@ -664,7 +734,7 @@ static int NavigationCallback( vlc_object_t *p_this, char const *psz_cmd, { input_thread_t *p_input = (input_thread_t*)p_this; vlc_value_t val; - (void)psz_cmd; (void)oldval; + VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); /* Issue a title change */ val.i_int = (intptr_t)p_data; @@ -684,7 +754,7 @@ static int ESCallback( vlc_object_t *p_this, char const *psz_cmd, vlc_value_t oldval, vlc_value_t newval, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - (void)oldval; (void)p_data; + VLC_UNUSED(oldval); VLC_UNUSED(p_data); if( newval.i_int < 0 ) { @@ -713,19 +783,16 @@ static int EsDelayCallback ( vlc_object_t *p_this, char const *psz_cmd, vlc_value_t oldval, vlc_value_t newval, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - (void)oldval; (void)p_data; + VLC_UNUSED(oldval); VLC_UNUSED(p_data); if( !strcmp( psz_cmd, "audio-delay" ) ) { - /*Change i_pts_delay to make sure es are decoded in time*/ - if (newval.i_int < 0 || oldval.i_int < 0 ) - { - p_input->i_pts_delay -= newval.i_int - oldval.i_int; - } input_ControlPush( p_input, INPUT_CONTROL_SET_AUDIO_DELAY, &newval ); } else if( !strcmp( psz_cmd, "spu-delay" ) ) + { input_ControlPush( p_input, INPUT_CONTROL_SET_SPU_DELAY, &newval ); + } return VLC_SUCCESS; } @@ -734,9 +801,35 @@ static int BookmarkCallback( vlc_object_t *p_this, char const *psz_cmd, void *p_data ) { input_thread_t *p_input = (input_thread_t*)p_this; - (void)psz_cmd; (void)oldval; (void)p_data; + VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data); input_ControlPush( p_input, INPUT_CONTROL_SET_BOOKMARK, &newval ); return VLC_SUCCESS; } + +static int RecordCallback( vlc_object_t *p_this, char const *psz_cmd, + vlc_value_t oldval, vlc_value_t newval, + void *p_data ) +{ + input_thread_t *p_input = (input_thread_t*)p_this; + VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data); + + input_ControlPush( p_input, INPUT_CONTROL_SET_RECORD_STATE, &newval ); + + return VLC_SUCCESS; +} + +static int FrameNextCallback( vlc_object_t *p_this, char const *psz_cmd, + vlc_value_t oldval, vlc_value_t newval, + void *p_data ) +{ + input_thread_t *p_input = (input_thread_t*)p_this; + VLC_UNUSED(psz_cmd); VLC_UNUSED(oldval); VLC_UNUSED(p_data); + VLC_UNUSED(newval); + + input_ControlPush( p_input, INPUT_CONTROL_SET_FRAME_NEXT, NULL ); + + return VLC_SUCCESS; +} +