X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Finterface%2Finterface.c;h=990335dff310cb7c01dc979027d6bce1ce1104ff;hb=ad14bac870b421457a3fbe7b0a716b72a1b27006;hp=19712688bae05b6e77f87a8306e2046109d9e088;hpb=3ab81753822bd0a37786e6fd026a349e7a0e0830;p=vlc diff --git a/src/interface/interface.c b/src/interface/interface.c index 19712688ba..990335dff3 100644 --- a/src/interface/interface.c +++ b/src/interface/interface.c @@ -37,7 +37,7 @@ # include "config.h" #endif -#include +#include #include #include @@ -49,11 +49,31 @@ /***************************************************************************** * Local prototypes *****************************************************************************/ -static void RunInterface( intf_thread_t *p_intf ); - +static void* RunInterface( vlc_object_t *p_this ); +#ifdef __APPLE__ +static void * MonitorLibVLCDeath( vlc_object_t *p_this ); +#endif static int AddIntfCallback( vlc_object_t *, char const *, vlc_value_t , vlc_value_t , void * ); +/** + * \brief Destroy the interface after the main loop endeed. + * + * \param p_intf the interface thread + * \return nothing + */ +static void intf_Destroy( vlc_object_t *obj ) +{ + intf_thread_t *p_intf = (intf_thread_t *)obj; + + /* Unlock module if present (a switch may have failed) */ + if( p_intf->p_module ) + module_Unneed( p_intf, p_intf->p_module ); + + free( p_intf->psz_intf ); + vlc_mutex_destroy( &p_intf->change_lock ); +} + /***************************************************************************** * intf_Create: prepare interface before main loop ***************************************************************************** @@ -62,58 +82,46 @@ static int AddIntfCallback( vlc_object_t *, char const *, *****************************************************************************/ /** * Create the interface, and prepare it for main loop. - * You can give some additional options to be used for interface initialization * * \param p_this the calling vlc_object_t * \param psz_module a preferred interface module - * \param i_options number additional options - * \param ppsz_options additional option strings * \return a pointer to the created interface thread, NULL on error */ -intf_thread_t* __intf_Create( vlc_object_t *p_this, const char *psz_module, - int i_options, const char *const *ppsz_options ) +intf_thread_t* __intf_Create( vlc_object_t *p_this, const char *psz_module ) { intf_thread_t * p_intf; - int i; /* Allocate structure */ p_intf = vlc_object_create( p_this, VLC_OBJECT_INTF ); if( !p_intf ) - { - msg_Err( p_this, "out of memory" ); return NULL; - } - p_intf->pf_request_window = NULL; - p_intf->pf_release_window = NULL; - p_intf->pf_control_window = NULL; - p_intf->b_play = VLC_FALSE; - p_intf->b_interaction = VLC_FALSE; - p_intf->b_should_run_on_first_thread = VLC_FALSE; - - for( i = 0 ; i< i_options; i++ ) - var_OptionParse( p_this, ppsz_options[i] ); + p_intf->b_interaction = false; +#ifdef __APPLE__ + p_intf->b_should_run_on_first_thread = false; +#endif /* Choose the best module */ p_intf->psz_intf = strdup( psz_module ); - p_intf->p_module = module_Need( p_intf, "interface", psz_module, VLC_FALSE ); + p_intf->p_module = module_Need( p_intf, "interface", psz_module, false ); if( p_intf->p_module == NULL ) { msg_Err( p_intf, "no suitable interface module" ); free( p_intf->psz_intf ); - vlc_object_destroy( p_intf ); + vlc_object_release( p_intf ); return NULL; } /* Initialize structure */ - p_intf->b_menu = VLC_FALSE; - p_intf->b_menu_change = VLC_FALSE; + p_intf->b_menu = false; + p_intf->b_menu_change = false; /* Initialize mutexes */ - vlc_mutex_init( p_intf, &p_intf->change_lock ); + vlc_mutex_init( &p_intf->change_lock ); /* Attach interface to its parent object */ vlc_object_attach( p_intf, p_this ); + vlc_object_set_destructor( p_intf, intf_Destroy ); return p_intf; } @@ -131,21 +139,33 @@ intf_thread_t* __intf_Create( vlc_object_t *p_this, const char *psz_module, */ int intf_RunThread( intf_thread_t *p_intf ) { - /* This interface doesn't need to be run */ - if( p_intf->pf_run == NULL ) - return VLC_SUCCESS; - +#ifdef __APPLE__ /* Hack to get Mac OS X Cocoa runtime running * (it needs access to the main thread) */ if( p_intf->b_should_run_on_first_thread ) { - RunInterface( p_intf ); + if( vlc_thread_create( p_intf, "interface", MonitorLibVLCDeath, + VLC_THREAD_PRIORITY_LOW, false ) ) + { + msg_Err( p_intf, "cannot spawn libvlc death monitoring thread" ); + return VLC_EGENERIC; + } + RunInterface( VLC_OBJECT(p_intf) ); + + /* Make sure our MonitorLibVLCDeath thread exit */ + vlc_object_kill( p_intf ); + /* It is monitoring libvlc, not the p_intf */ + vlc_object_signal( p_intf->p_libvlc ); + vlc_thread_join( p_intf ); + + vlc_object_detach( p_intf ); + vlc_object_release( p_intf ); return VLC_SUCCESS; } - +#endif /* Run the interface in a separate thread */ if( vlc_thread_create( p_intf, "interface", RunInterface, - VLC_THREAD_PRIORITY_LOW, VLC_FALSE ) ) + VLC_THREAD_PRIORITY_LOW, false ) ) { msg_Err( p_intf, "cannot spawn interface thread" ); return VLC_EGENERIC; @@ -165,43 +185,17 @@ void intf_StopThread( intf_thread_t *p_intf ) { /* Tell the interface to die */ vlc_object_kill( p_intf ); - if( p_intf->pf_run != NULL ) - { - vlc_cond_signal( &p_intf->object_wait ); - vlc_thread_join( p_intf ); - } -} - -/** - * \brief Destroy the interface after the main loop endeed. - * - * Destroys interfaces and closes output devices - * \param p_intf the interface thread - * \return nothing - */ -void intf_Destroy( intf_thread_t *p_intf ) -{ - /* Unlock module if present (a switch may have failed) */ - if( p_intf->p_module ) - { - module_Unneed( p_intf, p_intf->p_module ); - } - free( p_intf->psz_intf ); - - vlc_mutex_destroy( &p_intf->change_lock ); - - /* Free structure */ - vlc_object_destroy( p_intf ); + vlc_thread_join( p_intf ); } - /* Following functions are local */ /***************************************************************************** * RunInterface: setups necessary data and give control to the interface *****************************************************************************/ -static void RunInterface( intf_thread_t *p_intf ) +static void* RunInterface( vlc_object_t *p_this ) { + intf_thread_t *p_intf = (intf_thread_t *)p_this; vlc_value_t val, text; char *psz_intf; @@ -211,7 +205,8 @@ static void RunInterface( intf_thread_t *p_intf ) text.psz_string = _("Add Interface"); var_Change( p_intf, "intf-add", VLC_VAR_SETTEXT, &text, NULL ); - val.psz_string = (char *)"rc"; text.psz_string = (char *)"Console"; + val.psz_string = (char *)"rc"; + text.psz_string = (char *)_("Console"); var_Change( p_intf, "intf-add", VLC_VAR_ADDCHOICE, &val, &text ); val.psz_string = (char *)"telnet"; text.psz_string = (char *)_("Telnet Interface"); @@ -231,10 +226,15 @@ static void RunInterface( intf_thread_t *p_intf ) do { /* Give control to the interface */ - p_intf->pf_run( p_intf ); - - /* Reset play on start status */ - p_intf->b_play = VLC_FALSE; + if( p_intf->pf_run ) + p_intf->pf_run( p_intf ); + else + { + vlc_object_lock( p_intf ); + while( vlc_object_alive( p_intf ) ) + vlc_object_wait( p_intf ); + vlc_object_unlock( p_intf ); + } if( !p_intf->psz_switch_intf ) { @@ -248,18 +248,54 @@ static void RunInterface( intf_thread_t *p_intf ) psz_intf = p_intf->psz_switch_intf; p_intf->psz_switch_intf = NULL; - vlc_mutex_lock( &p_intf->object_lock ); - p_intf->b_die = VLC_FALSE; /* FIXME */ - p_intf->b_dead = VLC_FALSE; + vlc_object_lock( p_intf ); + p_intf->b_die = false; /* FIXME */ + p_intf->b_dead = false; - vlc_mutex_unlock( &p_intf->object_lock ); + vlc_object_unlock( p_intf ); p_intf->psz_intf = psz_intf; p_intf->p_module = module_Need( p_intf, "interface", psz_intf, 0 ); } while( p_intf->p_module ); + return NULL; } +#ifdef __APPLE__ +/***************************************************************************** + * MonitorLibVLCDeath: Used when b_should_run_on_first_thread is set. + *****************************************************************************/ +static void * MonitorLibVLCDeath( vlc_object_t * p_this ) +{ + intf_thread_t *p_intf = (intf_thread_t *)p_this; + libvlc_int_t * p_libvlc = p_intf->p_libvlc; + vlc_object_lock( p_libvlc ); + while(vlc_object_alive( p_libvlc ) ) + { + if(p_intf->b_die) + { + vlc_object_unlock( p_libvlc ); + return NULL; + } + vlc_object_wait( p_libvlc ); + } + vlc_object_unlock( p_libvlc ); + + /* Someone killed libvlc */ + + /* Make sure we kill all interface objects, especially + * those that are blocking libvlc (running on main thread) */ + vlc_list_t * p_list = vlc_list_find( p_libvlc, VLC_OBJECT_INTF, FIND_CHILD ); + for( int i = 0; i < p_list->i_count; i++ ) + { + vlc_object_t * p_intf = p_list->p_values[i].p_object; + vlc_object_kill( p_intf ); + } + vlc_list_release( p_list ); + return NULL; +} +#endif + static int AddIntfCallback( vlc_object_t *p_this, char const *psz_cmd, vlc_value_t oldval, vlc_value_t newval, void *p_data ) { @@ -270,7 +306,7 @@ static int AddIntfCallback( vlc_object_t *p_this, char const *psz_cmd, /* Try to create the interface */ sprintf( psz_intf, "%s,none", newval.psz_string ); - p_intf = intf_Create( p_this->p_libvlc, psz_intf, 0, NULL ); + p_intf = intf_Create( p_this->p_libvlc, psz_intf ); free( psz_intf ); if( p_intf == NULL ) { @@ -283,7 +319,7 @@ static int AddIntfCallback( vlc_object_t *p_this, char const *psz_cmd, if( intf_RunThread( p_intf ) != VLC_SUCCESS ) { vlc_object_detach( p_intf ); - intf_Destroy( p_intf ); + vlc_object_release( p_intf ); return VLC_EGENERIC; }