X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fjogshuttle.cpp;h=6a61812e8b927d5cfad461961ef8ceb185b7d895;hb=5bcb9b7ead3d053cb2b0498d84a2622626bf7f14;hp=fd32153026a4425da4ff97612060d16aad057886;hpb=27bd91107e757db52b4b9b00ef0b8f262839043d;p=kdenlive

diff --git a/src/jogshuttle.cpp b/src/jogshuttle.cpp
index fd321530..6a61812e 100644
--- a/src/jogshuttle.cpp
+++ b/src/jogshuttle.cpp
@@ -31,6 +31,8 @@
 #include <stdio.h>
 #include <unistd.h>
 #include <fcntl.h>
+#include <errno.h>
+#include <string.h>
 #include <linux/input.h>
 
 #define DELAY 10
@@ -66,7 +68,7 @@
 #define JOG_STOP 10020
 #define MAX_SHUTTLE_RANGE 7
 
-void ShuttleThread::init(QObject *parent, QString device)
+void ShuttleThread::init(QObject *parent, const QString &device)
 {
     m_parent = parent;
     m_device = device;
@@ -88,7 +90,7 @@ void ShuttleThread::run()
 	/* open file descriptor */
 	const int fd = KDE_open((char *) m_device.toUtf8().data(), O_RDONLY);
 	if (fd < 0) {
-		fprintf(stderr, "Can't open Jog Shuttle FILE DESCRIPTOR\n");
+		perror("Can't open Jog Shuttle FILE DESCRIPTOR");
 		return;
 	}
 
@@ -103,9 +105,20 @@ void ShuttleThread::run()
 	fd_set		   readset;
 	struct timeval timeout;
 
-	int num_warnings = 0;
+	int num_warnings = 0, readResult = 0;
 	int result, iof = -1;
 
+	/* get fd settings */
+    if ((iof = fcntl(fd, F_GETFL, 0)) == -1) {
+        fprintf(stderr, "Can't get Jog Shuttle file status\n");
+        close(fd);
+        return;
+    } else if (fcntl(fd, F_SETFL, iof | O_NONBLOCK) == -1) {
+        fprintf(stderr, "Can't set Jog Shuttle FILE DESCRIPTOR to O_NONBLOCK and stop thread\n");
+        close(fd);
+        return;
+    }
+
 	/* enter thread loop */
 	while (!stop_me) {
 		/* reset the read set */
@@ -114,45 +127,55 @@ void ShuttleThread::run()
 
 		/* reinit the timeout structure */
 		timeout.tv_sec  = 0;
-		timeout.tv_usec = 300000; /* 300 ms */
+		timeout.tv_usec = 400000; /* 400 ms */
 
-		/* do the select */
+		/* do select in blocked mode and wake up after timeout for eval stop_me */
 		result = select(fd+1, &readset, NULL, NULL, &timeout);
 
-		/* see if there was an error or timeout */
-		if (result < 0) {
-			// perror("select failed");
+		/* see if there was an error or timeout else process event */
+		if (result < 0 && errno == EINTR) {
+			/* EINTR event catched. This is not a problem - continue processing */
+			kDebug() << strerror(errno) << "\n";
+			/* continue processing */
+			continue;
+		} else if (result < 0) {
+			/* stop thread */
+			stop_me = true;
+			kDebug() << strerror(errno) << "\n";
 		} else if (result == 0) {
-			//puts("TIMEOUT");
+			/* do nothing. reserved for future purposes */
 		} else {
 			/* we have input */
 			if (FD_ISSET(fd, &readset)) {
-				/* get fd settings */
-				if ((iof = fcntl(fd, F_GETFL, 0)) != -1) {
-					/* set fd non blocking */
-					fcntl(fd, F_SETFL, iof | O_NONBLOCK);
-					/* read input */
-					if (read(fd, &ev, sizeof(ev)) < 0) {
-						if (num_warnings % 10000 == 0)
-							/* should not happen cause select called before */
-							fprintf(stderr, "Failed to read event from Jog Shuttle FILE DESCRIPTOR (repeated %d times)\n", num_warnings + 1);
-						num_warnings++;
+				/* read input */
+				readResult = read(fd, &ev, sizeof(ev));
+				if (readResult < 0) {
+					if (num_warnings % 10000 == 0) {
+						/* if device is not available anymore - dead or disconnected */
+						fprintf(stderr, "Failed to read event from Jog Shuttle FILE DESCRIPTOR (repeated %d times)\n", num_warnings + 1);
 					}
-
-					/* restore settings */
-					if (iof != -1) {
-						fcntl(fd, F_SETFL, iof);
+					/* exit if device is not available or the error occurs to long */
+					if (errno == ENODEV) {
+						perror("Failed to read from Jog Shuttle FILE DESCRIPTOR. Stop thread");
+						/* stop thread */
+						stop_me = true;
+					} else if (num_warnings > 1000000) {
+						perror("Failed to read from Jog Shuttle FILE DESCRIPTOR. Limit reached. Stop thread");
+						/* stop thread */
+						stop_me = true;
 					}
+					num_warnings++;
+				} else if (readResult == sizeof(ev)) {
 					/* process event */
 					handle_event(ev);
 				} else {
-					fprintf(stderr, "Can't set Jog Shuttle FILE DESCRIPTOR to O_NONBLOCK\n");
-					stop_me = true;
+					fprintf(stderr, "Read nr of bytes != sizeof(ev)\n");
 				}
 			}
 		}
 	}
 
+//	kDebug() << "Close thread" << "\n";
 	/* close the handle and return thread */
 	close(fd);
 }
@@ -184,7 +207,7 @@ void ShuttleThread::key(unsigned short code, unsigned int value)
     if (code > 16)
         return;
 
-    kDebug() << "Button PRESSED: " << code;
+    //kDebug() << "Button PRESSED: " << code;
     QApplication::postEvent(m_parent, new QEvent((QEvent::Type)(KEY_EVENT_OFFSET + code)));
 
 }
@@ -244,7 +267,7 @@ void ShuttleThread::jog(unsigned int value)
 }
 
 
-JogShuttle::JogShuttle(QString device, QObject *parent) :
+JogShuttle::JogShuttle(const QString &device, QObject *parent) :
         QObject(parent)
 {
     initDevice(device);
@@ -255,7 +278,7 @@ JogShuttle::~JogShuttle()
 	stopDevice();
 }
 
-void JogShuttle::initDevice(QString device)
+void JogShuttle::initDevice(const QString &device)
 {
     if (m_shuttleProcess.isRunning()) {
         if (device == m_shuttleProcess.m_device) return;
@@ -311,3 +334,5 @@ void JogShuttle::customEvent(QEvent* e)
 
 // #include "jogshuttle.moc"
 
+
+#include "jogshuttle.moc"