X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Flibvlc-common.c;h=468fd953bc3da85968abf0302db83057f2245b46;hb=2ef3494d82c286e0f1e3ac7421dec82e1d858757;hp=01c235b44dca83fb4847df25b1a8a8ffed874400;hpb=e9947bec0ae6a8f81dcc10e2595dd6cebd72641f;p=vlc diff --git a/src/libvlc-common.c b/src/libvlc-common.c index 01c235b44d..468fd953bc 100644 --- a/src/libvlc-common.c +++ b/src/libvlc-common.c @@ -1,5 +1,5 @@ /***************************************************************************** - * libvlc-common.c: libvlc instances creation and deletion + * libvlc-common.c: libvlc instances creation and deletion, interfaces handling ***************************************************************************** * Copyright (C) 1998-2006 the VideoLAN team * $Id$ @@ -29,23 +29,19 @@ * This file contains functions to create and destroy libvlc instances */ -/***************************************************************************** - * Pretend we are a builtin module - *****************************************************************************/ -#define MODULE_NAME main -#define MODULE_PATH main -#define __BUILTIN__ - /***************************************************************************** * Preamble *****************************************************************************/ #include -#include -#include +#include "control/libvlc_internal.h" +#include + +#include "modules/modules.h" +#include "config/config.h" #include /* ENOMEM */ #include /* sprintf() */ -#include /* strerror() */ +#include #include /* free() */ #ifndef WIN32 @@ -66,45 +62,53 @@ # include #endif +#ifdef HAVE_DBUS_3 +/* used for one-instance mode */ +# include +#endif + #ifdef HAVE_HAL # include #endif -#include "vlc_cpu.h" /* CPU detection */ -#include "os_specific.h" +#include "vlc_os_specific.h" -#include "vlc_error.h" +#include +#include -#include "vlc_playlist.h" -#include "vlc_interface.h" +#include +#include "audio_output/aout_internal.h" -#include "audio_output.h" +#include -#include "vlc_video.h" -#include "video_output.h" +#include +#include "stream_output/stream_output.h" -#include "stream_output.h" -#include "charset.h" +#include #include "libvlc.h" +#include "playlist/playlist_internal.h" + /***************************************************************************** * The evil global variable. We handle it with care, don't worry. *****************************************************************************/ static libvlc_global_data_t libvlc_global; -static libvlc_global_data_t * p_libvlc_global; -static libvlc_int_t * p_static_vlc; +#define p_libvlc_global (&libvlc_global) +static libvlc_int_t * p_static_vlc = NULL; +static volatile unsigned int i_instances = 0; /***************************************************************************** * Local prototypes *****************************************************************************/ -void LocaleInit( vlc_object_t * ); -void LocaleDeinit( void ); +#if defined (__APPLE__) || defined (WIN32) static void SetLanguage ( char const * ); -static int GetFilenames ( libvlc_int_t *, int, char *[] ); +#endif +static inline int LoadMessages (void); +static int GetFilenames ( libvlc_int_t *, int, const char *[] ); static void Help ( libvlc_int_t *, char const *psz_help_name ); static void Usage ( libvlc_int_t *, char const *psz_module_name ); -static void ListModules ( libvlc_int_t * ); +static void ListModules ( libvlc_int_t *, vlc_bool_t ); static void Version ( void ); #ifdef WIN32 @@ -118,6 +122,11 @@ static int VerboseCallback( vlc_object_t *, char const *, static void InitDeviceValues( libvlc_int_t * ); +libvlc_global_data_t *vlc_global( void ) +{ + return &libvlc_global; +} + /***************************************************************************** * vlc_current_object: return the current object. ***************************************************************************** @@ -144,10 +153,13 @@ libvlc_int_t * libvlc_InternalCreate( void ) int i_ret; libvlc_int_t * p_libvlc = NULL; vlc_value_t lockval; + char *psz_env = NULL; +#if 0 /* &libvlc_global never changes, * so we can safely call this multiple times. */ p_libvlc_global = &libvlc_global; +#endif /* vlc_threads_init *must* be the first internal call! No other call is * allowed before the thread system has been initialized. */ @@ -159,32 +171,14 @@ libvlc_int_t * libvlc_InternalCreate( void ) var_Create( p_libvlc_global, "libvlc", VLC_VAR_MUTEX ); var_Get( p_libvlc_global, "libvlc", &lockval ); vlc_mutex_lock( lockval.p_address ); + + i_instances++; + if( !libvlc_global.b_ready ) { - char *psz_env; - /* Guess what CPU we have */ - libvlc_global.i_cpu = CPUCapabilities(); - - /* Find verbosity from VLC_VERBOSE environment variable */ - psz_env = getenv( "VLC_VERBOSE" ); - libvlc_global.i_verbose = psz_env ? atoi( psz_env ) : -1; - -#if defined( HAVE_ISATTY ) && !defined( WIN32 ) - libvlc_global.b_color = isatty( 2 ); /* 2 is for stderr */ -#else - libvlc_global.b_color = VLC_FALSE; -#endif - - /* Initialize message queue */ - msg_Create( p_libvlc_global ); - - /* Announce who we are */ - msg_Dbg( p_libvlc_global, COPYRIGHT_MESSAGE ); - msg_Dbg( p_libvlc_global, "libvlc was configured with %s", - CONFIGURE_LINE ); - - /* The module bank will be initialized later */ + cpu_flags = CPUCapabilities(); + /* The module bank will be initialized later */ libvlc_global.p_module_bank = NULL; libvlc_global.b_ready = VLC_TRUE; @@ -194,21 +188,41 @@ libvlc_int_t * libvlc_InternalCreate( void ) /* Allocate a libvlc instance object */ p_libvlc = vlc_object_create( p_libvlc_global, VLC_OBJECT_LIBVLC ); - if( p_libvlc == NULL ) return NULL; - p_libvlc->thread_id = 0; + if( p_libvlc == NULL ) + { + i_instances--; + return NULL; + } p_libvlc->p_playlist = NULL; p_libvlc->psz_object_name = "libvlc"; + /* Initialize message queue */ + msg_Create( p_libvlc ); + + /* Find verbosity from VLC_VERBOSE environment variable */ + psz_env = getenv( "VLC_VERBOSE" ); + if( psz_env != NULL ) + p_libvlc->i_verbose = atoi( psz_env ); + else + p_libvlc->i_verbose = 3; +#if defined( HAVE_ISATTY ) && !defined( WIN32 ) + p_libvlc->b_color = isatty( 2 ); /* 2 is for stderr */ +#else + p_libvlc->b_color = VLC_FALSE; +#endif + + /* Announce who we are - Do it only for first instance ? */ + msg_Dbg( p_libvlc, COPYRIGHT_MESSAGE ); + msg_Dbg( p_libvlc, "libvlc was configured with %s", CONFIGURE_LINE ); + if( strcmp( p_libvlc->psz_object_name, "cvlc" ) ) /* Not running with cvlc */ + msg_Info( p_libvlc, "Running vlc with the default interface. Use 'cvlc' to use vlc without interface."); + /* Initialize mutexes */ vlc_mutex_init( p_libvlc, &p_libvlc->config_lock ); #ifdef __APPLE__ vlc_mutex_init( p_libvlc, &p_libvlc->quicktime_lock ); vlc_thread_set_priority( p_libvlc, VLC_THREAD_PRIORITY_LOW ); #endif - - /* Store our newly allocated structure in the global list */ - vlc_object_attach( p_libvlc, p_libvlc_global ); - /* Store data for the non-reentrant API */ p_static_vlc = p_libvlc; @@ -223,17 +237,18 @@ libvlc_int_t * libvlc_InternalCreate( void ) * - message queue, module bank and playlist initialization * - configuration and commandline parsing */ -int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) +int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, + const char *ppsz_argv[] ) { char p_capabilities[200]; - char * p_tmp; - char * psz_modules; - char * psz_parser; - char * psz_control; + char * p_tmp = NULL; + char * psz_modules = NULL; + char * psz_parser = NULL; + char * psz_control = NULL; vlc_bool_t b_exit = VLC_FALSE; int i_ret = VLC_EEXIT; - module_t *p_help_module; - playlist_t *p_playlist; + module_t *p_help_module = NULL; + playlist_t *p_playlist = NULL; vlc_value_t val; #if defined( ENABLE_NLS ) \ && ( defined( HAVE_GETTEXT ) || defined( HAVE_INCLUDED_GETTEXT ) ) @@ -248,11 +263,11 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) /* Get the executable name (similar to the basename command) */ if( i_argc > 0 ) { - p_libvlc->psz_object_name = p_tmp = ppsz_argv[ 0 ]; - while( *p_tmp ) + const char *exe = p_libvlc->psz_object_name = ppsz_argv[0]; + while( *exe ) { - if( *p_tmp == '/' ) p_libvlc->psz_object_name = ++p_tmp; - else ++p_tmp; + if( *exe++ == '/' ) + p_libvlc->psz_object_name = exe; } } else @@ -263,13 +278,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) /* * Support for gettext */ - SetLanguage( "" ); - - /* - * Global iconv, must be done after setlocale() - * so that vlc_current_charset() works. - */ - LocaleInit( (vlc_object_t *)p_libvlc ); + LoadMessages (); /* Translate "C" to the language code: "fr", "en_GB", "nl", "ru"... */ msg_Dbg( p_libvlc, "translation test: code is \"%s\"", _("C") ); @@ -281,7 +290,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) module_InitBank( p_libvlc ); /* Hack: insert the help module here */ - p_help_module = vlc_object_create( p_libvlc, VLC_OBJECT_MODULE ); + p_help_module = vlc_module_create( VLC_OBJECT(p_libvlc) ); if( p_help_module == NULL ) { module_EndBank( p_libvlc ); @@ -289,14 +298,15 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) } p_help_module->psz_object_name = "help"; p_help_module->psz_longname = N_("Help options"); - config_Duplicate( p_help_module, p_help_config ); + config_Duplicate( p_help_module, libvlc_config, libvlc_config_count ); vlc_object_attach( p_help_module, libvlc_global.p_module_bank ); /* End hack */ if( config_LoadCmdLine( p_libvlc, &i_argc, ppsz_argv, VLC_TRUE ) ) { vlc_object_detach( p_help_module ); - config_Free( p_help_module ); + p_help_module->p_config = NULL; + p_help_module->confsize = 0; vlc_object_destroy( p_help_module ); module_EndBank( p_libvlc ); return VLC_EGENERIC; @@ -318,22 +328,11 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) } /* Set the config file stuff */ - p_libvlc->psz_homedir = config_GetHomeDir(); - p_libvlc->psz_userdir = config_GetUserDir(); - if( p_libvlc->psz_userdir == NULL ) - p_libvlc->psz_userdir = strdup(p_libvlc->psz_homedir); - p_libvlc->psz_configfile = config_GetPsz( p_libvlc, "config" ); - if( p_libvlc->psz_configfile != NULL && p_libvlc->psz_configfile[0] == '~' - && p_libvlc->psz_configfile[1] == '/' ) - { - char *psz = malloc( strlen(p_libvlc->psz_userdir) - + strlen(p_libvlc->psz_configfile) ); - /* This is incomplete : we should also support the ~cmassiot/ syntax. */ - sprintf( psz, "%s/%s", p_libvlc->psz_userdir, - p_libvlc->psz_configfile + 2 ); - free( p_libvlc->psz_configfile ); - p_libvlc->psz_configfile = psz; - } + p_libvlc->psz_homedir = config_GetHomeDir(); + p_libvlc->psz_configdir = config_GetConfigDir( p_libvlc ); + p_libvlc->psz_datadir = config_GetUserDataDir( p_libvlc ); + p_libvlc->psz_cachedir = config_GetCacheDir( p_libvlc ); + p_libvlc->psz_configfile = config_GetCustomConfigFile( p_libvlc ); /* Check for plugins cache options */ if( config_GetInt( p_libvlc, "reset-plugins-cache" ) ) @@ -346,24 +345,24 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) /* End hack */ /* Will be re-done properly later on */ - p_libvlc->p_libvlc_global->i_verbose = config_GetInt( p_libvlc, "verbose" ); + p_libvlc->i_verbose = config_GetInt( p_libvlc, "verbose" ); /* Check for daemon mode */ #ifndef WIN32 if( config_GetInt( p_libvlc, "daemon" ) ) { #if HAVE_DAEMON + char *psz_pidfile = NULL; + if( daemon( 1, 0) != 0 ) { msg_Err( p_libvlc, "Unable to fork vlc to daemon mode" ); b_exit = VLC_TRUE; } - - p_libvlc->p_libvlc_global->b_daemon = VLC_TRUE; + libvlc_global.b_daemon = VLC_TRUE; /* lets check if we need to write the pidfile */ - char * psz_pidfile = config_GetPsz( p_libvlc, "pidfile" ); - + psz_pidfile = config_GetPsz( p_libvlc, "pidfile" ); if( psz_pidfile != NULL ) { FILE *pidfile; @@ -378,8 +377,8 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) } else { - msg_Err( p_libvlc, "cannot open pid file for writing: %s (%s)", - psz_pidfile, strerror(errno) ); + msg_Err( p_libvlc, "cannot open pid file for writing: %s (%m)", + psz_pidfile ); } } free( psz_pidfile ); @@ -407,7 +406,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) close( STDOUT_FILENO ); close( STDERR_FILENO ); - p_libvlc->p_libvlc_global->b_daemon = VLC_TRUE; + libvlc_global.b_daemon = VLC_TRUE; } #endif } @@ -415,7 +414,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) if( b_exit ) { - config_Free( p_help_module ); + p_help_module->p_config = NULL; p_help_module->confsize = 0; vlc_object_destroy( p_help_module ); module_EndBank( p_libvlc ); return i_ret; @@ -490,7 +489,13 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) /* Check for module list option */ else if( config_GetInt( p_libvlc, "list" ) ) { - ListModules( p_libvlc ); + ListModules( p_libvlc, VLC_FALSE ); + b_exit = VLC_TRUE; + i_ret = VLC_EEXITSUCCESS; + } + else if( config_GetInt( p_libvlc, "list-verbose" ) ) + { + ListModules( p_libvlc, VLC_TRUE ); b_exit = VLC_TRUE; i_ret = VLC_EEXITSUCCESS; } @@ -519,7 +524,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) if( b_exit ) { - config_Free( p_help_module ); + p_help_module->p_config = NULL; p_help_module->confsize = 0; vlc_object_destroy( p_help_module ); module_EndBank( p_libvlc ); return i_ret; @@ -552,7 +557,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) PauseConsole(); #endif vlc_object_detach( p_help_module ); - config_Free( p_help_module ); + p_help_module->p_config = NULL; p_help_module->confsize = 0; vlc_object_destroy( p_help_module ); module_EndBank( p_libvlc ); return VLC_EGENERIC; @@ -560,7 +565,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) /* Hack: remove the help module here */ vlc_object_detach( p_help_module ); - config_Free( p_help_module ); + p_help_module->p_config = NULL; p_help_module->confsize = 0; vlc_object_destroy( p_help_module ); /* End hack */ @@ -569,6 +574,129 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) */ system_Configure( p_libvlc, &i_argc, ppsz_argv ); +/* FIXME: could be replaced by using Unix sockets */ +#ifdef HAVE_DBUS_3 + dbus_threads_init_default(); + + if( config_GetInt( p_libvlc, "one-instance" ) ) + { + /* Initialise D-Bus interface, check for other instances */ + DBusConnection *p_conn = NULL; + DBusError dbus_error; + + dbus_error_init( &dbus_error ); + + /* connect to the session bus */ + p_conn = dbus_bus_get( DBUS_BUS_SESSION, &dbus_error ); + if( !p_conn ) + { + msg_Err( p_libvlc, "Failed to connect to D-Bus session daemon: %s", + dbus_error.message ); + dbus_error_free( &dbus_error ); + } + else + { + /* check if VLC is available on the bus + * if not: D-Bus control is not enabled on the other + * instance and we can't pass MRLs to it */ + DBusMessage *p_test_msg = NULL; + DBusMessage *p_test_reply = NULL; + p_test_msg = dbus_message_new_method_call( + "org.mpris.vlc", "/", + "org.freedesktop.MediaPlayer", "Identity" ); + /* block until a reply arrives */ + p_test_reply = dbus_connection_send_with_reply_and_block( + p_conn, p_test_msg, -1, &dbus_error ); + dbus_message_unref( p_test_msg ); + if( p_test_reply == NULL ) + { + dbus_error_free( &dbus_error ); + msg_Dbg( p_libvlc, "No Media Player is running. " + "Continuing normally." ); + } + else + { + int i_input; + DBusMessage* p_dbus_msg = NULL; + DBusMessageIter dbus_args; + DBusPendingCall* p_dbus_pending = NULL; + dbus_bool_t b_play; + + dbus_message_unref( p_test_reply ); + msg_Warn( p_libvlc, "Another Media Player is running. Exiting"); + + for( i_input = optind;i_input < i_argc;i_input++ ) + { + msg_Dbg( p_libvlc, "Adds %s to the running Media Player", + ppsz_argv[i_input] ); + + p_dbus_msg = dbus_message_new_method_call( + "org.mpris.vlc", "/TrackList", + "org.freedesktop.MediaPlayer", "AddTrack" ); + + if ( NULL == p_dbus_msg ) + { + msg_Err( p_libvlc, "D-Bus problem" ); + system_End( p_libvlc ); + exit( VLC_ETIMEOUT ); + } + + /* append MRLs */ + dbus_message_iter_init_append( p_dbus_msg, &dbus_args ); + if ( !dbus_message_iter_append_basic( &dbus_args, + DBUS_TYPE_STRING, &ppsz_argv[i_input] ) ) + { + msg_Err( p_libvlc, "Out of memory" ); + dbus_message_unref( p_dbus_msg ); + system_End( p_libvlc ); + exit( VLC_ENOMEM ); + } + b_play = TRUE; + if( config_GetInt( p_libvlc, "playlist-enqueue" ) ) + b_play = FALSE; + if ( !dbus_message_iter_append_basic( &dbus_args, + DBUS_TYPE_BOOLEAN, &b_play ) ) + { + msg_Err( p_libvlc, "Out of memory" ); + dbus_message_unref( p_dbus_msg ); + system_End( p_libvlc ); + exit( VLC_ENOMEM ); + } + + /* send message and get a handle for a reply */ + if ( !dbus_connection_send_with_reply ( p_conn, + p_dbus_msg, &p_dbus_pending, -1 ) ) + { + msg_Err( p_libvlc, "D-Bus problem" ); + dbus_message_unref( p_dbus_msg ); + system_End( p_libvlc ); + exit( VLC_ETIMEOUT ); + } + + if ( NULL == p_dbus_pending ) + { + msg_Err( p_libvlc, "D-Bus problem" ); + dbus_message_unref( p_dbus_msg ); + system_End( p_libvlc ); + exit( VLC_ETIMEOUT ); + } + dbus_connection_flush( p_conn ); + dbus_message_unref( p_dbus_msg ); + /* block until we receive a reply */ + dbus_pending_call_block( p_dbus_pending ); + dbus_pending_call_unref( p_dbus_pending ); + } /* processes all command line MRLs */ + + /* bye bye */ + system_End( p_libvlc ); + exit( VLC_SUCCESS ); + } + } + /* we unreference the connection when we've finished with it */ + if( p_conn ) dbus_connection_unref( p_conn ); + } +#endif + /* * Message queue options */ @@ -582,38 +710,35 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) var_AddCallback( p_libvlc, "verbose", VerboseCallback, NULL ); var_Change( p_libvlc, "verbose", VLC_VAR_TRIGGER_CALLBACKS, NULL, NULL ); - libvlc_global.b_color = libvlc_global.b_color && - config_GetInt( p_libvlc, "color" ); + p_libvlc->b_color = p_libvlc->b_color && config_GetInt( p_libvlc, "color" ); /* * Output messages that may still be in the queue */ msg_Flush( p_libvlc ); - /* p_libvlc initialization. FIXME ? */ - if( !config_GetInt( p_libvlc, "fpu" ) ) - libvlc_global.i_cpu &= ~CPU_CAPABILITY_FPU; + cpu_flags &= ~CPU_CAPABILITY_FPU; #if defined( __i386__ ) || defined( __x86_64__ ) if( !config_GetInt( p_libvlc, "mmx" ) ) - libvlc_global.i_cpu &= ~CPU_CAPABILITY_MMX; + cpu_flags &= ~CPU_CAPABILITY_MMX; if( !config_GetInt( p_libvlc, "3dn" ) ) - libvlc_global.i_cpu &= ~CPU_CAPABILITY_3DNOW; + cpu_flags &= ~CPU_CAPABILITY_3DNOW; if( !config_GetInt( p_libvlc, "mmxext" ) ) - libvlc_global.i_cpu &= ~CPU_CAPABILITY_MMXEXT; + cpu_flags &= ~CPU_CAPABILITY_MMXEXT; if( !config_GetInt( p_libvlc, "sse" ) ) - libvlc_global.i_cpu &= ~CPU_CAPABILITY_SSE; + cpu_flags &= ~CPU_CAPABILITY_SSE; if( !config_GetInt( p_libvlc, "sse2" ) ) - libvlc_global.i_cpu &= ~CPU_CAPABILITY_SSE2; + cpu_flags &= ~CPU_CAPABILITY_SSE2; #endif #if defined( __powerpc__ ) || defined( __ppc__ ) || defined( __ppc64__ ) if( !config_GetInt( p_libvlc, "altivec" ) ) - libvlc_global.i_cpu &= ~CPU_CAPABILITY_ALTIVEC; + cpu_flags &= ~CPU_CAPABILITY_ALTIVEC; #endif #define PRINT_CAPABILITY( capability, string ) \ - if( libvlc_global.i_cpu & capability ) \ + if( vlc_CPU() & capability ) \ { \ strncat( p_capabilities, string " ", \ sizeof(p_capabilities) - strlen(p_capabilities) ); \ @@ -657,9 +782,9 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) * Initialize hotkey handling */ var_Create( p_libvlc, "key-pressed", VLC_VAR_INTEGER ); - p_libvlc->p_hotkeys = malloc( sizeof(p_hotkeys) ); + p_libvlc->p_hotkeys = malloc( libvlc_hotkeys_size ); /* Do a copy (we don't need to modify the strings) */ - memcpy( p_libvlc->p_hotkeys, p_hotkeys, sizeof(p_hotkeys) ); + memcpy( p_libvlc->p_hotkeys, libvlc_hotkeys, libvlc_hotkeys_size ); /* Initialize playlist and get commandline files */ playlist_ThreadCreate( p_libvlc ); @@ -679,7 +804,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) if( psz_modules && *psz_modules ) { /* Add service discovery modules */ - playlist_AddSDModules( p_playlist, psz_modules ); + playlist_ServicesDiscoveryAdd( p_playlist, psz_modules ); } if( psz_modules ) free( psz_modules ); @@ -697,7 +822,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) } else if( psz_control && *psz_control ) { - if( psz_modules ) free( psz_modules ); + free( psz_modules ); psz_modules = strdup( psz_control ); } @@ -720,16 +845,26 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) free( psz_temp ); } } - if ( psz_modules ) - { - free( psz_modules ); - } + free( psz_modules ); + free( psz_control ); /* * Always load the hotkeys interface if it exists */ VLC_AddIntf( 0, "hotkeys,none", VLC_FALSE, VLC_FALSE ); +#ifdef HAVE_DBUS_3 + /* loads dbus control interface if in one-instance mode + * we do it only when playlist exists, because dbus module needs it */ + if( config_GetInt( p_libvlc, "one-instance" ) ) + VLC_AddIntf( 0, "dbus,none", VLC_FALSE, VLC_FALSE ); + + /* Prevents the power management daemon to suspend the computer + * when VLC is active */ + if( config_GetInt( p_libvlc, "inhibit" ) ) + VLC_AddIntf( 0, "inhibit,none", VLC_FALSE, VLC_FALSE ); +#endif + /* * If needed, load the Xscreensaver interface * Currently, only for X @@ -748,8 +883,8 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) #ifdef HAVE_SYSLOG_H if( config_GetInt( p_libvlc, "syslog" ) == 1 ) { - char *psz_logmode = "logmode=syslog"; - libvlc_InternalAddIntf( 0, "logger,none", VLC_FALSE, VLC_FALSE, + const char *psz_logmode = "logmode=syslog"; + libvlc_InternalAddIntf( p_libvlc, "logger,none", VLC_FALSE, VLC_FALSE, 1, &psz_logmode ); } #endif @@ -764,6 +899,26 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) VLC_AddIntf( 0, "netsync,none", VLC_FALSE, VLC_FALSE ); } +#ifdef WIN32 + if( config_GetInt( p_libvlc, "prefer-system-codecs") == 1 ) + { + char *psz_codecs = config_GetPsz( p_playlist, "codec" ); + if( psz_codecs ) + { + char *psz_morecodecs; + asprintf(&psz_morecodecs, "%s,dmo,quicktime", psz_codecs); + if( psz_morecodecs ) + { + config_PutPsz( p_libvlc, "codec", psz_morecodecs); + free(psz_morecodecs); + } + } + else + config_PutPsz( p_libvlc, "codec", "dmo,quicktime"); + free(psz_codecs); + } +#endif + /* * FIXME: kludge to use a p_libvlc-local variable for the Mozilla plugin */ @@ -806,10 +961,10 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, char *ppsz_argv[] ) */ int libvlc_InternalCleanup( libvlc_int_t *p_libvlc ) { - intf_thread_t * p_intf; - vout_thread_t * p_vout; - aout_instance_t * p_aout; - announce_handler_t * p_announce; + intf_thread_t * p_intf = NULL; + vout_thread_t * p_vout = NULL; + aout_instance_t * p_aout = NULL; + announce_handler_t * p_announce = NULL; /* Ask the interfaces to stop and destroy them */ msg_Dbg( p_libvlc, "removing all interfaces" ); @@ -819,6 +974,7 @@ int libvlc_InternalCleanup( libvlc_int_t *p_libvlc ) vlc_object_detach( p_intf ); vlc_object_release( p_intf ); intf_Destroy( p_intf ); + p_intf = NULL; } /* Free playlist */ @@ -868,42 +1024,74 @@ int libvlc_InternalCleanup( libvlc_int_t *p_libvlc ) */ int libvlc_InternalDestroy( libvlc_int_t *p_libvlc, vlc_bool_t b_release ) { - /* Free allocated memory */ + vlc_value_t lockval; + + if( !p_libvlc ) + return VLC_EGENERIC; + +#ifndef WIN32 + char* psz_pidfile = NULL; + + if( libvlc_global.p_module_bank ) + if( config_GetInt( p_libvlc, "daemon" ) ) + { + psz_pidfile = config_GetPsz( p_libvlc, "pidfile" ); + if( psz_pidfile != NULL ) + { + msg_Dbg( p_libvlc, "removing pid file %s", psz_pidfile ); + if( unlink( psz_pidfile ) == -1 ) + { + msg_Dbg( p_libvlc, "removing pid file %s: %m", + psz_pidfile ); + } + } + free ( psz_pidfile ); + } +#endif + if( p_libvlc->p_memcpy_module ) { module_Unneed( p_libvlc, p_libvlc->p_memcpy_module ); p_libvlc->p_memcpy_module = NULL; } - /* Free module bank ! */ + /* Free module bank. It is refcounted, so we call this each time */ module_EndBank( p_libvlc ); FREENULL( p_libvlc->psz_homedir ); - FREENULL( p_libvlc->psz_userdir ); + FREENULL( p_libvlc->psz_configdir ); + FREENULL( p_libvlc->psz_datadir ); + FREENULL( p_libvlc->psz_cachedir ); FREENULL( p_libvlc->psz_configfile ); FREENULL( p_libvlc->p_hotkeys ); - /* System specific cleaning code */ - system_End( p_libvlc ); + var_Create( p_libvlc_global, "libvlc", VLC_VAR_MUTEX ); + var_Get( p_libvlc_global, "libvlc", &lockval ); + vlc_mutex_lock( lockval.p_address ); + i_instances--; - /* - * Free message queue. - * Nobody shall use msg_* afterward. - */ - msg_Flush( p_libvlc ); - msg_Destroy( p_libvlc_global ); + if( i_instances == 0 ) + { + /* System specific cleaning code */ + system_End( p_libvlc ); + } + vlc_mutex_unlock( lockval.p_address ); + var_Destroy( p_libvlc_global, "libvlc" ); - /* Destroy global iconv */ - LocaleDeinit(); + msg_Flush( p_libvlc ); + msg_Destroy( p_libvlc ); /* Destroy mutexes */ vlc_mutex_destroy( &p_libvlc->config_lock ); + vlc_mutex_destroy( &p_libvlc->timer_lock ); - vlc_object_detach( p_libvlc ); if( b_release ) vlc_object_release( p_libvlc ); vlc_object_destroy( p_libvlc ); + p_libvlc = NULL; - /* Stop thread system: last one out please shut the door! */ + /* Stop thread system: last one out please shut the door! + * The number of initializations of the thread system is counted, we + * can call this each time */ vlc_threads_end( p_libvlc_global ); return VLC_SUCCESS; @@ -915,13 +1103,16 @@ int libvlc_InternalDestroy( libvlc_int_t *p_libvlc, vlc_bool_t b_release ) int libvlc_InternalAddIntf( libvlc_int_t *p_libvlc, char const *psz_module, vlc_bool_t b_block, vlc_bool_t b_play, - int i_options, char **ppsz_options ) + int i_options, const char *const *ppsz_options ) { int i_err; - intf_thread_t *p_intf; + intf_thread_t *p_intf = NULL; + + if( !p_libvlc ) + return VLC_EGENERIC; #ifndef WIN32 - if( p_libvlc->p_libvlc_global->b_daemon && b_block && !psz_module ) + if( libvlc_global.b_daemon && b_block && !psz_module ) { /* Daemon mode hack. * We prefer the dummy interface if none is specified. */ @@ -934,7 +1125,6 @@ int libvlc_InternalAddIntf( libvlc_int_t *p_libvlc, /* Try to create the interface */ p_intf = intf_Create( p_libvlc, psz_module ? psz_module : "$intf", i_options, ppsz_options ); - if( p_intf == NULL ) { msg_Err( p_libvlc, "interface \"%s\" initialization failed", @@ -948,18 +1138,31 @@ int libvlc_InternalAddIntf( libvlc_int_t *p_libvlc, /* Try to run the interface */ p_intf->b_play = b_play; - p_intf->b_block = b_block; i_err = intf_RunThread( p_intf ); - if( i_err ) + if( i_err || p_intf->b_should_run_on_first_thread ) { vlc_object_detach( p_intf ); intf_Destroy( p_intf ); + p_intf = NULL; return i_err; } + + if( b_block ) + { + /* FIXME: should be moved to interface/interface.c */ + if( p_intf->pf_run ) + vlc_thread_join( p_intf ); + else + while( vlc_object_lock_and_wait( p_intf ) == 0 ); + + vlc_object_detach( p_intf ); + intf_Destroy( p_intf ); + } + return VLC_SUCCESS; }; - +#if defined (__APPLE__) || defined (WIN32) /***************************************************************************** * SetLanguage: set the interface language. ***************************************************************************** @@ -967,61 +1170,70 @@ int libvlc_InternalAddIntf( libvlc_int_t *p_libvlc, * as well as the LC_CTYPE category for string sorting and possible wide * character support. *****************************************************************************/ -static void SetLanguage ( char const *psz_lang ) +static void SetLanguage ( const char *psz_lang ) { -#if defined( ENABLE_NLS ) \ - && ( defined( HAVE_GETTEXT ) || defined( HAVE_INCLUDED_GETTEXT ) ) +#ifdef __APPLE__ + /* I need that under Darwin, please check it doesn't disturb + * other platforms. --Meuuh */ + setenv( "LANG", psz_lang, 1 ); - char * psz_path; -#if defined( __APPLE__ ) || defined ( WIN32 ) || defined( SYS_BEOS ) - char psz_tmp[1024]; +#else + /* We set LC_ALL manually because it is the only way to set + * the language at runtime under eg. Windows. Beware that this + * makes the environment unconsistent when libvlc is unloaded and + * should probably be moved to a safer place like vlc.c. */ + static char psz_lcall[20]; + snprintf( psz_lcall, 19, "LC_ALL=%s", psz_lang ); + psz_lcall[19] = '\0'; + putenv( psz_lcall ); #endif - if( psz_lang && !*psz_lang ) - { -# if defined( HAVE_LC_MESSAGES ) - setlocale( LC_MESSAGES, psz_lang ); -# endif - setlocale( LC_CTYPE, psz_lang ); - } - else if( psz_lang ) - { -#ifdef __APPLE__ - /* I need that under Darwin, please check it doesn't disturb - * other platforms. --Meuuh */ - setenv( "LANG", psz_lang, 1 ); - -#elif defined( SYS_BEOS ) || defined( WIN32 ) - /* We set LC_ALL manually because it is the only way to set - * the language at runtime under eg. Windows. Beware that this - * makes the environment unconsistent when libvlc is unloaded and - * should probably be moved to a safer place like vlc.c. */ - static char psz_lcall[20]; - snprintf( psz_lcall, 19, "LC_ALL=%s", psz_lang ); - psz_lcall[19] = '\0'; - putenv( psz_lcall ); + setlocale( LC_ALL, psz_lang ); +} #endif - setlocale( LC_ALL, psz_lang ); - } +static inline int LoadMessages (void) +{ +#if defined( ENABLE_NLS ) \ + && ( defined( HAVE_GETTEXT ) || defined( HAVE_INCLUDED_GETTEXT ) ) /* Specify where to find the locales for current domain */ #if !defined( __APPLE__ ) && !defined( WIN32 ) && !defined( SYS_BEOS ) - psz_path = LOCALEDIR; + static const char psz_path[] = LOCALEDIR; #else - snprintf( psz_tmp, sizeof(psz_tmp), "%s/%s", libvlc_global.psz_vlcpath, - "locale" ); - psz_path = psz_tmp; + char psz_path[1024]; + if (snprintf (psz_path, sizeof (psz_path), "%s/%s", + libvlc_global.psz_vlcpath, "locale") + >= (int)sizeof (psz_path)) + return -1; + #endif - if( !bindtextdomain( PACKAGE_NAME, psz_path ) ) + if (bindtextdomain (PACKAGE_NAME, psz_path) == NULL) + { + fprintf (stderr, "Warning: cannot bind text domain "PACKAGE_NAME + " to directory %s\n", psz_path); + return -1; + } + + /* LibVLC wants all messages in UTF-8. + * Unfortunately, we cannot ask UTF-8 for strerror_r(), strsignal_r() + * and other functions that are not part of our text domain. + */ + if (bind_textdomain_codeset (PACKAGE_NAME, "UTF-8") == NULL) { - fprintf( stderr, "warning: couldn't bind domain %s in directory %s\n", - PACKAGE_NAME, psz_path ); + fprintf (stderr, "Error: cannot set Unicode encoding for text domain " + PACKAGE_NAME"\n"); + // Unbinds the text domain to avoid broken encoding + bindtextdomain (PACKAGE_NAME, "DOES_NOT_EXIST"); + return -1; } - /* Set the default domain */ - bind_textdomain_codeset( PACKAGE_NAME, "UTF-8" ); + /* LibVLC does NOT set the default textdomain, since it is a library. + * This could otherwise break programs using LibVLC (other than VLC). + * textdomain (PACKAGE_NAME); + */ #endif + return 0; } /***************************************************************************** @@ -1030,7 +1242,7 @@ static void SetLanguage ( char const *psz_lang ) * Parse command line for input files as well as their associated options. * An option always follows its associated input and begins with a ":". *****************************************************************************/ -static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, char *ppsz_argv[] ) +static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, const char *ppsz_argv[] ) { int i_opt, i_options; @@ -1038,7 +1250,6 @@ static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, char *ppsz_argv[] ) * and their input options */ for( i_opt = i_argc - 1; i_opt >= optind; i_opt-- ) { - const char *psz_target; i_options = 0; /* Count the input options */ @@ -1050,13 +1261,11 @@ static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, char *ppsz_argv[] ) /* TODO: write an internal function of this one, to avoid * unnecessary lookups. */ - /* FIXME: should we convert options to UTF-8 as well ?? */ - psz_target = FromLocale( ppsz_argv[ i_opt ] ); - VLC_AddTarget( p_vlc->i_object_id, psz_target, - (char const **)( i_options ? &ppsz_argv[i_opt + 1] : + + VLC_AddTarget( p_vlc->i_object_id, ppsz_argv[i_opt], + ( i_options ? &ppsz_argv[i_opt + 1] : NULL ), i_options, PLAYLIST_INSERT, 0 ); - LocaleFree( psz_target ); } return VLC_SUCCESS; @@ -1075,13 +1284,13 @@ static void Help( libvlc_int_t *p_this, char const *psz_help_name ) if( psz_help_name && !strcmp( psz_help_name, "help" ) ) { - utf8_fprintf( stdout, VLC_USAGE, p_this->psz_object_name ); + utf8_fprintf( stdout, vlc_usage, p_this->psz_object_name ); Usage( p_this, "help" ); Usage( p_this, "main" ); } else if( psz_help_name && !strcmp( psz_help_name, "longhelp" ) ) { - utf8_fprintf( stdout, VLC_USAGE, p_this->psz_object_name ); + utf8_fprintf( stdout, vlc_usage, p_this->psz_object_name ); Usage( p_this, NULL ); } else if( psz_help_name ) @@ -1102,53 +1311,96 @@ static void Help( libvlc_int_t *p_this, char const *psz_help_name ) static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) { #define FORMAT_STRING " %s --%s%s%s%s%s%s%s " - /* short option ------' | | | | | | | - * option name ------------' | | | | | | - * -----------------------------' | | | - * padding spaces ---------------------' | | - * comment -------------------------------' | - * comment suffix --------------------------' + /* short option ------' | | | | | | | + * option name ------------' | | | | | | + * -------------------------' | | | + * padding spaces -----------------' | | + * comment --------------------------' | + * comment suffix ---------------------' * * The purpose of having bra and ket is that we might i18n them as well. */ + +# define COL(x) "\033[" #x ";1m" +# define RED COL(31) +# define GREEN COL(32) +# define YELLOW COL(33) +# define BLUE COL(34) +# define MAGENTA COL(35) +# define CYAN COL(36) +# define WHITE COL(37) +# define GRAY "\033[0m" +#define COLOR_FORMAT_STRING (WHITE" %s --%s"YELLOW"%s%s%s%s%s%s "GRAY) +#define COLOR_FORMAT_STRING_BOOL (WHITE" %s --%s%s%s%s%s%s%s "GRAY) + #define LINE_START 8 #define PADDING_SPACES 25 - vlc_list_t *p_list; - module_t *p_parser; - module_config_t *p_item; +#ifdef WIN32 +# define OPTION_VALUE_SEP "=" +#else +# define OPTION_VALUE_SEP " " +#endif + vlc_list_t *p_list = NULL; char psz_spaces_text[PADDING_SPACES+LINE_START+1]; char psz_spaces_longtext[LINE_START+3]; - char psz_format[sizeof(FORMAT_STRING)]; + char psz_format[sizeof(COLOR_FORMAT_STRING)]; + char psz_format_bool[sizeof(COLOR_FORMAT_STRING_BOOL)]; char psz_buffer[10000]; char psz_short[4]; int i_index; int i_width = ConsoleWidth() - (PADDING_SPACES+LINE_START+1); - vlc_bool_t b_advanced = config_GetInt( p_this, "advanced" ); - vlc_bool_t b_description; + int i_width_description = i_width + PADDING_SPACES - 1; + vlc_bool_t b_advanced = config_GetInt( p_this, "advanced" ); + vlc_bool_t b_description = config_GetInt( p_this, "help-verbose" ); + vlc_bool_t b_description_hack; + vlc_bool_t b_color = config_GetInt( p_this, "color" ); memset( psz_spaces_text, ' ', PADDING_SPACES+LINE_START ); psz_spaces_text[PADDING_SPACES+LINE_START] = '\0'; memset( psz_spaces_longtext, ' ', LINE_START+2 ); psz_spaces_longtext[LINE_START+2] = '\0'; - strcpy( psz_format, FORMAT_STRING ); + if( b_color ) + { + strcpy( psz_format, COLOR_FORMAT_STRING ); + strcpy( psz_format_bool, COLOR_FORMAT_STRING_BOOL ); + } + else + { + strcpy( psz_format, FORMAT_STRING ); + strcpy( psz_format_bool, FORMAT_STRING ); + } /* List all modules */ p_list = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE ); + /* Ugly hack to make sure that the help options always come first + * (part 1) */ + if( !psz_module_name ) + Usage( p_this, "help" ); + /* Enumerate the config for each module */ for( i_index = 0; i_index < p_list->i_count; i_index++ ) { vlc_bool_t b_help_module; - - p_parser = (module_t *)p_list->p_values[i_index].p_object ; + module_t *p_parser = (module_t *)p_list->p_values[i_index].p_object; + module_config_t *p_item = NULL; + module_config_t *p_end = p_parser->p_config + p_parser->confsize; if( psz_module_name && strcmp( psz_module_name, p_parser->psz_object_name ) ) { - continue; + const char *const *pp_shortcut = p_parser->pp_shortcuts; + while( *pp_shortcut ) + { + if( !strcmp( psz_module_name, *pp_shortcut ) ) + break; + pp_shortcut ++; + } + if( !*pp_shortcut ) + continue; } /* Ignore modules without config options */ @@ -1157,37 +1409,54 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) continue; } + b_help_module = !strcmp( "help", p_parser->psz_object_name ); + /* Ugly hack to make sure that the help options always come first + * (part 2) */ + if( !psz_module_name && b_help_module ) + continue; + /* Ignore modules with only advanced config options if requested */ if( !b_advanced ) { for( p_item = p_parser->p_config; - p_item->i_type != CONFIG_HINT_END; + p_item < p_end; p_item++ ) { if( (p_item->i_type & CONFIG_ITEM) && !p_item->b_advanced ) break; } - if( p_item->i_type == CONFIG_HINT_END ) continue; } /* Print name of module */ if( strcmp( "main", p_parser->psz_object_name ) ) - utf8_fprintf( stdout, "\n %s\n", p_parser->psz_longname ); - - b_help_module = !strcmp( "help", p_parser->psz_object_name ); + { + if( b_color ) + utf8_fprintf( stdout, "\n " GREEN "%s" GRAY "\n", + p_parser->psz_longname ); + else + utf8_fprintf( stdout, "\n %s\n", p_parser->psz_longname ); + } + if( p_parser->psz_help ) + { + if( b_color ) + utf8_fprintf( stdout, CYAN" %s\n"GRAY, p_parser->psz_help ); + else + utf8_fprintf( stdout, " %s\n", p_parser->psz_help ); + } /* Print module options */ for( p_item = p_parser->p_config; - p_item->i_type != CONFIG_HINT_END; + p_item < p_end; p_item++ ) { char *psz_text, *psz_spaces = psz_spaces_text; - char *psz_bra = NULL, *psz_type = NULL, *psz_ket = NULL; - char *psz_suf = "", *psz_prefix = NULL; + const char *psz_bra = NULL, *psz_type = NULL, *psz_ket = NULL; + const char *psz_suf = "", *psz_prefix = NULL; signed int i; + size_t i_cur_width; - /* Skip deprecated options */ - if( p_item->psz_current ) + /* Skip removed options */ + if( p_item->b_removed ) { continue; } @@ -1202,7 +1471,41 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) case CONFIG_HINT_CATEGORY: case CONFIG_HINT_USAGE: if( !strcmp( "main", p_parser->psz_object_name ) ) - utf8_fprintf( stdout, "\n %s\n", p_item->psz_text ); + { + if( b_color ) + utf8_fprintf( stdout, GREEN "\n %s\n" GRAY, + p_item->psz_text ); + else + utf8_fprintf( stdout, "\n %s\n", p_item->psz_text ); + } + if( b_description && p_item->psz_longtext ) + { + if( b_color ) + utf8_fprintf( stdout, CYAN " %s\n" GRAY, + p_item->psz_longtext ); + else + utf8_fprintf( stdout, " %s\n", p_item->psz_longtext ); + } + break; + + case CONFIG_HINT_SUBCATEGORY: + if( strcmp( "main", p_parser->psz_object_name ) ) + break; + case CONFIG_SECTION: + if( b_color ) + { + utf8_fprintf( stdout, RED" %s:\n"GRAY, + p_item->psz_text ); + if( b_description && p_item->psz_longtext ) + utf8_fprintf( stdout, MAGENTA" %s\n"GRAY, + p_item->psz_longtext ); + } + else + { + utf8_fprintf( stdout, " %s:\n", p_item->psz_text ); + if( b_description && p_item->psz_longtext ) + utf8_fprintf( stdout, " %s\n", p_item->psz_longtext ); + } break; case CONFIG_ITEM_STRING: @@ -1212,34 +1515,45 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) case CONFIG_ITEM_MODULE_CAT: case CONFIG_ITEM_MODULE_LIST: case CONFIG_ITEM_MODULE_LIST_CAT: - psz_bra = " <"; psz_type = _("string"); psz_ket = ">"; + psz_bra = OPTION_VALUE_SEP "<"; + psz_type = _("string"); + psz_ket = ">"; if( p_item->ppsz_list ) { - psz_bra = " {"; + psz_bra = OPTION_VALUE_SEP "{"; psz_type = psz_buffer; - psz_type[0] = '\0'; + psz_buffer[0] = '\0'; for( i = 0; p_item->ppsz_list[i]; i++ ) { - if( i ) strcat( psz_type, "," ); - strcat( psz_type, p_item->ppsz_list[i] ); + if( i ) strcat( psz_buffer, "," ); + strcat( psz_buffer, p_item->ppsz_list[i] ); } psz_ket = "}"; } break; case CONFIG_ITEM_INTEGER: case CONFIG_ITEM_KEY: /* FIXME: do something a bit more clever */ - psz_bra = " <"; psz_type = _("integer"); psz_ket = ">"; + psz_bra = OPTION_VALUE_SEP "<"; + psz_type = _("integer"); + psz_ket = ">"; + + if( p_item->min.i || p_item->max.i ) + { + sprintf( psz_buffer, "%s [%i .. %i]", psz_type, + p_item->min.i, p_item->max.i ); + psz_type = psz_buffer; + } if( p_item->i_list ) { - psz_bra = " {"; + psz_bra = OPTION_VALUE_SEP "{"; psz_type = psz_buffer; - psz_type[0] = '\0'; + psz_buffer[0] = '\0'; for( i = 0; p_item->ppsz_list_text[i]; i++ ) { - if( i ) strcat( psz_type, ", " ); - sprintf( psz_type + strlen(psz_type), "%i (%s)", + if( i ) strcat( psz_buffer, ", " ); + sprintf( psz_buffer + strlen(psz_buffer), "%i (%s)", p_item->pi_list[i], p_item->ppsz_list_text[i] ); } @@ -1247,13 +1561,21 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) } break; case CONFIG_ITEM_FLOAT: - psz_bra = " <"; psz_type = _("float"); psz_ket = ">"; + psz_bra = OPTION_VALUE_SEP "<"; + psz_type = _("float"); + psz_ket = ">"; + if( p_item->min.f || p_item->max.f ) + { + sprintf( psz_buffer, "%s [%f .. %f]", psz_type, + p_item->min.f, p_item->max.f ); + psz_type = psz_buffer; + } break; case CONFIG_ITEM_BOOL: psz_bra = ""; psz_type = ""; psz_ket = ""; if( !b_help_module ) { - psz_suf = p_item->i_value ? _(" (default enabled)") : + psz_suf = p_item->value.i ? _(" (default enabled)") : _(" (default disabled)"); } break; @@ -1296,9 +1618,9 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) if( p_item->i_type == CONFIG_ITEM_BOOL && !b_help_module ) { - utf8_fprintf( stdout, psz_format, psz_short, p_item->psz_name, - psz_prefix, p_item->psz_name, psz_bra, psz_type, - psz_ket, psz_spaces ); + utf8_fprintf( stdout, psz_format_bool, psz_short, + p_item->psz_name, psz_prefix, p_item->psz_name, + psz_bra, psz_type, psz_ket, psz_spaces ); } else { @@ -1310,19 +1632,32 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) /* We wrap the rest of the output */ sprintf( psz_buffer, "%s%s", p_item->psz_text, psz_suf ); - b_description = config_GetInt( p_this, "help-verbose" ); + b_description_hack = b_description; description: psz_text = psz_buffer; + i_cur_width = b_description && !b_description_hack + ? i_width_description + : i_width; while( *psz_text ) { char *psz_parser, *psz_word; size_t i_end = strlen( psz_text ); /* If the remaining text fits in a line, print it. */ - if( i_end <= (size_t)i_width ) + if( i_end <= i_cur_width ) { - utf8_fprintf( stdout, "%s\n", psz_text ); + if( b_color ) + { + if( !b_description || b_description_hack ) + utf8_fprintf( stdout, BLUE"%s\n"GRAY, psz_text ); + else + utf8_fprintf( stdout, "%s\n", psz_text ); + } + else + { + utf8_fprintf( stdout, "%s\n", psz_text ); + } break; } @@ -1337,7 +1672,7 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) psz_parser = psz_parser ? psz_parser + 1 : psz_text + i_end; - } while( psz_parser - psz_text <= i_width ); + } while( (size_t)(psz_parser - psz_text) <= i_cur_width ); /* We cut a word in one of these cases: * - it's the only word in the line and it's too long. @@ -1345,27 +1680,51 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) * going to wrap is longer than 40% of the width, and even * if the word would have fit in the next line. */ if( psz_word == psz_text - || ( psz_word - psz_text < 80 * i_width / 100 - && psz_parser - psz_word > 40 * i_width / 100 ) ) + || ( (size_t)(psz_word - psz_text) < 80 * i_cur_width / 100 + && (size_t)(psz_parser - psz_word) > 40 * i_cur_width / 100 ) ) { - char c = psz_text[i_width]; - psz_text[i_width] = '\0'; - utf8_fprintf( stdout, "%s\n%s", psz_text, psz_spaces ); - psz_text += i_width; + char c = psz_text[i_cur_width]; + psz_text[i_cur_width] = '\0'; + if( b_color ) + { + if( !b_description || b_description_hack ) + utf8_fprintf( stdout, BLUE"%s\n%s"GRAY, + psz_text, psz_spaces ); + else + utf8_fprintf( stdout, "%s\n%s", + psz_text, psz_spaces ); + } + else + { + utf8_fprintf( stdout, "%s\n%s", psz_text, psz_spaces ); + } + psz_text += i_cur_width; psz_text[0] = c; } else { psz_word[-1] = '\0'; - utf8_fprintf( stdout, "%s\n%s", psz_text, psz_spaces ); + if( b_color ) + { + if( !b_description || b_description_hack ) + utf8_fprintf( stdout, BLUE"%s\n%s"GRAY, + psz_text, psz_spaces ); + else + utf8_fprintf( stdout, "%s\n%s", + psz_text, psz_spaces ); + } + else + { + utf8_fprintf( stdout, "%s\n%s", psz_text, psz_spaces ); + } psz_text = psz_word; } } - if( b_description && p_item->psz_longtext ) + if( b_description_hack && p_item->psz_longtext ) { sprintf( psz_buffer, "%s%s", p_item->psz_longtext, psz_suf ); - b_description = VLC_FALSE; + b_description_hack = VLC_FALSE; psz_spaces = psz_spaces_longtext; utf8_fprintf( stdout, "%s", psz_spaces ); goto description; @@ -1383,13 +1742,15 @@ static void Usage( libvlc_int_t *p_this, char const *psz_module_name ) * Print a list of all available modules (builtins and plugins) and a short * description for each one. *****************************************************************************/ -static void ListModules( libvlc_int_t *p_this ) +static void ListModules( libvlc_int_t *p_this, vlc_bool_t b_verbose ) { - vlc_list_t *p_list; - module_t *p_parser; + vlc_list_t *p_list = NULL; + module_t *p_parser = NULL; char psz_spaces[22]; int i_index; + vlc_bool_t b_color = config_GetInt( p_this, "color" ); + memset( psz_spaces, ' ', 22 ); #ifdef WIN32 @@ -1412,8 +1773,44 @@ static void ListModules( libvlc_int_t *p_this ) if( i < 0 ) i = 0; psz_spaces[i] = 0; - utf8_fprintf( stdout, " %s%s %s\n", p_parser->psz_object_name, - psz_spaces, p_parser->psz_longname ); + if( b_color ) + utf8_fprintf( stdout, GREEN" %s%s "WHITE"%s\n"GRAY, + p_parser->psz_object_name, + psz_spaces, + p_parser->psz_longname ); + else + utf8_fprintf( stdout, " %s%s %s\n", + p_parser->psz_object_name, + psz_spaces, p_parser->psz_longname ); + + if( b_verbose ) + { + const char *const *pp_shortcut = p_parser->pp_shortcuts; + while( *pp_shortcut ) + { + if( strcmp( *pp_shortcut, p_parser->psz_object_name ) ) + { + if( b_color ) + utf8_fprintf( stdout, CYAN" s %s\n"GRAY, + *pp_shortcut ); + else + utf8_fprintf( stdout, " s %s\n", + *pp_shortcut ); + } + pp_shortcut++; + } + if( p_parser->psz_capability ) + { + if( b_color ) + utf8_fprintf( stdout, MAGENTA" c %s (%d)\n"GRAY, + p_parser->psz_capability, + p_parser->i_score ); + else + utf8_fprintf( stdout, " c %s (%d)\n", + p_parser->psz_capability, + p_parser->i_score ); + } + } psz_spaces[i] = ' '; } @@ -1440,11 +1837,9 @@ static void Version( void ) utf8_fprintf( stdout, _("Compiled by %s@%s.%s\n"), VLC_CompileBy(), VLC_CompileHost(), VLC_CompileDomain() ); utf8_fprintf( stdout, _("Compiler: %s\n"), VLC_Compiler() ); -#ifndef HAVE_SHARED_LIBVLC if( strcmp( VLC_Changeset(), "exported" ) ) utf8_fprintf( stdout, _("Based upon svn changeset [%s]\n"), VLC_Changeset() ); -#endif utf8_fprintf( stdout, LICENSE_MSG ); #ifdef WIN32 /* Pause the console because it's destroyed when we exit */ @@ -1461,7 +1856,7 @@ static void Version( void ) static void ShowConsole( vlc_bool_t b_dofile ) { # ifndef UNDER_CE - FILE *f_help; + FILE *f_help = NULL; if( getenv( "PWD" ) && getenv( "PS1" ) ) return; /* cygwin shell */ @@ -1476,7 +1871,6 @@ static void ShowConsole( vlc_bool_t b_dofile ) freopen( "vlc-help.txt", "wt", stdout ); utf8_fprintf( stderr, _("\nDumped content to vlc-help.txt file.\n") ); } - else freopen( "CONOUT$", "w", stdout ); # endif @@ -1514,8 +1908,9 @@ static int ConsoleWidth( void ) int i_width = 80; #ifndef WIN32 - char buf[20], *psz_parser; - FILE *file; + char buf[20]; + char *psz_parser = NULL; + FILE *file = NULL; int i_ret; file = popen( "stty size 2>/dev/null", "r" ); @@ -1546,11 +1941,14 @@ static int ConsoleWidth( void ) static int VerboseCallback( vlc_object_t *p_this, const char *psz_variable, vlc_value_t old_val, vlc_value_t new_val, void *param) { - libvlc_int_t *p_vlc = (libvlc_int_t *)p_this; + libvlc_int_t *p_libvlc = (libvlc_int_t *)p_this; + (void)psz_variable; + (void)old_val; + (void)param; if( new_val.i_int >= -1 ) { - p_vlc->p_libvlc_global->i_verbose = __MIN( new_val.i_int, 2 ); + p_libvlc->i_verbose = __MIN( new_val.i_int, 2 ); } return VLC_SUCCESS; } @@ -1563,20 +1961,21 @@ static int VerboseCallback( vlc_object_t *p_this, const char *psz_variable, static void InitDeviceValues( libvlc_int_t *p_vlc ) { #ifdef HAVE_HAL - LibHalContext * ctx; + LibHalContext * ctx = NULL; int i, i_devices; - char **devices; - char *block_dev; + char **devices = NULL; + char *block_dev = NULL; dbus_bool_t b_dvd; - DBusConnection *p_connection; - DBusError error; #ifdef HAVE_HAL_1 - ctx = libhal_ctx_new(); + DBusConnection *p_connection = NULL; + DBusError error; + + ctx = libhal_ctx_new(); if( !ctx ) return; dbus_error_init( &error ); p_connection = dbus_bus_get ( DBUS_BUS_SYSTEM, &error ); - if( dbus_error_is_set( &error ) ) + if( dbus_error_is_set( &error ) || !p_connection ) { dbus_error_free( &error ); return; @@ -1584,8 +1983,10 @@ static void InitDeviceValues( libvlc_int_t *p_vlc ) libhal_ctx_set_dbus_connection( ctx, p_connection ); if( libhal_ctx_init( ctx, &error ) ) #else - if( ( ctx = hal_initialize( NULL, FALSE ) ) ) + ctx = hal_initialize( NULL, FALSE ); + if( ctx ) #endif + { #ifdef HAVE_HAL_1 if( ( devices = libhal_get_all_devices( ctx, &i_devices, NULL ) ) ) @@ -1638,6 +2039,7 @@ static void InitDeviceValues( libvlc_int_t *p_vlc ) #ifdef HAVE_HAL_1 libhal_ctx_shutdown( ctx, NULL ); + dbus_connection_unref( p_connection ); #else hal_shutdown( ctx ); #endif @@ -1646,5 +2048,7 @@ static void InitDeviceValues( libvlc_int_t *p_vlc ) { msg_Warn( p_vlc, "Unable to get HAL device properties" ); } -#endif +#else + (void)p_vlc; +#endif /* HAVE_HAL */ }