X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Flibvlc.c;h=45fa3a0e5e1a0d08030bce4439d4e5af6793f1d8;hb=2d96ffcfce9f1ce32ec4cd7c208c1f92a0d4c48c;hp=dc5020d60a0bc8f22fb4d71e6540c94ffc55ae8c;hpb=177d9f10b8cc4489a6186acd4d19b42d7040dae2;p=vlc diff --git a/src/libvlc.c b/src/libvlc.c index dc5020d60a..45fa3a0e5e 100644 --- a/src/libvlc.c +++ b/src/libvlc.c @@ -83,10 +83,7 @@ #include "audio_output/aout_internal.h" #include - #include -#include "stream_output/stream_output.h" - #include #include "libvlc.h" @@ -95,6 +92,10 @@ #include +#ifdef __APPLE__ +# include +#endif + #include /***************************************************************************** @@ -107,41 +108,101 @@ static unsigned i_instances = 0; static bool b_daemon = false; #endif -/***************************************************************************** - * vlc_gc_*. - *****************************************************************************/ -void __vlc_gc_incref( gc_object_t * p_gc ) +#undef vlc_gc_init +#undef vlc_hold +#undef vlc_release + +/** + * Atomically set the reference count to 1. + * @param p_gc reference counted object + * @param pf_destruct destruction calback + * @return p_gc. + */ +void *vlc_gc_init (gc_object_t *p_gc, void (*pf_destruct) (gc_object_t *)) { - assert( p_gc->i_gc_refcount > 0 ); + /* There is no point in using the GC if there is no destructor... */ + assert (pf_destruct); + p_gc->pf_destructor = pf_destruct; + + p_gc->refs = 1; +#if defined (__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4) + __sync_synchronize (); +#elif defined (WIN32) && defined (__GNUC__) +#elif defined(__APPLE__) + OSMemoryBarrier (); +#else + /* Nobody else can possibly lock the spin - it's there as a barrier */ + vlc_spin_init (&p_gc->spin); + vlc_spin_lock (&p_gc->spin); + vlc_spin_unlock (&p_gc->spin); +#endif + return p_gc; +} - /* FIXME: atomic version needed! */ - p_gc->i_gc_refcount ++; +/** + * Atomically increment the reference count. + * @param p_gc reference counted object + * @return p_gc. + */ +void *vlc_hold (gc_object_t * p_gc) +{ + uintptr_t refs; + assert( p_gc ); + +#if defined (__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4) + refs = __sync_add_and_fetch (&p_gc->refs, 1); +#elif defined (WIN64) + refs = InterlockedIncrement64 (&p_gc->refs); +#elif defined (WIN32) + refs = InterlockedIncrement (&p_gc->refs); +#elif defined(__APPLE__) + refs = OSAtomicIncrement32Barrier((int*)&p_gc->refs); +#else + vlc_spin_lock (&p_gc->spin); + refs = ++p_gc->refs; + vlc_spin_unlock (&p_gc->spin); +#endif + assert (refs != 1); /* there had to be a reference already */ + return p_gc; } -void __vlc_gc_decref( gc_object_t *p_gc ) +/** + * Atomically decrement the reference count and, if it reaches zero, destroy. + * @param p_gc reference counted object. + */ +void vlc_release (gc_object_t *p_gc) { + unsigned refs; + assert( p_gc ); - assert( p_gc->i_gc_refcount > 0 ); - /* FIXME: atomic version needed! */ - p_gc->i_gc_refcount -- ; +#if defined (__GCC_HAVE_SYNC_COMPARE_AND_SWAP_4) + refs = __sync_sub_and_fetch (&p_gc->refs, 1); +#elif defined (WIN64) + refs = InterlockedDecrement64 (&p_gc->refs); +#elif defined (WIN32) + refs = InterlockedDecrement (&p_gc->refs); +#elif defined(__APPLE__) + refs = OSAtomicDecrement32Barrier((int*)&p_gc->refs); +#else + vlc_spin_lock (&p_gc->spin); + refs = --p_gc->refs; + vlc_spin_unlock (&p_gc->spin); +#endif - if( p_gc->i_gc_refcount == 0 ) + assert (refs != (uintptr_t)(-1)); /* reference underflow?! */ + if (refs == 0) { - p_gc->pf_destructor( p_gc ); - /* Do not use the p_gc pointer from now on ! */ +#ifdef USE_SYNC +#elif defined (WIN32) && defined (__GNUC__) +#elif defined(__APPLE__) +#else + vlc_spin_destroy (&p_gc->spin); +#endif + p_gc->pf_destructor (p_gc); } } -void -__vlc_gc_init( gc_object_t * p_gc, void (*pf_destructor)( gc_object_t * ), - void * arg) -{ - p_gc->i_gc_refcount = 1; - p_gc->pf_destructor = pf_destructor; - p_gc->p_destructor_arg = arg; -} - /***************************************************************************** * Local prototypes *****************************************************************************/ @@ -167,6 +228,8 @@ static int VerboseCallback( vlc_object_t *, char const *, static void InitDeviceValues( libvlc_int_t * ); +static vlc_mutex_t global_lock = VLC_STATIC_MUTEX; + /** * Allocate a libvlc instance, initialize global data if needed * It also initializes the threading system @@ -177,28 +240,22 @@ libvlc_int_t * libvlc_InternalCreate( void ) libvlc_priv_t *priv; char *psz_env = NULL; - /* vlc_threads_init *must* be the first internal call! No other call is - * allowed before the thread system has been initialized. */ - if (vlc_threads_init ()) - return NULL; - /* Now that the thread system is initialized, we don't have much, but * at least we have variables */ - vlc_mutex_t *lock = var_AcquireMutex( "libvlc" ); + vlc_mutex_lock( &global_lock ); if( i_instances == 0 ) { /* Guess what CPU we have */ cpu_flags = CPUCapabilities(); /* The module bank will be initialized later */ - p_module_bank = NULL; } /* Allocate a libvlc instance object */ p_libvlc = __vlc_custom_create( NULL, sizeof (*priv), - VLC_OBJECT_LIBVLC, "libvlc" ); + VLC_OBJECT_GENERIC, "libvlc" ); if( p_libvlc != NULL ) i_instances++; - vlc_mutex_unlock( lock ); + vlc_mutex_unlock( &global_lock ); if( p_libvlc == NULL ) return NULL; @@ -308,10 +365,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, priv->psz_configfile = config_GetCustomConfigFile( p_libvlc ); /* Check for plugins cache options */ - if( config_GetInt( p_libvlc, "reset-plugins-cache" ) > 0 ) - { - p_module_bank->b_cache_delete = true; - } + bool b_cache_delete = config_GetInt( p_libvlc, "reset-plugins-cache" ) > 0; /* Will be re-done properly later on */ priv->i_verbose = config_GetInt( p_libvlc, "verbose" ); @@ -402,8 +456,6 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, psz_language = config_GetPsz( p_libvlc, "language" ); if( psz_language && *psz_language && strcmp( psz_language, "auto" ) ) { - bool b_cache_delete = p_module_bank->b_cache_delete; - /* Reset the default domain */ SetLanguage( psz_language ); @@ -415,7 +467,6 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, if( !config_GetInt( p_libvlc, "ignore-config" ) ) config_LoadConfigFile( p_libvlc, "main" ); config_LoadCmdLine( p_libvlc, &i_argc, ppsz_argv, true ); - p_module_bank->b_cache_delete = b_cache_delete; } free( psz_language ); # endif @@ -428,14 +479,16 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, * default values. */ module_LoadBuiltins( p_libvlc ); - module_LoadPlugins( p_libvlc ); + module_LoadPlugins( p_libvlc, b_cache_delete ); if( p_libvlc->b_die ) { b_exit = true; } - msg_Dbg( p_libvlc, "module bank initialized, found %i modules", - vlc_internals( p_module_bank )->i_children ); + size_t module_count; + module_t **list = module_list_get( &module_count ); + module_list_free( list ); + msg_Dbg( p_libvlc, "module bank initialized (%zu modules)", module_count ); /* Check for help on modules */ if( (p_tmp = config_GetPsz( p_libvlc, "module" )) ) @@ -534,7 +587,9 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, #ifdef HAVE_DBUS dbus_threads_init_default(); - if( config_GetInt( p_libvlc, "one-instance" ) > 0 ) + if( config_GetInt( p_libvlc, "one-instance" ) > 0 + || ( config_GetInt( p_libvlc, "one-instance-when-started-from-file" ) + && config_GetInt( p_libvlc, "started-from-file" ) ) ) { /* Initialise D-Bus interface, check for other instances */ DBusConnection *p_conn = NULL; @@ -689,11 +744,6 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, if( priv->b_color ) priv->b_color = config_GetInt( p_libvlc, "color" ) > 0; - /* - * Output messages that may still be in the queue - */ - msg_Flush( p_libvlc ); - if( !config_GetInt( p_libvlc, "fpu" ) ) cpu_flags &= ~CPU_CAPABILITY_FPU; @@ -738,7 +788,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, /* * Choose the best memcpy module */ - priv->p_memcpy_module = module_Need( p_libvlc, "memcpy", "$memcpy", 0 ); + priv->p_memcpy_module = module_need( p_libvlc, "memcpy", "$memcpy", false ); priv->b_stats = config_GetInt( p_libvlc, "stats" ) > 0; priv->i_timers = 0; @@ -754,9 +804,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, vlc_mutex_init( &p_libvlc->p_stats->lock ); priv->p_stats_computer = NULL; - /* Init the array that holds every input item */ - ARRAY_INIT( priv->input_items ); - priv->i_last_input_id = 0; + priv->i_last_input_id = 0; /* Not very safe, should be removed */ /* * Initialize hotkey handling @@ -779,7 +827,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, msg_Err( p_libvlc, "playlist initialization failed" ); if( priv->p_memcpy_module != NULL ) { - module_Unneed( p_libvlc, priv->p_memcpy_module ); + module_unneed( p_libvlc, priv->p_memcpy_module ); } module_EndBank( p_libvlc ); return VLC_EGENERIC; @@ -835,10 +883,8 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, *psz_parser = '\0'; psz_parser++; } - psz_temp = (char *)malloc( strlen(psz_module) + sizeof(",none") ); - if( psz_temp ) + if( asprintf( &psz_temp, "%s,none", psz_module ) != -1) { - sprintf( psz_temp, "%s,none", psz_module ); libvlc_InternalAddIntf( p_libvlc, psz_temp ); free( psz_temp ); } @@ -854,7 +900,9 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, #ifdef HAVE_DBUS /* loads dbus control interface if in one-instance mode * we do it only when playlist exists, because dbus module needs it */ - if( config_GetInt( p_libvlc, "one-instance" ) > 0 ) + if( config_GetInt( p_libvlc, "one-instance" ) > 0 + || ( config_GetInt( p_libvlc, "one-instance-when-started-from-file" ) + && config_GetInt( p_libvlc, "started-from-file" ) ) ) libvlc_InternalAddIntf( p_libvlc, "dbus,none" ); /* Prevents the power management daemon from suspending the system @@ -874,7 +922,8 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, } #endif - if( config_GetInt( p_libvlc, "file-logging" ) > 0 ) + if( (config_GetInt( p_libvlc, "file-logging" ) > 0) && + !config_GetInt( p_libvlc, "syslog" ) ) { libvlc_InternalAddIntf( p_libvlc, "logger,none" ); } @@ -958,7 +1007,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, var_Get( p_libvlc, "open", &val ); if ( val.psz_string != NULL && *val.psz_string ) { - playlist_t *p_playlist = pl_Yield( p_libvlc ); + playlist_t *p_playlist = pl_Hold( p_libvlc ); playlist_AddExt( p_playlist, val.psz_string, NULL, PLAYLIST_INSERT, 0, -1, NULL, 0, true, pl_Unlocked ); pl_Release( p_libvlc ); @@ -1001,10 +1050,10 @@ int libvlc_InternalCleanup( libvlc_int_t *p_libvlc ) playlist_ServicesDiscoveryKillAll( p_playlist ); /* Free playlist */ - /* Any thread still running must not assume pl_Yield() succeeds. */ + /* Any thread still running must not assume pl_Hold() succeeds. */ msg_Dbg( p_libvlc, "removing playlist" ); priv->p_playlist = NULL; - vlc_object_kill( p_playlist ); /* <-- memory barrier for pl_Yield() */ + vlc_object_kill( p_playlist ); /* <-- memory barrier for pl_Hold() */ vlc_thread_join( p_playlist ); vlc_object_release( p_playlist ); @@ -1022,29 +1071,6 @@ int libvlc_InternalCleanup( libvlc_int_t *p_libvlc ) stats_TimersDumpAll( p_libvlc ); stats_TimersCleanAll( p_libvlc ); -#ifdef ENABLE_SOUT - announce_handler_t * p_announce; - - /* Free announce handler(s?) */ - while( (p_announce = vlc_object_find( p_libvlc, VLC_OBJECT_ANNOUNCE, - FIND_CHILD ) ) ) - { - msg_Dbg( p_libvlc, "removing announce handler" ); - vlc_object_detach( p_announce ); - vlc_object_release( p_announce ); - announce_HandlerDestroy( p_announce ); - } -#endif - - bool b_clean = true; - FOREACH_ARRAY( input_item_t *p_del, priv->input_items ) - msg_Err( p_libvlc, "input item %p has not been deleted properly: refcount %d, name %s", - p_del, p_del->i_gc_refcount, p_del->psz_name ? p_del->psz_name : "(null)" ); - b_clean = false; - FOREACH_END(); - assert( b_clean ); - ARRAY_RESET( priv->input_items ); - msg_Dbg( p_libvlc, "removing stats" ); vlc_mutex_destroy( &p_libvlc->p_stats->lock ); FREENULL( p_libvlc->p_stats ); @@ -1087,7 +1113,7 @@ int libvlc_InternalDestroy( libvlc_int_t *p_libvlc ) if( priv->p_memcpy_module ) { - module_Unneed( p_libvlc, priv->p_memcpy_module ); + module_unneed( p_libvlc, priv->p_memcpy_module ); priv->p_memcpy_module = NULL; } @@ -1099,7 +1125,7 @@ int libvlc_InternalDestroy( libvlc_int_t *p_libvlc ) p_libvlc->p_hotkeys ); FREENULL( p_libvlc->p_hotkeys ); - vlc_mutex_t *lock = var_AcquireMutex( "libvlc" ); + vlc_mutex_lock( &global_lock ); i_instances--; if( i_instances == 0 ) @@ -1107,9 +1133,8 @@ int libvlc_InternalDestroy( libvlc_int_t *p_libvlc ) /* System specific cleaning code */ system_End( p_libvlc ); } - vlc_mutex_unlock( lock ); + vlc_mutex_unlock( &global_lock ); - msg_Flush( p_libvlc ); msg_Destroy( p_libvlc ); /* Destroy mutexes */ @@ -1119,11 +1144,6 @@ int libvlc_InternalDestroy( libvlc_int_t *p_libvlc ) vlc_object_release( p_libvlc ); p_libvlc = NULL; - /* Stop thread system: last one out please shut the door! - * The number of initializations of the thread system is counted, we - * can call this each time */ - vlc_threads_end (); - return VLC_SUCCESS; } @@ -1277,7 +1297,7 @@ static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, const char *ppsz_argv[ /* TODO: write an internal function of this one, to avoid * unnecessary lookups. */ - playlist_t *p_playlist = pl_Yield( p_vlc ); + playlist_t *p_playlist = pl_Hold( p_vlc ); playlist_AddExt( p_playlist, ppsz_argv[i_opt], NULL, PLAYLIST_INSERT, 0, -1, ( i_options ? &ppsz_argv[i_opt + 1] : NULL ), i_options, true, pl_Unlocked ); @@ -1390,14 +1410,12 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) #else # define OPTION_VALUE_SEP " " #endif - vlc_list_t *p_list = NULL; char psz_spaces_text[PADDING_SPACES+LINE_START+1]; char psz_spaces_longtext[LINE_START+3]; char psz_format[sizeof(COLOR_FORMAT_STRING)]; char psz_format_bool[sizeof(COLOR_FORMAT_STRING_BOOL)]; char psz_buffer[10000]; char psz_short[4]; - int i_index; int i_width = ConsoleWidth() - (PADDING_SPACES+LINE_START+1); int i_width_description = i_width + PADDING_SPACES - 1; bool b_advanced = config_GetInt( p_this, "advanced" ) > 0; @@ -1432,7 +1450,9 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) } /* List all modules */ - p_list = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE ); + module_t **list = module_list_get (NULL); + if (!list) + return; /* Ugly hack to make sure that the help options always come first * (part 1) */ @@ -1440,10 +1460,10 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) Usage( p_this, "help" ); /* Enumerate the config for each module */ - for( i_index = 0; i_index < p_list->i_count; i_index++ ) + for (size_t i = 0; list[i]; i++) { bool b_help_module; - module_t *p_parser = (module_t *)p_list->p_values[i_index].p_object; + module_t *p_parser = list[i]; module_config_t *p_item = NULL; module_config_t *p_section = NULL; module_config_t *p_end = p_parser->p_config + p_parser->confsize; @@ -1836,7 +1856,7 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) } /* Release the module list */ - vlc_list_release( p_list ); + module_list_free (list); } /***************************************************************************** @@ -1847,10 +1867,8 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) *****************************************************************************/ static void ListModules( libvlc_int_t *p_this, bool b_verbose ) { - vlc_list_t *p_list = NULL; - module_t *p_parser = NULL; + module_t *p_parser; char psz_spaces[22]; - int i_index; bool b_color = config_GetInt( p_this, "color" ) > 0; @@ -1861,15 +1879,13 @@ static void ListModules( libvlc_int_t *p_this, bool b_verbose ) #endif /* List all modules */ - p_list = vlc_list_find( p_this, VLC_OBJECT_MODULE, FIND_ANYWHERE ); + module_t **list = module_list_get (NULL); /* Enumerate each module */ - for( i_index = 0; i_index < p_list->i_count; i_index++ ) + for (size_t j = 0; (p_parser = list[j]) != NULL; j++) { int i; - p_parser = (module_t *)p_list->p_values[i_index].p_object ; - /* Nasty hack, but right now I'm too tired to think about a nice * solution */ i = 22 - strlen( p_parser->psz_object_name ) - 1; @@ -1917,8 +1933,7 @@ static void ListModules( libvlc_int_t *p_this, bool b_verbose ) psz_spaces[i] = ' '; } - - vlc_list_release( p_list ); + module_list_free (list); #ifdef WIN32 /* Pause the console because it's destroyed when we exit */ PauseConsole(); @@ -2023,7 +2038,7 @@ static int ConsoleWidth( void ) i_width = 80; pclose( file ); } -#else +#elif !defined (UNDER_CE) CONSOLE_SCREEN_BUFFER_INFO buf; if (GetConsoleScreenBufferInfo (GetStdHandle (STD_OUTPUT_HANDLE), &buf))