X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Flibvlc.c;h=cbc575e498584cd04a0b44cb9c955063d941cc2f;hb=7e4d50ac4297d445b46075b0dd87d11a951d5a3e;hp=81dacf921bcab3f1c2f684fe6e9c71076f500f11;hpb=51f8337ec523733193da6eb8990bcd82991aa827;p=vlc diff --git a/src/libvlc.c b/src/libvlc.c index 81dacf921b..cbc575e498 100644 --- a/src/libvlc.c +++ b/src/libvlc.c @@ -65,10 +65,6 @@ # include #endif -#ifdef ENABLE_NLS -# include /* bindtextdomain */ -#endif - #ifdef HAVE_DBUS /* used for one-instance mode */ # include @@ -81,6 +77,7 @@ #include "audio_output/aout_internal.h" #include +#include #include #include @@ -209,7 +206,6 @@ void vlc_release (gc_object_t *p_gc) ( defined( HAVE_GETTEXT ) || defined( HAVE_INCLUDED_GETTEXT ) ) static void SetLanguage ( char const * ); #endif -static inline int LoadMessages (void); static int GetFilenames ( libvlc_int_t *, int, const char *[] ); static void Help ( libvlc_int_t *, char const *psz_help_name ); static void Usage ( libvlc_int_t *, char const *psz_search ); @@ -245,7 +241,7 @@ libvlc_int_t * libvlc_InternalCreate( void ) } /* Allocate a libvlc instance object */ - p_libvlc = __vlc_custom_create( NULL, sizeof (*priv), + p_libvlc = vlc_custom_create( (vlc_object_t *)NULL, sizeof (*priv), VLC_OBJECT_GENERIC, "libvlc" ); if( p_libvlc != NULL ) i_instances++; @@ -260,7 +256,9 @@ libvlc_int_t * libvlc_InternalCreate( void ) priv->p_vlm = NULL; /* Initialize message queue */ - msg_Create( p_libvlc ); + priv->msg_bank = msg_Create (); + if (unlikely(priv->msg_bank == NULL)) + goto error; /* Find verbosity from VLC_VERBOSE environment variable */ psz_env = getenv( "VLC_VERBOSE" ); @@ -278,6 +276,9 @@ libvlc_int_t * libvlc_InternalCreate( void ) vlc_mutex_init( &priv->timer_lock ); return p_libvlc; +error: + vlc_object_release (p_libvlc); + return NULL; } /** @@ -313,7 +314,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, /* * Support for gettext */ - LoadMessages (); + vlc_bindtextdomain (PACKAGE_NAME); /* Initialize the module bank and load the configuration of the * main module. We need to do this at this stage to be able to display @@ -327,7 +328,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, return VLC_EGENERIC; } - priv->i_verbose = config_GetInt( p_libvlc, "verbose" ); + priv->i_verbose = var_InheritInteger( p_libvlc, "verbose" ); /* Announce who we are - Do it only for first instance ? */ msg_Dbg( p_libvlc, "%s", COPYRIGHT_MESSAGE ); msg_Dbg( p_libvlc, "libvlc was configured with %s", CONFIGURE_LINE ); @@ -335,26 +336,23 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, msg_Dbg( p_libvlc, "translation test: code is \"%s\"", _("C") ); /* Check for short help option */ - if( config_GetInt( p_libvlc, "help" ) > 0 ) + if( var_InheritBool( p_libvlc, "help" ) ) { Help( p_libvlc, "help" ); b_exit = true; i_ret = VLC_EEXITSUCCESS; } /* Check for version option */ - else if( config_GetInt( p_libvlc, "version" ) > 0 ) + else if( var_InheritBool( p_libvlc, "version" ) ) { Version(); b_exit = true; i_ret = VLC_EEXITSUCCESS; } - /* Check for plugins cache options */ - bool b_cache_delete = config_GetInt( p_libvlc, "reset-plugins-cache" ) > 0; - /* Check for daemon mode */ #ifndef WIN32 - if( config_GetInt( p_libvlc, "daemon" ) > 0 ) + if( var_InheritBool( p_libvlc, "daemon" ) ) { #ifdef HAVE_DAEMON char *psz_pidfile = NULL; @@ -374,7 +372,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, pid_t i_pid = getpid (); msg_Dbg( p_libvlc, "PID is %d, writing it to %s", i_pid, psz_pidfile ); - pidfile = utf8_fopen( psz_pidfile,"w" ); + pidfile = vlc_fopen( psz_pidfile,"w" ); if( pidfile != NULL ) { utf8_fprintf( pidfile, "%d", (int)i_pid ); @@ -427,13 +425,9 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, #if defined( ENABLE_NLS ) \ && ( defined( HAVE_GETTEXT ) || defined( HAVE_INCLUDED_GETTEXT ) ) # if defined (WIN32) || defined (__APPLE__) - /* This ain't really nice to have to reload the config here but it seems - * the only way to do it. */ - - if( !config_GetInt( p_libvlc, "ignore-config" ) ) + if( !var_InheritBool( p_libvlc, "ignore-config" ) ) config_LoadConfigFile( p_libvlc, "main" ); - config_LoadCmdLine( p_libvlc, &i_argc, ppsz_argv, true ); - priv->i_verbose = config_GetInt( p_libvlc, "verbose" ); + priv->i_verbose = var_InheritInteger( p_libvlc, "verbose" ); /* Check if the user specified a custom language */ psz_language = var_CreateGetNonEmptyString( p_libvlc, "language" ); @@ -444,13 +438,6 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, /* Translate "C" to the language code: "fr", "en_GB", "nl", "ru"... */ msg_Dbg( p_libvlc, "translation test: code is \"%s\"", _("C") ); - - module_EndBank( p_libvlc, false ); - module_InitBank( p_libvlc ); - if( !config_GetInt( p_libvlc, "ignore-config" ) ) - config_LoadConfigFile( p_libvlc, "main" ); - config_LoadCmdLine( p_libvlc, &i_argc, ppsz_argv, true ); - priv->i_verbose = config_GetInt( p_libvlc, "verbose" ); } free( psz_language ); # endif @@ -462,7 +449,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, * list of configuration options exported by each module and loads their * default values. */ - module_LoadPlugins( p_libvlc, b_cache_delete ); + module_LoadPlugins( p_libvlc ); if( p_libvlc->b_die ) { b_exit = true; @@ -474,7 +461,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, msg_Dbg( p_libvlc, "module bank initialized (%zu modules)", module_count ); /* Check for help on modules */ - if( (p_tmp = var_CreateGetNonEmptyString( p_libvlc, "module" )) ) + if( (p_tmp = var_InheritString( p_libvlc, "module" )) ) { Help( p_libvlc, p_tmp ); free( p_tmp ); @@ -482,29 +469,31 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, i_ret = VLC_EEXITSUCCESS; } /* Check for full help option */ - else if( config_GetInt( p_libvlc, "full-help" ) > 0 ) + else if( var_InheritBool( p_libvlc, "full-help" ) ) { - config_PutInt( p_libvlc, "advanced", 1); - config_PutInt( p_libvlc, "help-verbose", 1); + var_Create( p_libvlc, "advanced", VLC_VAR_BOOL ); + var_SetBool( p_libvlc, "advanced", true ); + var_Create( p_libvlc, "help-verbose", VLC_VAR_BOOL ); + var_SetBool( p_libvlc, "help-verbose", true ); Help( p_libvlc, "full-help" ); b_exit = true; i_ret = VLC_EEXITSUCCESS; } /* Check for long help option */ - else if( config_GetInt( p_libvlc, "longhelp" ) > 0 ) + else if( var_InheritBool( p_libvlc, "longhelp" ) ) { Help( p_libvlc, "longhelp" ); b_exit = true; i_ret = VLC_EEXITSUCCESS; } /* Check for module list option */ - else if( config_GetInt( p_libvlc, "list" ) > 0 ) + else if( var_InheritBool( p_libvlc, "list" ) ) { ListModules( p_libvlc, false ); b_exit = true; i_ret = VLC_EEXITSUCCESS; } - else if( config_GetInt( p_libvlc, "list-verbose" ) > 0 ) + else if( var_InheritBool( p_libvlc, "list-verbose" ) ) { ListModules( p_libvlc, true ); b_exit = true; @@ -512,18 +501,11 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, } /* Check for config file options */ - if( !config_GetInt( p_libvlc, "ignore-config" ) ) + if( !var_InheritBool( p_libvlc, "ignore-config" ) ) { - if( config_GetInt( p_libvlc, "reset-config" ) > 0 ) + if( var_InheritBool( p_libvlc, "reset-config" ) ) { config_ResetAll( p_libvlc ); - config_LoadCmdLine( p_libvlc, &i_argc, ppsz_argv, true ); - config_SaveConfigFile( p_libvlc, NULL ); - } - if( config_GetInt( p_libvlc, "save-config" ) > 0 ) - { - config_LoadConfigFile( p_libvlc, NULL ); - config_LoadCmdLine( p_libvlc, &i_argc, ppsz_argv, true ); config_SaveConfigFile( p_libvlc, NULL ); } } @@ -545,7 +527,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, /* * Override default configuration with config file settings */ - if( !config_GetInt( p_libvlc, "ignore-config" ) ) + if( !var_InheritBool( p_libvlc, "ignore-config" ) ) config_LoadConfigFile( p_libvlc, NULL ); /* @@ -563,7 +545,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, module_EndBank( p_libvlc, true ); return VLC_EGENERIC; } - priv->i_verbose = config_GetInt( p_libvlc, "verbose" ); + priv->i_verbose = var_InheritInteger( p_libvlc, "verbose" ); /* * System specific configuration @@ -574,9 +556,9 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, #ifdef HAVE_DBUS dbus_threads_init_default(); - if( config_GetInt( p_libvlc, "one-instance" ) > 0 - || ( config_GetInt( p_libvlc, "one-instance-when-started-from-file" ) - && config_GetInt( p_libvlc, "started-from-file" ) ) ) + if( var_InheritBool( p_libvlc, "one-instance" ) + || ( var_InheritBool( p_libvlc, "one-instance-when-started-from-file" ) + && var_InheritBool( p_libvlc, "started-from-file" ) ) ) { /* Initialise D-Bus interface, check for other instances */ DBusConnection *p_conn = NULL; @@ -649,7 +631,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, exit( 1 ); } b_play = TRUE; - if( config_GetInt( p_libvlc, "playlist-enqueue" ) > 0 ) + if( var_InheritBool( p_libvlc, "playlist-enqueue" ) ) b_play = FALSE; if ( !dbus_message_iter_append_basic( &dbus_args, DBUS_TYPE_BOOLEAN, &b_play ) ) @@ -723,7 +705,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, /* Last chance to set the verbosity. Once we start interfaces and other * threads, verbosity becomes read-only. */ var_Create( p_libvlc, "verbose", VLC_VAR_INTEGER | VLC_VAR_DOINHERIT ); - if( config_GetInt( p_libvlc, "quiet" ) > 0 ) + if( var_InheritBool( p_libvlc, "quiet" ) ) { var_SetInteger( p_libvlc, "verbose", -1 ); priv->i_verbose = -1; @@ -731,7 +713,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, vlc_threads_setup( p_libvlc ); if( priv->b_color ) - priv->b_color = config_GetInt( p_libvlc, "color" ) > 0; + priv->b_color = var_InheritBool( p_libvlc, "color" ); char p_capabilities[200]; #define PRINT_CAPABILITY( capability, string ) \ @@ -744,23 +726,23 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, p_capabilities[0] = '\0'; #if defined( __i386__ ) || defined( __x86_64__ ) - if( !config_GetInt( p_libvlc, "mmx" ) ) + if( !var_InheritBool( p_libvlc, "mmx" ) ) cpu_flags &= ~CPU_CAPABILITY_MMX; - if( !config_GetInt( p_libvlc, "3dn" ) ) + if( !var_InheritBool( p_libvlc, "3dn" ) ) cpu_flags &= ~CPU_CAPABILITY_3DNOW; - if( !config_GetInt( p_libvlc, "mmxext" ) ) + if( !var_InheritBool( p_libvlc, "mmxext" ) ) cpu_flags &= ~CPU_CAPABILITY_MMXEXT; - if( !config_GetInt( p_libvlc, "sse" ) ) + if( !var_InheritBool( p_libvlc, "sse" ) ) cpu_flags &= ~CPU_CAPABILITY_SSE; - if( !config_GetInt( p_libvlc, "sse2" ) ) + if( !var_InheritBool( p_libvlc, "sse2" ) ) cpu_flags &= ~CPU_CAPABILITY_SSE2; - if( !config_GetInt( p_libvlc, "sse3" ) ) + if( !var_InheritBool( p_libvlc, "sse3" ) ) cpu_flags &= ~CPU_CAPABILITY_SSE3; - if( !config_GetInt( p_libvlc, "ssse3" ) ) + if( !var_InheritBool( p_libvlc, "ssse3" ) ) cpu_flags &= ~CPU_CAPABILITY_SSSE3; - if( !config_GetInt( p_libvlc, "sse41" ) ) + if( !var_InheritBool( p_libvlc, "sse41" ) ) cpu_flags &= ~CPU_CAPABILITY_SSE4_1; - if( !config_GetInt( p_libvlc, "sse42" ) ) + if( !var_InheritBool( p_libvlc, "sse42" ) ) cpu_flags &= ~CPU_CAPABILITY_SSE4_2; PRINT_CAPABILITY( CPU_CAPABILITY_MMX, "MMX" ); @@ -775,7 +757,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, PRINT_CAPABILITY( CPU_CAPABILITY_SSE4A, "SSE4A" ); #elif defined( __powerpc__ ) || defined( __ppc__ ) || defined( __ppc64__ ) - if( !config_GetInt( p_libvlc, "altivec" ) ) + if( !var_InheritBool( p_libvlc, "altivec" ) ) cpu_flags &= ~CPU_CAPABILITY_ALTIVEC; PRINT_CAPABILITY( CPU_CAPABILITY_ALTIVEC, "AltiVec" ); @@ -791,7 +773,8 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, p_capabilities[sizeof(p_capabilities) - 1] = '\0'; #endif - msg_Dbg( p_libvlc, "CPU has capabilities %s", p_capabilities ); + if (p_capabilities[0]) + msg_Dbg( p_libvlc, "CPU has capabilities %s", p_capabilities ); /* * Choose the best memcpy module @@ -800,7 +783,7 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, /* Avoid being called "memcpy":*/ vlc_object_set_name( p_libvlc, "main" ); - priv->b_stats = config_GetInt( p_libvlc, "stats" ) > 0; + priv->b_stats = var_InheritBool( p_libvlc, "stats" ); priv->i_timers = 0; priv->pp_timers = NULL; @@ -827,18 +810,16 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, module_EndBank( p_libvlc, true ); return VLC_EGENERIC; } - playlist_Activate( p_playlist ); - vlc_object_attach( p_playlist, p_libvlc ); /* Add service discovery modules */ - psz_modules = var_CreateGetNonEmptyString( p_playlist, "services-discovery" ); + psz_modules = var_InheritString( p_libvlc, "services-discovery" ); if( psz_modules ) { char *p = psz_modules, *m; while( ( m = strsep( &p, " :," ) ) != NULL ) playlist_ServicesDiscoveryAdd( p_playlist, m ); + free( psz_modules ); } - free( psz_modules ); #ifdef ENABLE_VLM /* Initialize VLM if vlm-conf is specified */ @@ -906,26 +887,26 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, #ifdef HAVE_DBUS /* loads dbus control interface if in one-instance mode * we do it only when playlist exists, because dbus module needs it */ - if( config_GetInt( p_libvlc, "one-instance" ) > 0 - || ( config_GetInt( p_libvlc, "one-instance-when-started-from-file" ) - && config_GetInt( p_libvlc, "started-from-file" ) ) ) + if( var_InheritBool( p_libvlc, "one-instance" ) + || ( var_InheritBool( p_libvlc, "one-instance-when-started-from-file" ) + && var_InheritBool( p_libvlc, "started-from-file" ) ) ) intf_Create( p_libvlc, "dbus,none" ); # if !defined (HAVE_MAEMO) /* Prevents the power management daemon from suspending the system * when VLC is active */ - if( config_GetInt( p_libvlc, "inhibit" ) > 0 ) + if( var_InheritBool( p_libvlc, "inhibit" ) > 0 ) intf_Create( p_libvlc, "inhibit,none" ); # endif #endif - if( (config_GetInt( p_libvlc, "file-logging" ) > 0) && - !config_GetInt( p_libvlc, "syslog" ) ) + if( var_InheritBool( p_libvlc, "file-logging" ) && + !var_InheritBool( p_libvlc, "syslog" ) ) { intf_Create( p_libvlc, "logger,none" ); } #ifdef HAVE_SYSLOG_H - if( config_GetInt( p_libvlc, "syslog" ) > 0 ) + if( var_InheritBool( p_libvlc, "syslog" ) ) { char *logmode = var_CreateGetNonEmptyString( p_libvlc, "logmode" ); var_SetString( p_libvlc, "logmode", "syslog" ); @@ -940,15 +921,15 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, } #endif - if( config_GetInt( p_libvlc, "network-synchronisation") > 0 ) + if( var_InheritBool( p_libvlc, "network-synchronisation") ) { intf_Create( p_libvlc, "netsync,none" ); } #ifdef WIN32 - if( config_GetInt( p_libvlc, "prefer-system-codecs") > 0 ) + if( var_InheritBool( p_libvlc, "prefer-system-codecs") ) { - char *psz_codecs = var_CreateGetNonEmptyString( p_playlist, "codec" ); + char *psz_codecs = var_CreateGetNonEmptyString( p_libvlc, "codec" ); if( psz_codecs ) { char *psz_morecodecs; @@ -989,15 +970,13 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, /* * Get --open argument */ - psz_val = var_CreateGetNonEmptyString( p_libvlc, "open" ); + psz_val = var_InheritString( p_libvlc, "open" ); if ( psz_val != NULL ) { - playlist_t *p_playlist = pl_Hold( p_libvlc ); playlist_AddExt( p_playlist, psz_val, NULL, PLAYLIST_INSERT, 0, -1, 0, NULL, 0, true, pl_Unlocked ); - pl_Release( p_libvlc ); + free( psz_val ); } - free( psz_val ); return VLC_SUCCESS; } @@ -1009,11 +988,11 @@ int libvlc_InternalInit( libvlc_int_t *p_libvlc, int i_argc, void libvlc_InternalCleanup( libvlc_int_t *p_libvlc ) { libvlc_priv_t *priv = libvlc_priv (p_libvlc); - playlist_t *p_playlist = priv->p_playlist; + playlist_t *p_playlist = libvlc_priv (p_libvlc)->p_playlist; /* Deactivate the playlist */ msg_Dbg( p_libvlc, "deactivating the playlist" ); - playlist_Deactivate( p_playlist ); + pl_Deactivate( p_libvlc ); /* Remove all services discovery */ msg_Dbg( p_libvlc, "removing all services discovery tasks" ); @@ -1032,14 +1011,8 @@ void libvlc_InternalCleanup( libvlc_int_t *p_libvlc ) } #endif - /* Free playlist */ - /* Any thread still running must not assume pl_Hold() succeeds. */ - msg_Dbg( p_libvlc, "removing playlist" ); - - libvlc_priv(p_libvlc)->p_playlist = NULL; - barrier(); /* FIXME is that correct ? */ - - vlc_object_release( p_playlist ); + /* Free playlist now, all threads are gone */ + playlist_Destroy( p_playlist ); stats_TimersDumpAll( p_libvlc ); stats_TimersCleanAll( p_libvlc ); @@ -1098,7 +1071,7 @@ void libvlc_InternalDestroy( libvlc_int_t *p_libvlc ) } vlc_mutex_unlock( &global_lock ); - msg_Destroy( p_libvlc ); + msg_Destroy (priv->msg_bank); /* Destroy mutexes */ vlc_mutex_destroy( &priv->timer_lock ); @@ -1214,50 +1187,6 @@ static void SetLanguage ( const char *psz_lang ) } #endif - -static inline int LoadMessages (void) -{ -#if defined( ENABLE_NLS ) \ - && ( defined( HAVE_GETTEXT ) || defined( HAVE_INCLUDED_GETTEXT ) ) - /* Specify where to find the locales for current domain */ -#if !defined( __APPLE__ ) && !defined( WIN32 ) && !defined( SYS_BEOS ) - static const char psz_path[] = LOCALEDIR; -#else - char psz_path[1024]; - if (snprintf (psz_path, sizeof (psz_path), "%s" DIR_SEP "%s", - config_GetDataDirDefault(), "locale") - >= (int)sizeof (psz_path)) - return -1; - -#endif - if (bindtextdomain (PACKAGE_NAME, psz_path) == NULL) - { - fprintf (stderr, "Warning: cannot bind text domain "PACKAGE_NAME - " to directory %s\n", psz_path); - return -1; - } - - /* LibVLC wants all messages in UTF-8. - * Unfortunately, we cannot ask UTF-8 for strerror_r(), strsignal_r() - * and other functions that are not part of our text domain. - */ - if (bind_textdomain_codeset (PACKAGE_NAME, "UTF-8") == NULL) - { - fprintf (stderr, "Error: cannot set Unicode encoding for text domain " - PACKAGE_NAME"\n"); - // Unbinds the text domain to avoid broken encoding - bindtextdomain (PACKAGE_NAME, "DOES_NOT_EXIST"); - return -1; - } - - /* LibVLC does NOT set the default textdomain, since it is a library. - * This could otherwise break programs using LibVLC (other than VLC). - * textdomain (PACKAGE_NAME); - */ -#endif - return 0; -} - /***************************************************************************** * GetFilenames: parse command line options which are not flags ***************************************************************************** @@ -1287,11 +1216,9 @@ static int GetFilenames( libvlc_int_t *p_vlc, int i_argc, const char *ppsz_argv[ if( !mrl ) continue; - playlist_t *p_playlist = pl_Hold( p_vlc ); - playlist_AddExt( p_playlist, mrl, NULL, PLAYLIST_INSERT, + playlist_AddExt( pl_Get( p_vlc ), mrl, NULL, PLAYLIST_INSERT, 0, -1, i_options, ( i_options ? &ppsz_argv[i_opt + 1] : NULL ), VLC_INPUT_OPTION_TRUSTED, true, pl_Unlocked ); - pl_Release( p_vlc ); free( mrl ); } @@ -1389,21 +1316,26 @@ static void Help( libvlc_int_t *p_this, char const *psz_help_name ) # define CYAN COL(36) # define WHITE COL(0) # define GRAY "\033[0m" -static void print_help_section( module_config_t *p_item, bool b_color, bool b_description ) +static void +print_help_section( const module_t *m, const module_config_t *p_item, + bool b_color, bool b_description ) { if( !p_item ) return; if( b_color ) { - utf8_fprintf( stdout, RED" %s:\n"GRAY, _( p_item->psz_text ) ); - if( b_description && p_item->psz_longtext ) + utf8_fprintf( stdout, RED" %s:\n"GRAY, + module_gettext( m, p_item->psz_text ) ); + if( b_description && p_item->psz_longtext && *p_item->psz_longtext ) utf8_fprintf( stdout, MAGENTA" %s\n"GRAY, - _( p_item->psz_longtext ) ); + module_gettext( m, p_item->psz_longtext ) ); } else { - utf8_fprintf( stdout, " %s:\n", _( p_item->psz_text ) ); - if( b_description && p_item->psz_longtext ) - utf8_fprintf( stdout, " %s\n", _( p_item->psz_longtext ) ); + utf8_fprintf( stdout, " %s:\n", + module_gettext( m, p_item->psz_text ) ); + if( b_description && p_item->psz_longtext && *p_item->psz_longtext ) + utf8_fprintf( stdout, " %s\n", + module_gettext(m, p_item->psz_longtext ) ); } } @@ -1440,10 +1372,10 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) char psz_short[4]; int i_width = ConsoleWidth() - (PADDING_SPACES+LINE_START+1); int i_width_description = i_width + PADDING_SPACES - 1; - bool b_advanced = config_GetInt( p_this, "advanced" ) > 0; - bool b_description = config_GetInt( p_this, "help-verbose" ) > 0; + bool b_advanced = var_InheritBool( p_this, "advanced" ); + bool b_description = var_InheritBool( p_this, "help-verbose" ); bool b_description_hack; - bool b_color = config_GetInt( p_this, "color" ) > 0; + bool b_color = var_InheritBool( p_this, "color" ); bool b_has_advanced = false; bool b_found = false; int i_only_advanced = 0; /* Number of modules ignored because they @@ -1543,18 +1475,20 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) { if( b_color ) utf8_fprintf( stdout, "\n " GREEN "%s" GRAY " (%s)\n", - _( p_parser->psz_longname ), + module_gettext( p_parser, p_parser->psz_longname ), p_parser->psz_object_name ); else - utf8_fprintf( stdout, "\n %s\n", _( p_parser->psz_longname ) ); + utf8_fprintf( stdout, "\n %s\n", + module_gettext(p_parser, p_parser->psz_longname ) ); } if( p_parser->psz_help ) { if( b_color ) utf8_fprintf( stdout, CYAN" %s\n"GRAY, - _( p_parser->psz_help ) ); + module_gettext( p_parser, p_parser->psz_help ) ); else - utf8_fprintf( stdout, " %s\n", _( p_parser->psz_help ) ); + utf8_fprintf( stdout, " %s\n", + module_gettext( p_parser, p_parser->psz_help ) ); } /* Print module options */ @@ -1588,19 +1522,20 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) { if( b_color ) utf8_fprintf( stdout, GREEN "\n %s\n" GRAY, - _( p_item->psz_text ) ); + module_gettext( p_parser, p_item->psz_text ) ); else utf8_fprintf( stdout, "\n %s\n", - _( p_item->psz_text ) ); + module_gettext( p_parser, p_item->psz_text ) ); } - if( b_description && p_item->psz_longtext ) + if( b_description && p_item->psz_longtext + && *p_item->psz_longtext ) { if( b_color ) utf8_fprintf( stdout, CYAN " %s\n" GRAY, - _( p_item->psz_longtext ) ); + module_gettext( p_parser, p_item->psz_longtext ) ); else utf8_fprintf( stdout, " %s\n", - _( p_item->psz_longtext ) ); + module_gettext( p_parser, p_item->psz_longtext ) ); } break; @@ -1620,7 +1555,8 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) case CONFIG_ITEM_MODULE_LIST_CAT: case CONFIG_ITEM_FONT: case CONFIG_ITEM_PASSWORD: - print_help_section( p_section, b_color, b_description ); + print_help_section( p_parser, p_section, b_color, + b_description ); p_section = NULL; psz_bra = OPTION_VALUE_SEP "<"; psz_type = _("string"); @@ -1641,7 +1577,8 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) break; case CONFIG_ITEM_INTEGER: case CONFIG_ITEM_KEY: /* FIXME: do something a bit more clever */ - print_help_section( p_section, b_color, b_description ); + print_help_section( p_parser, p_section, b_color, + b_description ); p_section = NULL; psz_bra = OPTION_VALUE_SEP "<"; psz_type = _("integer"); @@ -1664,13 +1601,14 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) if( i ) strcat( psz_buffer, ", " ); sprintf( psz_buffer + strlen(psz_buffer), "%i (%s)", p_item->pi_list[i], - _( p_item->ppsz_list_text[i] ) ); + module_gettext( p_parser, p_item->ppsz_list_text[i] ) ); } psz_ket = "}"; } break; case CONFIG_ITEM_FLOAT: - print_help_section( p_section, b_color, b_description ); + print_help_section( p_parser, p_section, b_color, + b_description ); p_section = NULL; psz_bra = OPTION_VALUE_SEP "<"; psz_type = _("float"); @@ -1683,7 +1621,8 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) } break; case CONFIG_ITEM_BOOL: - print_help_section( p_section, b_color, b_description ); + print_help_section( p_parser, p_section, b_color, + b_description ); p_section = NULL; psz_bra = ""; psz_type = ""; psz_ket = ""; if( !b_help_module ) @@ -1744,7 +1683,7 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) psz_spaces[i] = ' '; /* We wrap the rest of the output */ - sprintf( psz_buffer, "%s%s", _( p_item->psz_text ), + sprintf( psz_buffer, "%s%s", module_gettext( p_parser, p_item->psz_text ), psz_suf ); b_description_hack = b_description; @@ -1835,9 +1774,11 @@ static void Usage( libvlc_int_t *p_this, char const *psz_search ) } } - if( b_description_hack && p_item->psz_longtext ) + if( b_description_hack && p_item->psz_longtext + && *p_item->psz_longtext ) { - sprintf( psz_buffer, "%s%s", _( p_item->psz_longtext ), + sprintf( psz_buffer, "%s%s", + module_gettext( p_parser, p_item->psz_longtext ), psz_suf ); b_description_hack = false; psz_spaces = psz_spaces_longtext; @@ -1896,7 +1837,7 @@ static void ListModules( libvlc_int_t *p_this, bool b_verbose ) { module_t *p_parser; - bool b_color = config_GetInt( p_this, "color" ) > 0; + bool b_color = var_InheritBool( p_this, "color" ); #ifdef WIN32 ShowConsole( true ); @@ -1915,11 +1856,11 @@ static void ListModules( libvlc_int_t *p_this, bool b_verbose ) if( b_color ) utf8_fprintf( stdout, GREEN" %-22s "WHITE"%s\n"GRAY, p_parser->psz_object_name, - _( p_parser->psz_longname ) ); + module_gettext( p_parser, p_parser->psz_longname ) ); else utf8_fprintf( stdout, " %-22s %s\n", p_parser->psz_object_name, - _( p_parser->psz_longname ) ); + module_gettext( p_parser, p_parser->psz_longname ) ); if( b_verbose ) { @@ -1971,8 +1912,8 @@ static void Version( void ) utf8_fprintf( stdout, _("VLC version %s (%s)\n"), VLC_Version(), psz_vlc_changeset ); - utf8_fprintf( stdout, _("Compiled by %s@%s.%s\n"), - VLC_CompileBy(), VLC_CompileHost(), VLC_CompileDomain() ); + utf8_fprintf( stdout, _("Compiled by %s on %s (%s)\n"), + VLC_CompileBy(), VLC_CompileHost(), __DATE__" "__TIME__ ); utf8_fprintf( stdout, _("Compiler: %s\n"), VLC_Compiler() ); utf8_fprintf( stdout, "%s", LICENSE_MSG );