X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fmisc%2Fmodules.c;h=b3ea3b55106f5d127190c363e7768cb78501ad91;hb=06a3889008d908f8505e4c5548605ad7ebf53430;hp=de9d60e9b61016879fcf8fd6f8a1a52ccbb247db;hpb=53dee7b961b237b3864fd9bb1206d69902156727;p=vlc diff --git a/src/misc/modules.c b/src/misc/modules.c index de9d60e9b6..b3ea3b5510 100644 --- a/src/misc/modules.c +++ b/src/misc/modules.c @@ -1,7 +1,7 @@ /***************************************************************************** * modules.c : Builtin and plugin modules management functions ***************************************************************************** - * Copyright (C) 2001-2004 VideoLAN + * Copyright (C) 2001-2004 the VideoLAN team * $Id$ * * Authors: Sam Hocevar @@ -39,10 +39,6 @@ #ifdef HAVE_DIRENT_H # include -#elif defined( UNDER_CE ) -# include /* GetFileAttributes() */ -#else -# include "../extras/dirent.h" #endif #ifdef HAVE_SYS_TYPES_H @@ -55,8 +51,9 @@ # include #endif -#define HAVE_DYNAMIC_PLUGINS -#if defined(HAVE_DL_DYLD) +#if !defined(HAVE_DYNAMIC_PLUGINS) + /* no support for plugins */ +#elif defined(HAVE_DL_DYLD) # if defined(HAVE_MACH_O_DYLD_H) # include # endif @@ -77,8 +74,6 @@ # if defined(HAVE_DL_H) # include # endif -#else -# undef HAVE_DYNAMIC_PLUGINS #endif #include "vlc_error.h" @@ -97,8 +92,11 @@ #include "aout_internal.h" #include "stream_output.h" -#include "osd.h" #include "vlc_httpd.h" +#include "vlc_acl.h" +#include "vlc_tls.h" +#include "vlc_md5.h" +#include "vlc_xml.h" #include "iso_lang.h" #include "charset.h" @@ -107,11 +105,10 @@ #include "vlc_vlm.h" -#ifdef HAVE_DYNAMIC_PLUGINS -# include "modules_plugin.h" -#endif +#include "vlc_image.h" +#include "vlc_osd.h" -#if defined( UNDER_CE ) +#if defined( _MSC_VER ) && defined( UNDER_CE ) # include "modules_builtin_evc.h" #elif defined( _MSC_VER ) # include "modules_builtin_msvc.h" @@ -120,9 +117,9 @@ #endif #include "network.h" -#if defined( WIN32) || defined( UNDER_CE ) +#if defined( WIN32 ) || defined( UNDER_CE ) /* Avoid name collisions */ -# define LoadModule(a,b,c) _LoadModule(a,b,c) +# define LoadModule(a,b,c) LoadVlcModule(a,b,c) #endif /***************************************************************************** @@ -147,6 +144,7 @@ static void CacheLoad ( vlc_object_t * ); static int CacheLoadConfig ( module_t *, FILE * ); static void CacheSave ( vlc_object_t * ); static void CacheSaveConfig ( module_t *, FILE * ); +static char * CacheName ( void ); static void CacheMerge ( vlc_object_t *, module_t *, module_t * ); static module_cache_t * CacheFind( vlc_object_t *, char *, int64_t, int64_t ); @@ -155,6 +153,11 @@ static char * GetWindowsError ( void ); #endif #endif + +/* Sub-version number + * (only used to avoid breakage in dev version when cache structure changes) */ +#define CACHE_SUBVERSION_NUM 1 + /***************************************************************************** * module_InitBank: create the module bank. ***************************************************************************** @@ -190,7 +193,7 @@ void __module_InitBank( vlc_object_t *p_this ) /* * Store the symbols to be exported */ -#ifdef HAVE_DYNAMIC_PLUGINS +#if defined (HAVE_DYNAMIC_PLUGINS) && !defined (HAVE_SHARED_LIBVLC) STORE_SYMBOLS( &p_bank->symbols ); #endif @@ -244,6 +247,8 @@ void __module_EndBank( vlc_object_t *p_this ) vlc_mutex_unlock( lockval.p_address ); var_Destroy( p_this->p_libvlc, "libvlc" ); + config_AutoSaveConfigFile( p_this ); + #ifdef HAVE_DYNAMIC_PLUGINS #define p_bank p_this->p_libvlc->p_module_bank if( p_bank->b_cache ) CacheSave( p_this ); @@ -251,14 +256,17 @@ void __module_EndBank( vlc_object_t *p_this ) { free( p_bank->pp_loaded_cache[p_bank->i_loaded_cache]->psz_file ); free( p_bank->pp_loaded_cache[p_bank->i_loaded_cache] ); - if( !p_bank->i_loaded_cache ) free( p_bank->pp_loaded_cache ); } + if( p_bank->pp_loaded_cache ) + free( p_bank->pp_loaded_cache ); + while( p_bank->i_cache-- ) { free( p_bank->pp_cache[p_bank->i_cache]->psz_file ); free( p_bank->pp_cache[p_bank->i_cache] ); - if( !p_bank->i_cache ) free( p_bank->pp_cache ); } + if( p_bank->pp_cache ) + free( p_bank->pp_cache ); #undef p_bank #endif @@ -281,6 +289,7 @@ void __module_EndBank( vlc_object_t *p_this ) } vlc_object_destroy( p_this->p_libvlc->p_module_bank ); + p_this->p_libvlc->p_module_bank = NULL; return; } @@ -295,6 +304,21 @@ void __module_EndBank( vlc_object_t *p_this ) *****************************************************************************/ void __module_LoadMain( vlc_object_t *p_this ) { + vlc_value_t lockval; + + var_Create( p_this->p_libvlc, "libvlc", VLC_VAR_MUTEX ); + var_Get( p_this->p_libvlc, "libvlc", &lockval ); + vlc_mutex_lock( lockval.p_address ); + if( p_this->p_libvlc->p_module_bank->b_main ) + { + vlc_mutex_unlock( lockval.p_address ); + var_Destroy( p_this->p_libvlc, "libvlc" ); + return; + } + p_this->p_libvlc->p_module_bank->b_main = VLC_TRUE; + vlc_mutex_unlock( lockval.p_address ); + var_Destroy( p_this->p_libvlc, "libvlc" ); + AllocateBuiltinModule( p_this, vlc_entry__main ); } @@ -305,6 +329,21 @@ void __module_LoadMain( vlc_object_t *p_this ) *****************************************************************************/ void __module_LoadBuiltins( vlc_object_t * p_this ) { + vlc_value_t lockval; + + var_Create( p_this->p_libvlc, "libvlc", VLC_VAR_MUTEX ); + var_Get( p_this->p_libvlc, "libvlc", &lockval ); + vlc_mutex_lock( lockval.p_address ); + if( p_this->p_libvlc->p_module_bank->b_builtins ) + { + vlc_mutex_unlock( lockval.p_address ); + var_Destroy( p_this->p_libvlc, "libvlc" ); + return; + } + p_this->p_libvlc->p_module_bank->b_builtins = VLC_TRUE; + vlc_mutex_unlock( lockval.p_address ); + var_Destroy( p_this->p_libvlc, "libvlc" ); + msg_Dbg( p_this, "checking builtin modules" ); ALLOCATE_ALL_BUILTINS(); } @@ -317,6 +356,21 @@ void __module_LoadBuiltins( vlc_object_t * p_this ) void __module_LoadPlugins( vlc_object_t * p_this ) { #ifdef HAVE_DYNAMIC_PLUGINS + vlc_value_t lockval; + + var_Create( p_this->p_libvlc, "libvlc", VLC_VAR_MUTEX ); + var_Get( p_this->p_libvlc, "libvlc", &lockval ); + vlc_mutex_lock( lockval.p_address ); + if( p_this->p_libvlc->p_module_bank->b_plugins ) + { + vlc_mutex_unlock( lockval.p_address ); + var_Destroy( p_this->p_libvlc, "libvlc" ); + return; + } + p_this->p_libvlc->p_module_bank->b_plugins = VLC_TRUE; + vlc_mutex_unlock( lockval.p_address ); + var_Destroy( p_this->p_libvlc, "libvlc" ); + msg_Dbg( p_this, "checking plugin modules" ); if( config_GetInt( p_this, "plugins-cache" ) ) @@ -357,8 +411,8 @@ module_t * __module_Need( vlc_object_t *p_this, const char *psz_capability, int i_shortcuts = 0; char *psz_shortcuts = NULL, *psz_var = NULL; + vlc_bool_t b_force_backup = p_this->b_force; - msg_Dbg( p_this, "looking for %s module", psz_capability ); /* Deal with variables */ if( psz_name && psz_name[0] == '$' ) @@ -498,6 +552,7 @@ module_t * __module_Need( vlc_object_t *p_this, const char *psz_capability, /* Special case: test if we requested a particular intf plugin */ if( !i_shortcuts && p_module->psz_program + && !strcmp( psz_capability, "interface" ) && !strcmp( p_module->psz_program, p_this->p_vlc->psz_object_name ) ) { @@ -553,8 +608,8 @@ module_t * __module_Need( vlc_object_t *p_this, const char *psz_capability, i_index++; } - msg_Dbg( p_this, "probing %i candidate%s", - i_index, i_index == 1 ? "" : "s" ); + msg_Dbg( p_this, "looking for %s module: %i candidate%s", psz_capability, + i_index, i_index == 1 ? "" : "s" ); /* Lock all candidate modules */ p_tmp = p_first; @@ -618,7 +673,7 @@ module_t * __module_Need( vlc_object_t *p_this, const char *psz_capability, } free( p_list ); - p_this->b_force = VLC_FALSE; + p_this->b_force = b_force_backup; if( p_module != NULL ) { @@ -690,14 +745,14 @@ void __module_Unneed( vlc_object_t * p_this, module_t * p_module ) static void AllocateAllPlugins( vlc_object_t *p_this ) { /* Yes, there are two NULLs because we replace one with "plugin-path". */ -#ifdef WIN32 - char * path[] = { "modules", "", "plugins", 0, 0 }; +#if defined( WIN32 ) || defined( UNDER_CE ) + char *path[] = { "modules", "", "plugins", 0, 0 }; #else - char * path[] = { "modules", PLUGIN_PATH, "plugins", 0, 0 }; + char *path[] = { "modules", PLUGIN_PATH, "plugins", 0, 0 }; #endif - char ** ppsz_path = path; - char * psz_fullpath; + char **ppsz_path = path; + char *psz_fullpath; /* If the user provided a plugin path, we add it to the list */ path[ sizeof(path)/sizeof(char*) - 2 ] = @@ -767,7 +822,7 @@ static void AllocatePluginDir( vlc_object_t *p_this, const char *psz_dir, char psz_path[MAX_PATH + 256]; WIN32_FIND_DATA finddata; HANDLE handle; - unsigned int rc; + int rc; #else int i_dirlen; DIR * dir; @@ -785,13 +840,13 @@ static void AllocatePluginDir( vlc_object_t *p_this, const char *psz_dir, MultiByteToWideChar( CP_ACP, 0, psz_dir, -1, psz_wdir, MAX_PATH ); rc = GetFileAttributes( psz_wdir ); - if( !(rc & FILE_ATTRIBUTE_DIRECTORY) ) return; /* Not a directory */ + if( rc<0 || !(rc&FILE_ATTRIBUTE_DIRECTORY) ) return; /* Not a directory */ /* Parse all files in the directory */ swprintf( psz_wpath, L"%ls\\*", psz_wdir ); #else rc = GetFileAttributes( psz_dir ); - if( !(rc & FILE_ATTRIBUTE_DIRECTORY) ) return; /* Not a directory */ + if( rc<0 || !(rc&FILE_ATTRIBUTE_DIRECTORY) ) return; /* Not a directory */ #endif /* Parse all files in the directory */ @@ -841,9 +896,27 @@ static void AllocatePluginDir( vlc_object_t *p_this, const char *psz_dir, - strlen( LIBEXT ), LIBEXT, strlen( LIBEXT ) ) ) { + WIN32_FILE_ATTRIBUTE_DATA attrbuf; + int64_t i_time = 0, i_size = 0; + +#ifdef UNDER_CE + if( GetFileAttributesEx( psz_wpath, GetFileExInfoStandard, + &attrbuf ) ) +#else + if( GetFileAttributesEx( psz_path, GetFileExInfoStandard, + &attrbuf ) ) +#endif + { + i_time = attrbuf.ftLastWriteTime.dwHighDateTime; + i_time <<= 32; + i_time |= attrbuf.ftLastWriteTime.dwLowDateTime; + i_size = attrbuf.nFileSizeHigh; + i_size <<= 32; + i_size |= attrbuf.nFileSizeLow; + } psz_file = psz_path; - AllocatePluginFile( p_this, psz_file, 0, 0 ); + AllocatePluginFile( p_this, psz_file, i_time, i_size ); } } while( !p_this->p_vlc->b_die && FindNextFile( handle, &finddata ) ); @@ -1016,7 +1089,9 @@ static module_t * AllocatePlugin( vlc_object_t * p_this, char * psz_file ) /* We need to fill these since they may be needed by CallEntry() */ p_module->psz_filename = psz_file; p_module->handle = handle; +#ifndef HAVE_SHARED_LIBVLC p_module->p_symbols = &p_this->p_libvlc->p_module_bank->symbols; +#endif p_module->b_loaded = VLC_TRUE; /* Initialize the module: fill p_module, default config */ @@ -1057,7 +1132,8 @@ static void DupModule( module_t *p_module ) * module is unloaded. */ p_module->psz_object_name = strdup( p_module->psz_object_name ); p_module->psz_capability = strdup( p_module->psz_capability ); - p_module->psz_shortname = strdup( p_module->psz_shortname ); + p_module->psz_shortname = p_module->psz_shortname ? + strdup( p_module->psz_shortname ) : NULL; p_module->psz_longname = strdup( p_module->psz_longname ); if( p_module->psz_program != NULL ) @@ -1093,7 +1169,7 @@ static void UndupModule( module_t *p_module ) free( p_module->psz_object_name ); free( p_module->psz_capability ); - free( p_module->psz_shortname ); + if( p_module->psz_shortname ) free( p_module->psz_shortname ); free( p_module->psz_longname ); if( p_module->psz_program != NULL ) @@ -1303,7 +1379,6 @@ static int LoadModule( vlc_object_t *p_this, char *psz_file, #elif defined(HAVE_DL_DLOPEN) && defined(RTLD_NOW) /* static is OK, we are called atomically */ - static vlc_bool_t b_kde = VLC_FALSE; # if defined(SYS_LINUX) /* XXX HACK #1 - we should NOT open modules with RTLD_GLOBAL, or we @@ -1320,18 +1395,6 @@ static int LoadModule( vlc_object_t *p_this, char *psz_file, } } # endif - /* XXX HACK #2 - the ugly KDE workaround. It seems that libkdewhatever - * causes dlopen() to segfault if libstdc++ is not loaded in the caller, - * so we just load libstdc++. Bwahahaha! ph34r! -- Sam. */ - /* Update: FYI, this is Debian bug #180505, and seems to be fixed. */ - if( !b_kde && !strstr( psz_file, "kde" ) ) - { - dlopen( "libstdc++.so.6", RTLD_NOW ) - || dlopen( "libstdc++.so.5", RTLD_NOW ) - || dlopen( "libstdc++.so.4", RTLD_NOW ) - || dlopen( "libstdc++.so.3", RTLD_NOW ); - b_kde = VLC_TRUE; - } handle = dlopen( psz_file, RTLD_NOW ); if( handle == NULL ) @@ -1472,23 +1535,19 @@ static void * _module_getsymbol( module_handle_t handle, static char * GetWindowsError( void ) { #if defined(UNDER_CE) - wchar_t psz_tmp[256]; - char * psz_buffer = malloc( 256 ); + wchar_t psz_tmp[MAX_PATH]; + char * psz_buffer = malloc( MAX_PATH ); #else - char * psz_tmp = malloc( 256 ); + char * psz_tmp = malloc( MAX_PATH ); #endif int i = 0, i_error = GetLastError(); FormatMessage( FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, NULL, i_error, MAKELANGID (LANG_NEUTRAL, SUBLANG_DEFAULT), - (LPTSTR) psz_tmp, 256, NULL ); + (LPTSTR)psz_tmp, MAX_PATH, NULL ); /* Go to the end of the string */ -#if defined(UNDER_CE) - while( psz_tmp[i] && psz_tmp[i] != L'\r' && psz_tmp[i] != L'\n' ) -#else - while( psz_tmp[i] && psz_tmp[i] != '\r' && psz_tmp[i] != '\n' ) -#endif + while( psz_tmp[i] && psz_tmp[i] != _T('\r') && psz_tmp[i] != _T('\n') ) { i++; } @@ -1505,8 +1564,7 @@ static char * GetWindowsError( void ) } #if defined(UNDER_CE) - WideCharToMultiByte( CP_ACP, WC_DEFAULTCHAR, psz_tmp, -1, - psz_buffer, 256, NULL, NULL ); + wcstombs( psz_buffer, psz_tmp, MAX_PATH ); return psz_buffer; #else return psz_tmp; @@ -1527,10 +1585,11 @@ static void CacheLoad( vlc_object_t *p_this ) char *psz_filename, *psz_homedir; FILE *file; int i, j, i_size, i_read; - char p_cachestring[sizeof(PLUGINSCACHE_FILE COPYRIGHT_MESSAGE)]; + char p_cachestring[sizeof(PLUGINSCACHE_DIR COPYRIGHT_MESSAGE)]; + char p_cachelang[6], p_lang[6]; int i_cache; module_cache_t **pp_cache = 0; - int32_t i_file_size; + int32_t i_file_size, i_marker; psz_homedir = p_this->p_vlc->psz_homedir; if( !psz_homedir ) @@ -1538,15 +1597,10 @@ static void CacheLoad( vlc_object_t *p_this ) msg_Err( p_this, "psz_homedir is null" ); return; } - psz_filename = - (char *)malloc( sizeof("/" CONFIG_DIR "/" PLUGINSCACHE_FILE) + - strlen(psz_homedir) ); - - if( psz_filename ) - sprintf( psz_filename, "%s/" CONFIG_DIR "/" PLUGINSCACHE_FILE, - psz_homedir ); - if( !psz_filename ) + i_size = asprintf( &psz_filename, "%s/%s/%s/%s", psz_homedir, CONFIG_DIR, + PLUGINSCACHE_DIR, CacheName() ); + if( i_size <= 0 ) { msg_Err( p_this, "out of memory" ); return; @@ -1554,12 +1608,15 @@ static void CacheLoad( vlc_object_t *p_this ) if( p_this->p_libvlc->p_module_bank->b_cache_delete ) { - msg_Dbg( p_this, "removing plugins cache file %s", psz_filename ); #if !defined( UNDER_CE ) unlink( psz_filename ); #else - msg_Err( p_this, "FIXME, unlink not implemented" ); + wchar_t psz_wf[MAX_PATH]; + MultiByteToWideChar( CP_ACP, 0, psz_filename, -1, psz_wf, MAX_PATH ); + DeleteFile( psz_wf ); #endif + msg_Dbg( p_this, "removing plugins cache file %s", psz_filename ); + free( psz_filename ); return; } @@ -1596,30 +1653,66 @@ static void CacheLoad( vlc_object_t *p_this ) fseek( file, sizeof(i_file_size), SEEK_SET ); /* Check the file is a plugins cache */ - i_size = sizeof(PLUGINSCACHE_FILE COPYRIGHT_MESSAGE) - 1; + i_size = sizeof(PLUGINSCACHE_DIR COPYRIGHT_MESSAGE) - 1; i_read = fread( p_cachestring, sizeof(char), i_size, file ); if( i_read != i_size || - memcmp( p_cachestring, PLUGINSCACHE_FILE COPYRIGHT_MESSAGE, i_size ) ) + memcmp( p_cachestring, PLUGINSCACHE_DIR COPYRIGHT_MESSAGE, i_size ) ) { msg_Warn( p_this, "This doesn't look like a valid plugins cache" ); fclose( file ); return; } + /* Check Sub-version number */ + i_read = fread( &i_marker, sizeof(char), sizeof(i_marker), file ); + if( i_read != sizeof(i_marker) || i_marker != CACHE_SUBVERSION_NUM ) + { + msg_Warn( p_this, "This doesn't look like a valid plugins cache " + "(corrupted header)" ); + fclose( file ); + return; + } + + /* Check the language hasn't changed */ + sprintf( p_lang, "%5.5s", _("C") ); i_size = 5; + i_read = fread( p_cachelang, sizeof(char), i_size, file ); + if( i_read != i_size || memcmp( p_cachelang, p_lang, i_size ) ) + { + msg_Warn( p_this, "This doesn't look like a valid plugins cache " + "(language changed)" ); + fclose( file ); + return; + } + + /* Check header marker */ + i_read = fread( &i_marker, sizeof(char), sizeof(i_marker), file ); + if( i_read != sizeof(i_marker) || + i_marker != ftell( file ) - (int)sizeof(i_marker) ) + { + msg_Warn( p_this, "This doesn't look like a valid plugins cache " + "(corrupted header)" ); + fclose( file ); + return; + } + p_this->p_libvlc->p_module_bank->i_loaded_cache = 0; fread( &i_cache, sizeof(char), sizeof(i_cache), file ); - pp_cache = p_this->p_libvlc->p_module_bank->pp_loaded_cache = - malloc( i_cache * sizeof(void *) ); + if( i_cache ) + pp_cache = p_this->p_libvlc->p_module_bank->pp_loaded_cache = + malloc( i_cache * sizeof(void *) ); #define LOAD_IMMEDIATE(a) \ if( fread( &a, sizeof(char), sizeof(a), file ) != sizeof(a) ) goto error #define LOAD_STRING(a) \ { if( fread( &i_size, sizeof(char), sizeof(i_size), file ) \ != sizeof(i_size) ) goto error; \ - if( i_size ) { \ + if( i_size && i_size < 16384 ) { \ a = malloc( i_size ); \ if( fread( a, sizeof(char), i_size, file ) != (size_t)i_size ) \ goto error; \ + if( a[i_size-1] ) { \ + free( a ); a = 0; \ + goto error; } \ } else a = 0; \ } while(0) @@ -1632,7 +1725,7 @@ static void CacheLoad( vlc_object_t *p_this ) pp_cache[i] = malloc( sizeof(module_cache_t) ); p_this->p_libvlc->p_module_bank->i_loaded_cache++; - /* Save common info */ + /* Load common info */ LOAD_STRING( pp_cache[i]->psz_file ); LOAD_IMMEDIATE( pp_cache[i]->i_time ); LOAD_IMMEDIATE( pp_cache[i]->i_size ); @@ -1642,7 +1735,7 @@ static void CacheLoad( vlc_object_t *p_this ) pp_cache[i]->p_module = vlc_object_create( p_this, VLC_OBJECT_MODULE ); - /* Save additional infos */ + /* Load additional infos */ LOAD_STRING( pp_cache[i]->p_module->psz_object_name ); LOAD_STRING( pp_cache[i]->p_module->psz_shortname ); LOAD_STRING( pp_cache[i]->p_module->psz_longname ); @@ -1731,6 +1824,7 @@ int CacheLoadConfig( module_t *p_module, FILE *file ) LOAD_STRING( p_module->p_config[i].psz_name ); LOAD_STRING( p_module->p_config[i].psz_text ); LOAD_STRING( p_module->p_config[i].psz_longtext ); + LOAD_STRING( p_module->p_config[i].psz_current ); LOAD_STRING( p_module->p_config[i].psz_value_orig ); p_module->p_config[i].psz_value = @@ -1738,6 +1832,10 @@ int CacheLoadConfig( module_t *p_module, FILE *file ) strdup( p_module->p_config[i].psz_value_orig ) : 0; p_module->p_config[i].i_value = p_module->p_config[i].i_value_orig; p_module->p_config[i].f_value = p_module->p_config[i].f_value_orig; + p_module->p_config[i].i_value_saved = p_module->p_config[i].i_value; + p_module->p_config[i].f_value_saved = p_module->p_config[i].f_value; + p_module->p_config[i].psz_value_saved = 0; + p_module->p_config[i].b_dirty = VLC_FALSE; p_module->p_config[i].p_lock = &p_module->object_lock; @@ -1808,6 +1906,12 @@ int CacheLoadConfig( module_t *p_module, FILE *file ) *****************************************************************************/ static void CacheSave( vlc_object_t *p_this ) { + static char const psz_tag[] = + "Signature: 8a477f597d28d172789f06886806bc55\r\n" + "# This file is a cache directory tag created by VLC.\r\n" + "# For information about cache directory tags, see:\r\n" + "# http://www.brynosaurus.com/cachedir/\r\n"; + char *psz_filename, *psz_homedir; FILE *file; int i, j, i_cache; @@ -1821,11 +1925,8 @@ static void CacheSave( vlc_object_t *p_this ) return; } psz_filename = - (char *)malloc( sizeof("/" CONFIG_DIR "/" PLUGINSCACHE_FILE) + - strlen(psz_homedir) ); - - if( psz_filename ) - sprintf( psz_filename, "%s/" CONFIG_DIR, psz_homedir ); + (char *)malloc( sizeof("/" CONFIG_DIR "/" PLUGINSCACHE_DIR "/" ) + + strlen(psz_homedir) + strlen(CacheName()) ); if( !psz_filename ) { @@ -1833,9 +1934,25 @@ static void CacheSave( vlc_object_t *p_this ) return; } + sprintf( psz_filename, "%s/%s", psz_homedir, CONFIG_DIR ); + + config_CreateDir( p_this, psz_filename ); + + strcat( psz_filename, "/" PLUGINSCACHE_DIR ); + config_CreateDir( p_this, psz_filename ); - strcat( psz_filename, "/" PLUGINSCACHE_FILE ); + strcat( psz_filename, "/CACHEDIR.TAG" ); + + file = fopen( psz_filename, "wb" ); + if( file ) + { + fwrite( psz_tag, 1, strlen(psz_tag), file ); + fclose( file ); + } + + sprintf( psz_filename, "%s/%s/%s/%s", psz_homedir, CONFIG_DIR, + PLUGINSCACHE_DIR, CacheName() ); msg_Dbg( p_this, "saving plugins cache file %s", psz_filename ); @@ -1853,7 +1970,19 @@ static void CacheSave( vlc_object_t *p_this ) fwrite( &i_file_size, sizeof(char), sizeof(i_file_size), file ); /* Contains version number */ - fprintf( file, PLUGINSCACHE_FILE COPYRIGHT_MESSAGE ); + fprintf( file, "%s", PLUGINSCACHE_DIR COPYRIGHT_MESSAGE ); + + /* Sub-version number (to avoid breakage in the dev version when cache + * structure changes) */ + i_file_size = CACHE_SUBVERSION_NUM; + fwrite( &i_file_size, sizeof(char), sizeof(i_file_size), file ); + + /* Language */ + fprintf( file, "%5.5s", _("C") ); + + /* Header marker */ + i_file_size = ftell( file ); + fwrite( &i_file_size, sizeof(char), sizeof(i_file_size), file ); i_cache = p_this->p_libvlc->p_module_bank->i_cache; pp_cache = p_this->p_libvlc->p_module_bank->pp_cache; @@ -1958,6 +2087,7 @@ void CacheSaveConfig( module_t *p_module, FILE *file ) SAVE_STRING( p_module->p_config[i].psz_name ); SAVE_STRING( p_module->p_config[i].psz_text ); SAVE_STRING( p_module->p_config[i].psz_longtext ); + SAVE_STRING( p_module->p_config[i].psz_current ); SAVE_STRING( p_module->p_config[i].psz_value_orig ); if( p_module->p_config[i].i_list ) @@ -1987,6 +2117,26 @@ void CacheSaveConfig( module_t *p_module, FILE *file ) } } +/***************************************************************************** + * CacheName: Return the cache file name for this platform. + *****************************************************************************/ +static char *CacheName( void ) +{ + static char psz_cachename[32]; + static vlc_bool_t b_initialised = VLC_FALSE; + + if( !b_initialised ) + { + /* Code int size, pointer size and endianness in the filename */ + int32_t x = 0xbe00001e; + sprintf( psz_cachename, "plugins-%.2x%.2x%.2x.dat", sizeof(int), + sizeof(void *), (unsigned int)((unsigned char *)&x)[0] ); + b_initialised = VLC_TRUE; + } + + return psz_cachename; +} + /***************************************************************************** * CacheMerge: Merge a cache module descriptor with a full module descriptor. *****************************************************************************/ @@ -1997,7 +2147,9 @@ static void CacheMerge( vlc_object_t *p_this, module_t *p_cache, p_cache->pf_activate = p_module->pf_activate; p_cache->pf_deactivate = p_module->pf_deactivate; +#ifndef HAVE_SHARED_LIBVLC p_cache->p_symbols = p_module->p_symbols; +#endif p_cache->handle = p_module->handle; for( i_submodule = 0; i_submodule < p_module->i_children; i_submodule++ ) @@ -2006,7 +2158,9 @@ static void CacheMerge( vlc_object_t *p_this, module_t *p_cache, module_t *p_cchild = (module_t*)p_cache->pp_children[i_submodule]; p_cchild->pf_activate = p_child->pf_activate; p_cchild->pf_deactivate = p_child->pf_deactivate; +#ifndef HAVE_SHARED_LIBVLC p_cchild->p_symbols = p_child->p_symbols; +#endif } p_cache->b_loaded = VLC_TRUE;