X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fmodules%2Favformat%2Fconsumer_avformat.c;h=4da04437f1968c5c4f6ce11bdd9e2917e72d5da9;hb=e20f82c583c6708ef09893a98f9f6b0130496eb9;hp=c9420fa0afa2f81c09e05ff9cb18bb0e20457b68;hpb=42eea21bf0c71036397cac39f19d537c9344081c;p=mlt diff --git a/src/modules/avformat/consumer_avformat.c b/src/modules/avformat/consumer_avformat.c index c9420fa0..4da04437 100644 --- a/src/modules/avformat/consumer_avformat.c +++ b/src/modules/avformat/consumer_avformat.c @@ -23,6 +23,8 @@ #include #include #include +#include +#include // System header files #include @@ -31,21 +33,31 @@ #include #include #include -#include #include // avformat header files -#include +#include #ifdef SWSCALE -#include +#include +#endif +#include +#if LIBAVUTIL_VERSION_INT >= ((50<<16)+(8<<8)+0) +#include #endif -#include #if LIBAVUTIL_VERSION_INT < (50<<16) #define PIX_FMT_RGB32 PIX_FMT_RGBA32 #define PIX_FMT_YUYV422 PIX_FMT_YUV422 #endif +#define MAX_AUDIO_STREAMS (8) +#define AUDIO_ENCODE_BUFFER_SIZE (48000 * 2 * MAX_AUDIO_STREAMS) +#define AUDIO_BUFFER_SIZE (1024 * 42) +#define VIDEO_BUFFER_SIZE (2048 * 1024) + +void avformat_lock( ); +void avformat_unlock( ); + // // This structure should be extended and made globally available in mlt // @@ -63,99 +75,99 @@ typedef struct sample_fifo sample_fifo_init( int frequency, int channels ) { - sample_fifo this = calloc( 1, sizeof( sample_fifo_s ) ); - this->frequency = frequency; - this->channels = channels; - return this; + sample_fifo fifo = calloc( 1, sizeof( sample_fifo_s ) ); + fifo->frequency = frequency; + fifo->channels = channels; + return fifo; } // sample_fifo_clear and check are temporarily aborted (not working as intended) -void sample_fifo_clear( sample_fifo this, double time ) +void sample_fifo_clear( sample_fifo fifo, double time ) { - int words = ( float )( time - this->time ) * this->frequency * this->channels; - if ( ( int )( ( float )time * 100 ) < ( int )( ( float )this->time * 100 ) && this->used > words && words > 0 ) + int words = ( float )( time - fifo->time ) * fifo->frequency * fifo->channels; + if ( ( int )( ( float )time * 100 ) < ( int )( ( float )fifo->time * 100 ) && fifo->used > words && words > 0 ) { - memmove( this->buffer, &this->buffer[ words ], ( this->used - words ) * sizeof( int16_t ) ); - this->used -= words; - this->time = time; + memmove( fifo->buffer, &fifo->buffer[ words ], ( fifo->used - words ) * sizeof( int16_t ) ); + fifo->used -= words; + fifo->time = time; } - else if ( ( int )( ( float )time * 100 ) != ( int )( ( float )this->time * 100 ) ) + else if ( ( int )( ( float )time * 100 ) != ( int )( ( float )fifo->time * 100 ) ) { - this->used = 0; - this->time = time; + fifo->used = 0; + fifo->time = time; } } -void sample_fifo_check( sample_fifo this, double time ) +void sample_fifo_check( sample_fifo fifo, double time ) { - if ( this->used == 0 ) + if ( fifo->used == 0 ) { - if ( ( int )( ( float )time * 100 ) < ( int )( ( float )this->time * 100 ) ) - this->time = time; + if ( ( int )( ( float )time * 100 ) < ( int )( ( float )fifo->time * 100 ) ) + fifo->time = time; } } -void sample_fifo_append( sample_fifo this, int16_t *samples, int count ) +void sample_fifo_append( sample_fifo fifo, int16_t *samples, int count ) { - if ( ( this->size - this->used ) < count ) + if ( ( fifo->size - fifo->used ) < count ) { - this->size += count * 5; - this->buffer = realloc( this->buffer, this->size * sizeof( int16_t ) ); + fifo->size += count * 5; + fifo->buffer = realloc( fifo->buffer, fifo->size * sizeof( int16_t ) ); } - memcpy( &this->buffer[ this->used ], samples, count * sizeof( int16_t ) ); - this->used += count; + memcpy( &fifo->buffer[ fifo->used ], samples, count * sizeof( int16_t ) ); + fifo->used += count; } -int sample_fifo_used( sample_fifo this ) +int sample_fifo_used( sample_fifo fifo ) { - return this->used; + return fifo->used; } -int sample_fifo_fetch( sample_fifo this, int16_t *samples, int count ) +int sample_fifo_fetch( sample_fifo fifo, int16_t *samples, int count ) { - if ( count > this->used ) - count = this->used; + if ( count > fifo->used ) + count = fifo->used; - memcpy( samples, this->buffer, count * sizeof( int16_t ) ); - this->used -= count; - memmove( this->buffer, &this->buffer[ count ], this->used * sizeof( int16_t ) ); + memcpy( samples, fifo->buffer, count * sizeof( int16_t ) ); + fifo->used -= count; + memmove( fifo->buffer, &fifo->buffer[ count ], fifo->used * sizeof( int16_t ) ); - this->time += ( double )count / this->channels / this->frequency; + fifo->time += ( double )count / fifo->channels / fifo->frequency; return count; } -void sample_fifo_close( sample_fifo this ) +void sample_fifo_close( sample_fifo fifo ) { - free( this->buffer ); - free( this ); + free( fifo->buffer ); + free( fifo ); } // Forward references. -static int consumer_start( mlt_consumer this ); -static int consumer_stop( mlt_consumer this ); -static int consumer_is_stopped( mlt_consumer this ); +static int consumer_start( mlt_consumer consumer ); +static int consumer_stop( mlt_consumer consumer ); +static int consumer_is_stopped( mlt_consumer consumer ); static void *consumer_thread( void *arg ); -static void consumer_close( mlt_consumer this ); +static void consumer_close( mlt_consumer consumer ); -/** Initialise the dv consumer. +/** Initialise the consumer. */ mlt_consumer consumer_avformat_init( mlt_profile profile, char *arg ) { // Allocate the consumer - mlt_consumer this = mlt_consumer_new( profile ); + mlt_consumer consumer = mlt_consumer_new( profile ); // If memory allocated and initialises without error - if ( this != NULL ) + if ( consumer != NULL ) { // Get properties from the consumer - mlt_properties properties = MLT_CONSUMER_PROPERTIES( this ); + mlt_properties properties = MLT_CONSUMER_PROPERTIES( consumer ); // Assign close callback - this->close = consumer_close; + consumer->close = consumer_close; // Interpret the argument if ( arg != NULL ) @@ -183,55 +195,84 @@ mlt_consumer consumer_avformat_init( mlt_profile profile, char *arg ) mlt_properties_set_int( properties, "prefill", 1 ); // Set up start/stop/terminated callbacks - this->start = consumer_start; - this->stop = consumer_stop; - this->is_stopped = consumer_is_stopped; + consumer->start = consumer_start; + consumer->stop = consumer_stop; + consumer->is_stopped = consumer_is_stopped; + + mlt_events_register( properties, "consumer-fatal-error", NULL ); } - // Return this - return this; + // Return consumer + return consumer; } /** Start the consumer. */ -static int consumer_start( mlt_consumer this ) +static int consumer_start( mlt_consumer consumer ) { // Get the properties - mlt_properties properties = MLT_CONSUMER_PROPERTIES( this ); + mlt_properties properties = MLT_CONSUMER_PROPERTIES( consumer ); int error = 0; // Report information about available muxers and codecs as YAML Tiny char *s = mlt_properties_get( properties, "f" ); if ( s && strcmp( s, "list" ) == 0 ) { - fprintf( stderr, "---\nformats:\n" ); + mlt_properties doc = mlt_properties_new(); + mlt_properties formats = mlt_properties_new(); + char key[20]; AVOutputFormat *format = NULL; + + mlt_properties_set_data( properties, "f", formats, 0, (mlt_destructor) mlt_properties_close, NULL ); + mlt_properties_set_data( doc, "formats", formats, 0, NULL, NULL ); while ( ( format = av_oformat_next( format ) ) ) - fprintf( stderr, " - %s\n", format->name ); - fprintf( stderr, "...\n" ); + { + snprintf( key, sizeof(key), "%d", mlt_properties_count( formats ) ); + mlt_properties_set( formats, key, format->name ); + } + fprintf( stderr, "%s", mlt_properties_serialise_yaml( doc ) ); + mlt_properties_close( doc ); error = 1; } s = mlt_properties_get( properties, "acodec" ); if ( s && strcmp( s, "list" ) == 0 ) { - fprintf( stderr, "---\naudio_codecs:\n" ); + mlt_properties doc = mlt_properties_new(); + mlt_properties codecs = mlt_properties_new(); + char key[20]; AVCodec *codec = NULL; + + mlt_properties_set_data( properties, "acodec", codecs, 0, (mlt_destructor) mlt_properties_close, NULL ); + mlt_properties_set_data( doc, "audio_codecs", codecs, 0, NULL, NULL ); while ( ( codec = av_codec_next( codec ) ) ) if ( codec->encode && codec->type == CODEC_TYPE_AUDIO ) - fprintf( stderr, " - %s\n", codec->name ); - fprintf( stderr, "...\n" ); + { + snprintf( key, sizeof(key), "%d", mlt_properties_count( codecs ) ); + mlt_properties_set( codecs, key, codec->name ); + } + fprintf( stderr, "%s", mlt_properties_serialise_yaml( doc ) ); + mlt_properties_close( doc ); error = 1; } s = mlt_properties_get( properties, "vcodec" ); if ( s && strcmp( s, "list" ) == 0 ) { - fprintf( stderr, "---\nvideo_codecs:\n" ); + mlt_properties doc = mlt_properties_new(); + mlt_properties codecs = mlt_properties_new(); + char key[20]; AVCodec *codec = NULL; + + mlt_properties_set_data( properties, "vcodec", codecs, 0, (mlt_destructor) mlt_properties_close, NULL ); + mlt_properties_set_data( doc, "video_codecs", codecs, 0, NULL, NULL ); while ( ( codec = av_codec_next( codec ) ) ) if ( codec->encode && codec->type == CODEC_TYPE_VIDEO ) - fprintf( stderr, " - %s\n", codec->name ); - fprintf( stderr, "...\n" ); + { + snprintf( key, sizeof(key), "%d", mlt_properties_count( codecs ) ); + mlt_properties_set( codecs, key, codec->name ); + } + fprintf( stderr, "%s", mlt_properties_serialise_yaml( doc ) ); + mlt_properties_close( doc ); error = 1; } @@ -259,7 +300,7 @@ static int consumer_start( mlt_consumer this ) } else { - fprintf( stderr, "%s: Invalid size property %s - ignoring.\n", __FILE__, size ); + mlt_log_warning( MLT_CONSUMER_SERVICE( consumer ), "Invalid size property %s - ignoring.\n", size ); } } @@ -271,7 +312,7 @@ static int consumer_start( mlt_consumer this ) // We need to set these on the profile as well because the s property is // an alias to mlt properties that correspond to profile settings. - mlt_profile profile = mlt_service_profile( MLT_CONSUMER_SERVICE( this ) ); + mlt_profile profile = mlt_service_profile( MLT_CONSUMER_SERVICE( consumer ) ); if ( profile ) { profile->width = width; @@ -306,7 +347,7 @@ static int consumer_start( mlt_consumer this ) mlt_properties_set_int( properties, "running", 1 ); // Create the thread - pthread_create( thread, NULL, consumer_thread, this ); + pthread_create( thread, NULL, consumer_thread, consumer ); } return error; } @@ -314,10 +355,10 @@ static int consumer_start( mlt_consumer this ) /** Stop the consumer. */ -static int consumer_stop( mlt_consumer this ) +static int consumer_stop( mlt_consumer consumer ) { // Get the properties - mlt_properties properties = MLT_CONSUMER_PROPERTIES( this ); + mlt_properties properties = MLT_CONSUMER_PROPERTIES( consumer ); // Check that we're running if ( mlt_properties_get_int( properties, "running" ) ) @@ -338,17 +379,17 @@ static int consumer_stop( mlt_consumer this ) /** Determine if the consumer is stopped. */ -static int consumer_is_stopped( mlt_consumer this ) +static int consumer_is_stopped( mlt_consumer consumer ) { // Get the properties - mlt_properties properties = MLT_CONSUMER_PROPERTIES( this ); + mlt_properties properties = MLT_CONSUMER_PROPERTIES( consumer ); return !mlt_properties_get_int( properties, "running" ); } /** Process properties as AVOptions and apply to AV context obj */ -static void apply_properties( void *obj, mlt_properties properties, int flags ) +static void apply_properties( void *obj, mlt_properties properties, int flags, int alloc ) { int i; int count = mlt_properties_count( properties ); @@ -358,9 +399,9 @@ static void apply_properties( void *obj, mlt_properties properties, int flags ) const AVOption *opt = av_find_opt( obj, opt_name, NULL, flags, flags ); if ( opt != NULL ) #if LIBAVCODEC_VERSION_INT >= ((52<<16)+(7<<8)+0) - av_set_string3( obj, opt_name, mlt_properties_get( properties, opt_name), 0, NULL ); + av_set_string3( obj, opt_name, mlt_properties_get( properties, opt_name), alloc, NULL ); #elif LIBAVCODEC_VERSION_INT >= ((51<<16)+(59<<8)+0) - av_set_string2( obj, opt_name, mlt_properties_get( properties, opt_name), 0 ); + av_set_string2( obj, opt_name, mlt_properties_get( properties, opt_name), alloc ); #else av_set_string( obj, opt_name, mlt_properties_get( properties, opt_name) ); #endif @@ -370,13 +411,13 @@ static void apply_properties( void *obj, mlt_properties properties, int flags ) /** Add an audio output stream */ -static AVStream *add_audio_stream( mlt_consumer this, AVFormatContext *oc, int codec_id ) +static AVStream *add_audio_stream( mlt_consumer consumer, AVFormatContext *oc, int codec_id, int channels ) { // Get the properties - mlt_properties properties = MLT_CONSUMER_PROPERTIES( this ); + mlt_properties properties = MLT_CONSUMER_PROPERTIES( consumer ); // Create a new stream - AVStream *st = av_new_stream( oc, 1 ); + AVStream *st = av_new_stream( oc, oc->nb_streams ); // If created, then initialise from properties if ( st != NULL ) @@ -388,13 +429,16 @@ static AVStream *add_audio_stream( mlt_consumer this, AVFormatContext *oc, int c c->codec_id = codec_id; c->codec_type = CODEC_TYPE_AUDIO; + c->sample_fmt = SAMPLE_FMT_S16; +#if 0 // disabled until some audio codecs are multi-threaded // Setup multi-threading int thread_count = mlt_properties_get_int( properties, "threads" ); if ( thread_count == 0 && getenv( "MLT_AVFORMAT_THREADS" ) ) thread_count = atoi( getenv( "MLT_AVFORMAT_THREADS" ) ); if ( thread_count > 1 ) avcodec_thread_init( c, thread_count ); +#endif if (oc->oformat->flags & AVFMT_GLOBALHEADER) c->flags |= CODEC_FLAG_GLOBAL_HEADER; @@ -411,7 +455,14 @@ static AVStream *add_audio_stream( mlt_consumer this, AVFormatContext *oc, int c } // Process properties as AVOptions - apply_properties( c, properties, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_ENCODING_PARAM ); + char *apre = mlt_properties_get( properties, "apre" ); + if ( apre ) + { + mlt_properties p = mlt_properties_load( apre ); + apply_properties( c, p, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_ENCODING_PARAM, 1 ); + mlt_properties_close( p ); + } + apply_properties( c, properties, AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_ENCODING_PARAM, 0 ); int audio_qscale = mlt_properties_get_int( properties, "aq" ); if ( audio_qscale > QSCALE_NONE ) @@ -422,20 +473,21 @@ static AVStream *add_audio_stream( mlt_consumer this, AVFormatContext *oc, int c // Set parameters controlled by MLT c->sample_rate = mlt_properties_get_int( properties, "frequency" ); - c->channels = mlt_properties_get_int( properties, "channels" ); + c->time_base = ( AVRational ){ 1, c->sample_rate }; + c->channels = channels; if ( mlt_properties_get( properties, "alang" ) != NULL ) strncpy( st->language, mlt_properties_get( properties, "alang" ), sizeof( st->language ) ); } else { - fprintf( stderr, "%s: Could not allocate a stream for audio\n", __FILE__ ); + mlt_log_error( MLT_CONSUMER_SERVICE( consumer ), "Could not allocate a stream for audio\n" ); } return st; } -static int open_audio( AVFormatContext *oc, AVStream *st, int audio_outbuf_size ) +static int open_audio( AVFormatContext *oc, AVStream *st, int audio_outbuf_size, const char *codec_name ) { // We will return the audio input size from here int audio_input_frame_size = 0; @@ -444,8 +496,14 @@ static int open_audio( AVFormatContext *oc, AVStream *st, int audio_outbuf_size AVCodecContext *c = st->codec; // Find the encoder - AVCodec *codec = avcodec_find_encoder( c->codec_id ); + AVCodec *codec; + if ( codec_name ) + codec = avcodec_find_encoder_by_name( codec_name ); + else + codec = avcodec_find_encoder( c->codec_id ); + avformat_lock(); + // Continue if codec found and we can open it if ( codec != NULL && avcodec_open( c, codec ) >= 0 ) { @@ -472,34 +530,41 @@ static int open_audio( AVFormatContext *oc, AVStream *st, int audio_outbuf_size } // Some formats want stream headers to be seperate (hmm) - if( !strcmp( oc->oformat->name, "mp4" ) || - !strcmp( oc->oformat->name, "mov" ) || - !strcmp( oc->oformat->name, "3gp" ) ) + if ( !strcmp( oc->oformat->name, "mp4" ) || + !strcmp( oc->oformat->name, "mov" ) || + !strcmp( oc->oformat->name, "3gp" ) ) c->flags |= CODEC_FLAG_GLOBAL_HEADER; } else { - fprintf( stderr, "%s: Unable to encode audio - disabling audio output.\n", __FILE__ ); + mlt_log_warning( NULL, "%s: Unable to encode audio - disabling audio output.\n", __FILE__ ); } + + avformat_unlock(); return audio_input_frame_size; } static void close_audio( AVFormatContext *oc, AVStream *st ) { - avcodec_close( st->codec ); + if ( st && st->codec ) + { + avformat_lock(); + avcodec_close( st->codec ); + avformat_unlock(); + } } /** Add a video output stream */ -static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int codec_id ) +static AVStream *add_video_stream( mlt_consumer consumer, AVFormatContext *oc, int codec_id ) { // Get the properties - mlt_properties properties = MLT_CONSUMER_PROPERTIES( this ); + mlt_properties properties = MLT_CONSUMER_PROPERTIES( consumer ); // Create a new stream - AVStream *st = av_new_stream( oc, 0 ); + AVStream *st = av_new_stream( oc, oc->nb_streams ); if ( st != NULL ) { @@ -520,7 +585,41 @@ static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int c avcodec_thread_init( c, thread_count ); // Process properties as AVOptions - apply_properties( c, properties, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM ); + char *vpre = mlt_properties_get( properties, "vpre" ); + if ( vpre ) + { + mlt_properties p = mlt_properties_load( vpre ); +#ifdef AVDATADIR + if ( mlt_properties_count( p ) < 1 ) + { + AVCodec *codec = avcodec_find_encoder( c->codec_id ); + if ( codec ) + { + char *path = malloc( strlen(AVDATADIR) + strlen(codec->name) + strlen(vpre) + strlen(".ffpreset") + 2 ); + strcpy( path, AVDATADIR ); + strcat( path, codec->name ); + strcat( path, "-" ); + strcat( path, vpre ); + strcat( path, ".ffpreset" ); + + mlt_properties_close( p ); + p = mlt_properties_load( path ); + mlt_properties_debug( p, path, stderr ); + free( path ); + } + } + else + { + mlt_properties_debug( p, vpre, stderr ); + } +#endif + apply_properties( c, p, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM, 1 ); + mlt_properties_close( p ); + } + int colorspace = mlt_properties_get_int( properties, "colorspace" ); + mlt_properties_set( properties, "colorspace", NULL ); + apply_properties( c, properties, AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM, 0 ); + mlt_properties_set_int( properties, "colorspace", colorspace ); // Set options controlled by MLT c->width = mlt_properties_get_int( properties, "width" ); @@ -529,7 +628,32 @@ static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int c c->time_base.den = mlt_properties_get_int( properties, "frame_rate_num" ); if ( st->time_base.den == 0 ) st->time_base = c->time_base; +#if LIBAVUTIL_VERSION_INT >= ((50<<16)+(8<<8)+0) + c->pix_fmt = pix_fmt ? av_get_pix_fmt( pix_fmt ) : PIX_FMT_YUV420P; +#else c->pix_fmt = pix_fmt ? avcodec_get_pix_fmt( pix_fmt ) : PIX_FMT_YUV420P; +#endif + +#if LIBAVCODEC_VERSION_INT > ((52<<16)+(28<<8)+0) + switch ( colorspace ) + { + case 170: + c->colorspace = AVCOL_SPC_SMPTE170M; + break; + case 240: + c->colorspace = AVCOL_SPC_SMPTE240M; + break; + case 470: + c->colorspace = AVCOL_SPC_BT470BG; + break; + case 601: + c->colorspace = ( 576 % c->height ) ? AVCOL_SPC_SMPTE170M : AVCOL_SPC_BT470BG; + break; + case 709: + c->colorspace = AVCOL_SPC_BT709; + break; + } +#endif if ( mlt_properties_get( properties, "aspect" ) ) { @@ -541,7 +665,7 @@ static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int c // for mlt properties that correspond to profile settings mlt_properties_set_int( properties, "display_aspect_num", rational.num ); mlt_properties_set_int( properties, "display_aspect_den", rational.den ); - mlt_profile profile = mlt_service_profile( MLT_CONSUMER_SERVICE( this ) ); + mlt_profile profile = mlt_service_profile( MLT_CONSUMER_SERVICE( consumer ) ); if ( profile ) { profile->display_aspect_num = rational.num; @@ -597,9 +721,9 @@ static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int c if ( mlt_properties_get_int( properties, "progressive" ) == 0 && mlt_properties_get_int( properties, "deinterlace" ) == 0 ) { - if ( mlt_properties_get_int( properties, "ildct" ) ) + if ( ! mlt_properties_get( properties, "ildct" ) || mlt_properties_get_int( properties, "ildct" ) ) c->flags |= CODEC_FLAG_INTERLACED_DCT; - if ( mlt_properties_get_int( properties, "ilme" ) ) + if ( ! mlt_properties_get( properties, "ilme" ) || mlt_properties_get_int( properties, "ilme" ) ) c->flags |= CODEC_FLAG_INTERLACED_ME; } @@ -611,7 +735,7 @@ static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int c int start, end, q; int e = sscanf( rc_override, "%d,%d,%d", &start, &end, &q ); if ( e != 3 ) - fprintf( stderr, "%s: Error parsing rc_override\n", __FILE__ ); + mlt_log_warning( MLT_CONSUMER_SERVICE( consumer ), "Error parsing rc_override\n" ); c->rc_override = av_realloc( c->rc_override, sizeof( RcOverride ) * ( i + 1 ) ); c->rc_override[i].start_frame = start; c->rc_override[i].end_frame = end; @@ -673,7 +797,7 @@ static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int c fseek( f, 0, SEEK_SET ); logbuffer = av_malloc( size + 1 ); if ( !logbuffer ) - fprintf( stderr, "%s: Could not allocate log buffer\n", __FILE__ ); + mlt_log_fatal( MLT_CONSUMER_SERVICE( consumer ), "Could not allocate log buffer\n" ); else { size = fread( logbuffer, 1, size, f ); @@ -688,7 +812,7 @@ static AVStream *add_video_stream( mlt_consumer this, AVFormatContext *oc, int c } else { - fprintf( stderr, "%s: Could not allocate a stream for video\n", __FILE__ ); + mlt_log_error( MLT_CONSUMER_SERVICE( consumer ), "Could not allocate a stream for video\n" ); } return st; @@ -743,12 +867,21 @@ static int open_video(AVFormatContext *oc, AVStream *st) } // Open the codec safely - return codec != NULL && avcodec_open( video_enc, codec ) >= 0; + avformat_lock(); + int result = codec != NULL && avcodec_open( video_enc, codec ) >= 0; + avformat_unlock(); + + return result; } void close_video(AVFormatContext *oc, AVStream *st) { - avcodec_close(st->codec); + if ( st && st->codec ) + { + avformat_lock(); + avcodec_close(st->codec); + avformat_unlock(); + } } static inline long time_difference( struct timeval *time1 ) @@ -764,10 +897,10 @@ static inline long time_difference( struct timeval *time1 ) static void *consumer_thread( void *arg ) { // Map the argument to the object - mlt_consumer this = arg; + mlt_consumer consumer = arg; // Get the properties - mlt_properties properties = MLT_CONSUMER_PROPERTIES( this ); + mlt_properties properties = MLT_CONSUMER_PROPERTIES( consumer ); // Get the terminate on pause property int terminate_on_pause = mlt_properties_get_int( properties, "terminate_on_pause" ); @@ -789,20 +922,21 @@ static void *consumer_thread( void *arg ) int img_height = height; // Get default audio properties - mlt_audio_format aud_fmt = mlt_audio_pcm; + mlt_audio_format aud_fmt = mlt_audio_s16; int channels = mlt_properties_get_int( properties, "channels" ); + int total_channels = channels; int frequency = mlt_properties_get_int( properties, "frequency" ); int16_t *pcm = NULL; int samples = 0; // AVFormat audio buffer and frame size - int audio_outbuf_size = 10000; + int audio_outbuf_size = AUDIO_BUFFER_SIZE; uint8_t *audio_outbuf = av_malloc( audio_outbuf_size ); int audio_input_frame_size = 0; // AVFormat video buffer and frame count int frame_count = 0; - int video_outbuf_size = ( 1024 * 1024 ); + int video_outbuf_size = VIDEO_BUFFER_SIZE; uint8_t *video_outbuf = av_malloc( video_outbuf_size ); // Used for the frame properties @@ -822,24 +956,26 @@ static void *consumer_thread( void *arg ) mlt_image_format img_fmt = mlt_image_yuv422; // For receiving audio samples back from the fifo - int16_t *buffer = av_malloc( 48000 * 2 ); + int16_t *audio_buf_1 = av_malloc( AUDIO_ENCODE_BUFFER_SIZE ); + int16_t *audio_buf_2 = NULL; int count = 0; // Allocate the context +#if (LIBAVFORMAT_VERSION_INT >= ((52<<16)+(26<<8)+0)) + AVFormatContext *oc = avformat_alloc_context( ); +#else AVFormatContext *oc = av_alloc_format_context( ); +#endif // Streams - AVStream *audio_st = NULL; AVStream *video_st = NULL; + AVStream *audio_st[ MAX_AUDIO_STREAMS ]; // Time stamps double audio_pts = 0; double video_pts = 0; - // Loop variable - int i; - - // Frames despatched + // Frames dispatched long int frames = 0; long int total_time = 0; @@ -854,17 +990,38 @@ static void *consumer_thread( void *arg ) int audio_codec_id; int video_codec_id; + // Misc + char key[27]; + mlt_properties frame_meta_properties = mlt_properties_new(); + + // Initialize audio_st + int i = MAX_AUDIO_STREAMS; + while ( i-- ) + audio_st[i] = NULL; + // Check for user selected format first if ( format != NULL ) +#if LIBAVFORMAT_VERSION_INT < ((52<<16)+(45<<8)+0) fmt = guess_format( format, NULL, NULL ); +#else + fmt = av_guess_format( format, NULL, NULL ); +#endif // Otherwise check on the filename if ( fmt == NULL && filename != NULL ) +#if LIBAVFORMAT_VERSION_INT < ((52<<16)+(45<<8)+0) fmt = guess_format( NULL, filename, NULL ); +#else + fmt = av_guess_format( NULL, filename, NULL ); +#endif // Otherwise default to mpeg if ( fmt == NULL ) +#if LIBAVFORMAT_VERSION_INT < ((52<<16)+(45<<8)+0) fmt = guess_format( "mpeg", NULL, NULL ); +#else + fmt = av_guess_format( "mpeg", NULL, NULL ); +#endif // We need a filename - default to stdout? if ( filename == NULL || !strcmp( filename, "" ) ) @@ -875,19 +1032,26 @@ static void *consumer_thread( void *arg ) video_codec_id = fmt->video_codec; // Check for audio codec overides - if ( ( acodec && strcmp( "acodec", "none" ) == 0 ) || mlt_properties_get_int( properties, "an" ) ) + if ( ( acodec && strcmp( acodec, "none" ) == 0 ) || mlt_properties_get_int( properties, "an" ) ) audio_codec_id = CODEC_ID_NONE; else if ( acodec ) { AVCodec *p = avcodec_find_encoder_by_name( acodec ); if ( p != NULL ) + { audio_codec_id = p->id; + if ( audio_codec_id == CODEC_ID_AC3 && avcodec_find_encoder_by_name( "ac3_fixed" ) ) + { + mlt_properties_set( properties, "_acodec", "ac3_fixed" ); + acodec = mlt_properties_get( properties, "_acodec" ); + } + } else - fprintf( stderr, "%s: audio codec %s unrecognised - ignoring\n", __FILE__, acodec ); + mlt_log_warning( MLT_CONSUMER_SERVICE( consumer ), "audio codec %s unrecognised - ignoring\n", acodec ); } // Check for video codec overides - if ( ( vcodec && strcmp( "vcodec", "none" ) == 0 ) || mlt_properties_get_int( properties, "vn" ) ) + if ( ( vcodec && strcmp( vcodec, "none" ) == 0 ) || mlt_properties_get_int( properties, "vn" ) ) video_codec_id = CODEC_ID_NONE; else if ( vcodec ) { @@ -895,10 +1059,32 @@ static void *consumer_thread( void *arg ) if ( p != NULL ) video_codec_id = p->id; else - fprintf( stderr, "%s: video codec %s unrecognised - ignoring\n", __FILE__, vcodec ); + mlt_log_warning( MLT_CONSUMER_SERVICE( consumer ), "video codec %s unrecognised - ignoring\n", vcodec ); } // Write metadata +#if LIBAVFORMAT_VERSION_INT >= ((52<<16)+(31<<8)+0) + for ( i = 0; i < mlt_properties_count( properties ); i++ ) + { + char *name = mlt_properties_get_name( properties, i ); + if ( name && !strncmp( name, "meta.attr.", 10 ) ) + { + char *key = strdup( name + 10 ); + char *markup = strrchr( key, '.' ); + if ( markup && !strcmp( markup, ".markup") ) + { + markup[0] = '\0'; + if ( !strstr( key, ".stream." ) ) +#if LIBAVFORMAT_VERSION_INT >= ((52<<16)+(43<<8)+0) + av_metadata_set2( &oc->metadata, key, mlt_properties_get_value( properties, i ), 0 ); +#else + av_metadata_set( &oc->metadata, key, mlt_properties_get_value( properties, i ) ); +#endif + } + free( key ); + } + } +#else char *tmp = NULL; int metavalue; @@ -922,15 +1108,38 @@ static void *consumer_thread( void *arg ) metavalue = mlt_properties_get_int( properties, "meta.attr.track.markup"); if (metavalue != 0) oc->track = metavalue; +#endif oc->oformat = fmt; snprintf( oc->filename, sizeof(oc->filename), "%s", filename ); - // Add audio and video streams + // Add audio and video streams if ( video_codec_id != CODEC_ID_NONE ) - video_st = add_video_stream( this, oc, video_codec_id ); + video_st = add_video_stream( consumer, oc, video_codec_id ); if ( audio_codec_id != CODEC_ID_NONE ) - audio_st = add_audio_stream( this, oc, audio_codec_id ); + { + int is_multi = 0; + + total_channels = 0; + // multitrack audio + for ( i = 0; i < MAX_AUDIO_STREAMS; i++ ) + { + sprintf( key, "channels.%d", i ); + int j = mlt_properties_get_int( properties, key ); + if ( j ) + { + is_multi = 1; + total_channels += j; + audio_st[i] = add_audio_stream( consumer, oc, audio_codec_id, j ); + } + } + // single track + if ( !is_multi ) + { + audio_st[0] = add_audio_stream( consumer, oc, audio_codec_id, channels ); + total_channels = channels; + } + } // Set the parameters (even though we have none...) if ( av_set_parameters(oc, NULL) >= 0 ) @@ -939,30 +1148,42 @@ static void *consumer_thread( void *arg ) oc->max_delay= ( int )( mlt_properties_get_double( properties, "muxdelay" ) * AV_TIME_BASE ); // Process properties as AVOptions - apply_properties( oc, properties, AV_OPT_FLAG_ENCODING_PARAM ); + char *fpre = mlt_properties_get( properties, "fpre" ); + if ( fpre ) + { + mlt_properties p = mlt_properties_load( fpre ); + apply_properties( oc, p, AV_OPT_FLAG_ENCODING_PARAM, 1 ); + mlt_properties_close( p ); + } + apply_properties( oc, properties, AV_OPT_FLAG_ENCODING_PARAM, 0 ); if ( video_st && !open_video( oc, video_st ) ) video_st = NULL; - if ( audio_st ) - audio_input_frame_size = open_audio( oc, audio_st, audio_outbuf_size ); + for ( i = 0; i < MAX_AUDIO_STREAMS && audio_st[i]; i++ ) + { + audio_input_frame_size = open_audio( oc, audio_st[i], audio_outbuf_size, + audio_codec_id == CODEC_ID_AC3 ? acodec : NULL ); + if ( !audio_input_frame_size ) + audio_st[i] = NULL; + } // Open the output file, if needed if ( !( fmt->flags & AVFMT_NOFILE ) ) { if ( url_fopen( &oc->pb, filename, URL_WRONLY ) < 0 ) { - fprintf( stderr, "%s: Could not open '%s'\n", __FILE__, filename ); + mlt_log_error( MLT_CONSUMER_SERVICE( consumer ), "Could not open '%s'\n", filename ); mlt_properties_set_int( properties, "running", 0 ); } } - // Write the stream header, if any + // Write the stream header. if ( mlt_properties_get_int( properties, "running" ) ) av_write_header( oc ); } else { - fprintf( stderr, "%s: Invalid output format parameters\n", __FILE__ ); + mlt_log_error( MLT_CONSUMER_SERVICE( consumer ), "Invalid output format parameters\n" ); mlt_properties_set_int( properties, "running", 0 ); } @@ -971,22 +1192,22 @@ static void *consumer_thread( void *arg ) output = alloc_picture( video_st->codec->pix_fmt, width, height ); // Last check - need at least one stream - if ( audio_st == NULL && video_st == NULL ) + if ( !audio_st[0] && !video_st ) mlt_properties_set_int( properties, "running", 0 ); // Get the starting time (can ignore the times above) gettimeofday( &ante, NULL ); // Loop while running - while( mlt_properties_get_int( properties, "running" ) && !terminated ) + while( mlt_properties_get_int( properties, "running" ) && + ( !terminated || ( video_st && mlt_deque_count( queue ) ) ) ) { - // Get the frame - frame = mlt_consumer_rt_frame( this ); + frame = mlt_consumer_rt_frame( consumer ); // Check that we have a frame to work with if ( frame != NULL ) { - // Increment frames despatched + // Increment frames dispatched frames ++; // Default audio args @@ -996,10 +1217,13 @@ static void *consumer_thread( void *arg ) terminated = terminate_on_pause && mlt_properties_get_double( frame_properties, "_speed" ) == 0.0; // Get audio and append to the fifo - if ( !terminated && audio_st ) + if ( !terminated && audio_st[0] ) { samples = mlt_sample_calculator( fps, frequency, count ++ ); - mlt_frame_get_audio( frame, &pcm, &aud_fmt, &frequency, &channels, &samples ); + mlt_frame_get_audio( frame, (void**) &pcm, &aud_fmt, &frequency, &channels, &samples ); + + // Save the audio channel remap properties for later + mlt_properties_pass( frame_meta_properties, frame_properties, "meta.map.audio." ); // Create the fifo if we don't have one if ( fifo == NULL ) @@ -1008,12 +1232,16 @@ static void *consumer_thread( void *arg ) mlt_properties_set_data( properties, "sample_fifo", fifo, 0, ( mlt_destructor )sample_fifo_close, NULL ); } + // Silence if not normal forward speed if ( mlt_properties_get_double( frame_properties, "_speed" ) != 1.0 ) memset( pcm, 0, samples * channels * 2 ); // Append the samples sample_fifo_append( fifo, pcm, samples * channels ); total_time += ( samples * 1000000 ) / frequency; + + if ( !video_st ) + mlt_events_fire( properties, "consumer-frame-show", frame, NULL ); } // Encode the image @@ -1026,42 +1254,142 @@ static void *consumer_thread( void *arg ) // While we have stuff to process, process... while ( 1 ) { - if (audio_st) - audio_pts = (double)audio_st->pts.val * audio_st->time_base.num / audio_st->time_base.den; - else - audio_pts = 0.0; - - if (video_st) - video_pts = (double)video_st->pts.val * video_st->time_base.num / video_st->time_base.den; - else - video_pts = 0.0; - // Write interleaved audio and video frames - if ( !video_st || ( video_st && audio_st && audio_pts < video_pts ) ) + if ( !video_st || ( video_st && audio_st[0] && audio_pts < video_pts ) ) { - if ( channels * audio_input_frame_size < sample_fifo_used( fifo ) ) + // Write audio + if ( ( video_st && terminated ) || ( channels * audio_input_frame_size ) < sample_fifo_used( fifo ) ) { - AVCodecContext *c; - AVPacket pkt; - av_init_packet( &pkt ); + int j = 0; // channel offset into interleaved source buffer + int n = FFMIN( FFMIN( channels * audio_input_frame_size, sample_fifo_used( fifo ) ), AUDIO_ENCODE_BUFFER_SIZE ); + + // Get the audio samples + if ( n > 0 ) + { + sample_fifo_fetch( fifo, audio_buf_1, n ); + } + else if ( audio_codec_id == CODEC_ID_VORBIS && terminated ) + { + // This prevents an infinite loop when some versions of vorbis do not + // increment pts when encoding silence. + audio_pts = video_pts; + break; + } + else + { + memset( audio_buf_1, 0, AUDIO_ENCODE_BUFFER_SIZE ); + } + samples = n / channels; + + // For each output stream + for ( i = 0; i < MAX_AUDIO_STREAMS && audio_st[i] && j < total_channels; i++ ) + { + AVStream *stream = audio_st[i]; + AVCodecContext *codec = stream->codec; + AVPacket pkt; + + av_init_packet( &pkt ); + + // Optimized for single track and no channel remap + if ( !audio_st[1] && !mlt_properties_count( frame_meta_properties ) ) + { + pkt.size = avcodec_encode_audio( codec, audio_outbuf, audio_outbuf_size, audio_buf_1 ); + } + else + { + // Extract the audio channels according to channel mapping + int dest_offset = 0; // channel offset into interleaved dest buffer + + // Get the number of channels for this stream + sprintf( key, "channels.%d", i ); + int current_channels = mlt_properties_get_int( properties, key ); - c = audio_st->codec; + // Clear the destination audio buffer. + if ( !audio_buf_2 ) + audio_buf_2 = av_mallocz( AUDIO_ENCODE_BUFFER_SIZE ); + else + memset( audio_buf_2, 0, AUDIO_ENCODE_BUFFER_SIZE ); + + // For each output channel + while ( dest_offset < current_channels && j < total_channels ) + { + int map_start = -1, map_channels = 0; + int source_offset = 0; + int k; - sample_fifo_fetch( fifo, buffer, channels * audio_input_frame_size ); + // Look for a mapping that starts at j + for ( k = 0; k < (MAX_AUDIO_STREAMS * 2) && map_start != j; k++ ) + { + sprintf( key, "%d.channels", k ); + map_channels = mlt_properties_get_int( frame_meta_properties, key ); + sprintf( key, "%d.start", k ); + if ( mlt_properties_get( frame_meta_properties, key ) ) + map_start = mlt_properties_get_int( frame_meta_properties, key ); + if ( map_start != j ) + source_offset += map_channels; + } + + // If no mapping + if ( map_start != j ) + { + map_channels = current_channels; + source_offset = j; + } + + // Copy samples if source offset valid + if ( source_offset < channels ) + { + // Interleave the audio buffer with the # channels for this stream/mapping. + for ( k = 0; k < map_channels; k++, j++, source_offset++, dest_offset++ ) + { + int16_t *src = audio_buf_1 + source_offset; + int16_t *dest = audio_buf_2 + dest_offset; + int s = samples + 1; + + while ( --s ) { + *dest = *src; + dest += current_channels; + src += channels; + } + } + } + // Otherwise silence + else + { + j += current_channels; + dest_offset += current_channels; + } + } + pkt.size = avcodec_encode_audio( codec, audio_outbuf, audio_outbuf_size, audio_buf_2 ); + } - pkt.size = avcodec_encode_audio( c, audio_outbuf, audio_outbuf_size, buffer ); - // Write the compressed frame in the media file - if ( c->coded_frame && c->coded_frame->pts != AV_NOPTS_VALUE ) - pkt.pts = av_rescale_q( c->coded_frame->pts, c->time_base, audio_st->time_base ); - pkt.flags |= PKT_FLAG_KEY; - pkt.stream_index= audio_st->index; - pkt.data= audio_outbuf; + // Write the compressed frame in the media file + if ( codec->coded_frame && codec->coded_frame->pts != AV_NOPTS_VALUE ) + { + pkt.pts = av_rescale_q( codec->coded_frame->pts, codec->time_base, stream->time_base ); + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), "audio stream %d pkt pts %lld frame pts %lld", + stream->index, pkt.pts, codec->coded_frame->pts ); + } + pkt.flags |= PKT_FLAG_KEY; + pkt.stream_index = stream->index; + pkt.data = audio_outbuf; - if ( pkt.size ) - if ( av_interleaved_write_frame( oc, &pkt ) != 0) - fprintf( stderr, "%s: Error while writing audio frame\n", __FILE__ ); + if ( pkt.size > 0 ) + { + if ( av_interleaved_write_frame( oc, &pkt ) ) + { + mlt_log_fatal( MLT_CONSUMER_SERVICE( consumer ), "error writing audio frame\n" ); + mlt_events_fire( properties, "consumer-fatal-error", NULL ); + goto on_fatal_error; + } + } - audio_pts += c->frame_size; + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), " frame_size %d\n", codec->frame_size ); + if ( i == 0 ) + { + audio_pts = (double)stream->pts.val * av_q2d( stream->time_base ); + } + } } else { @@ -1070,9 +1398,10 @@ static void *consumer_thread( void *arg ) } else if ( video_st ) { + // Write video if ( mlt_deque_count( queue ) ) { - int out_size, ret; + int out_size, ret = 0; AVCodecContext *c; frame = mlt_deque_pop_front( queue ); @@ -1083,12 +1412,9 @@ static void *consumer_thread( void *arg ) if ( mlt_properties_get_int( frame_properties, "rendered" ) ) { int i = 0; - int j = 0; uint8_t *p; uint8_t *q; - mlt_events_fire( properties, "consumer-frame-show", frame, NULL ); - mlt_frame_get_image( frame, &image, &img_fmt, &img_width, &img_height, 0 ); q = image; @@ -1097,18 +1423,21 @@ static void *consumer_thread( void *arg ) for ( i = 0; i < height; i ++ ) { p = input->data[ 0 ] + i * input->linesize[ 0 ]; - j = width; - while( j -- ) - { - *p ++ = *q ++; - *p ++ = *q ++; - } + memcpy( p, q, width * 2 ); + q += width * 2; } // Do the colour space conversion #ifdef SWSCALE + int flags = SWS_BILINEAR; +#ifdef USE_MMX + flags |= SWS_CPU_CAPS_MMX; +#endif +#ifdef USE_SSE + flags |= SWS_CPU_CAPS_MMX2; +#endif struct SwsContext *context = sws_getContext( width, height, PIX_FMT_YUYV422, - width, height, video_st->codec->pix_fmt, SWS_FAST_BILINEAR, NULL, NULL, NULL); + width, height, video_st->codec->pix_fmt, flags, NULL, NULL, NULL); sws_scale( context, input->data, input->linesize, 0, height, output->data, output->linesize); sws_freeContext( context ); @@ -1116,6 +1445,8 @@ static void *consumer_thread( void *arg ) img_convert( ( AVPicture * )output, video_st->codec->pix_fmt, ( AVPicture * )input, PIX_FMT_YUYV422, width, height ); #endif + mlt_events_fire( properties, "consumer-frame-show", frame, NULL ); + // Apply the alpha if applicable if ( video_st->codec->pix_fmt == PIX_FMT_RGB32 ) { @@ -1125,11 +1456,7 @@ static void *consumer_thread( void *arg ) for ( i = 0; i < height; i ++ ) { n = ( width + 7 ) / 8; - p = output->data[ 0 ] + i * output->linesize[ 0 ]; - - #ifndef __DARWIN__ - p += 3; - #endif + p = output->data[ 0 ] + i * output->linesize[ 0 ] + 3; switch( width % 8 ) { @@ -1170,18 +1497,20 @@ static void *consumer_thread( void *arg ) // Set frame interlace hints output->interlaced_frame = !mlt_properties_get_int( frame_properties, "progressive" ); output->top_field_first = mlt_properties_get_int( frame_properties, "top_field_first" ); + output->pts = frame_count; // Encode the image out_size = avcodec_encode_video(c, video_outbuf, video_outbuf_size, output ); // If zero size, it means the image was buffered - if (out_size > 0) + if ( out_size > 0 ) { AVPacket pkt; av_init_packet( &pkt ); if ( c->coded_frame && c->coded_frame->pts != AV_NOPTS_VALUE ) pkt.pts= av_rescale_q( c->coded_frame->pts, c->time_base, video_st->time_base ); + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), "video pkt pts %lld frame pts %lld", pkt.pts, c->coded_frame->pts ); if( c->coded_frame && c->coded_frame->key_frame ) pkt.flags |= PKT_FLAG_KEY; pkt.stream_index= video_st->index; @@ -1190,18 +1519,25 @@ static void *consumer_thread( void *arg ) // write the compressed frame in the media file ret = av_interleaved_write_frame(oc, &pkt); - video_pts += c->frame_size; + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), " frame_size %d\n", c->frame_size ); + video_pts = (double)video_st->pts.val * av_q2d( video_st->time_base ); // Dual pass logging - if ( mlt_properties_get_data( properties, "_logfile", NULL ) && c->stats_out) + if ( mlt_properties_get_data( properties, "_logfile", NULL ) && c->stats_out ) fprintf( mlt_properties_get_data( properties, "_logfile", NULL ), "%s", c->stats_out ); } - else + else if ( out_size < 0 ) { - fprintf( stderr, "%s: error with video encode\n", __FILE__ ); + mlt_log_warning( MLT_CONSUMER_SERVICE( consumer ), "error with video encode %d\n", frame_count ); } } frame_count++; + if ( ret ) + { + mlt_log_fatal( MLT_CONSUMER_SERVICE( consumer ), "error writing video frame\n" ); + mlt_events_fire( properties, "consumer-fatal-error", NULL ); + goto on_fatal_error; + } mlt_frame_close( frame ); } else @@ -1209,9 +1545,14 @@ static void *consumer_thread( void *arg ) break; } } + if ( audio_st[0] ) + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), "audio pts %lld (%f) ", audio_st[0]->pts.val, audio_pts ); + if ( video_st ) + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), "video pts %lld (%f) ", video_st->pts.val, video_pts ); + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), "\n" ); } - if ( real_time_output == 1 && frames % 12 == 0 ) + if ( real_time_output == 1 && frames % 2 == 0 ) { long passed = time_difference( &ante ); if ( fifo != NULL ) @@ -1228,13 +1569,14 @@ static void *consumer_thread( void *arg ) } } -#ifdef FLUSH - if ( ! real_time_output ) + // Flush the encoder buffers + if ( real_time_output <= 0 ) { // Flush audio fifo - if ( audio_st && audio_st->codec->frame_size > 1 ) for (;;) + // TODO: flush all audio streams + if ( audio_st[0] && audio_st[0]->codec->frame_size > 1 ) for (;;) { - AVCodecContext *c = audio_st->codec; + AVCodecContext *c = audio_st[0]->codec; AVPacket pkt; av_init_packet( &pkt ); pkt.size = 0; @@ -1242,24 +1584,26 @@ static void *consumer_thread( void *arg ) if ( /*( c->capabilities & CODEC_CAP_SMALL_LAST_FRAME ) &&*/ ( channels * audio_input_frame_size < sample_fifo_used( fifo ) ) ) { - sample_fifo_fetch( fifo, buffer, channels * audio_input_frame_size ); - pkt.size = avcodec_encode_audio( c, audio_outbuf, audio_outbuf_size, buffer ); + sample_fifo_fetch( fifo, audio_buf_1, channels * audio_input_frame_size ); + pkt.size = avcodec_encode_audio( c, audio_outbuf, audio_outbuf_size, audio_buf_1 ); } if ( pkt.size <= 0 ) pkt.size = avcodec_encode_audio( c, audio_outbuf, audio_outbuf_size, NULL ); + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), "flushing audio size %d\n", pkt.size ); if ( pkt.size <= 0 ) break; // Write the compressed frame in the media file if ( c->coded_frame && c->coded_frame->pts != AV_NOPTS_VALUE ) - pkt.pts = av_rescale_q( c->coded_frame->pts, c->time_base, audio_st->time_base ); + pkt.pts = av_rescale_q( c->coded_frame->pts, c->time_base, audio_st[0]->time_base ); pkt.flags |= PKT_FLAG_KEY; - pkt.stream_index = audio_st->index; + pkt.stream_index = audio_st[0]->index; pkt.data = audio_outbuf; if ( av_interleaved_write_frame( oc, &pkt ) != 0 ) { - fprintf( stderr, "%s: Error while writing flushed audio frame\n", __FILE__ ); - break; + mlt_log_fatal( MLT_CONSUMER_SERVICE( consumer ), "error writing flushed audio frame\n" ); + mlt_events_fire( properties, "consumer-fatal-error", NULL ); + goto on_fatal_error; } } @@ -1272,6 +1616,7 @@ static void *consumer_thread( void *arg ) // Encode the image pkt.size = avcodec_encode_video( c, video_outbuf, video_outbuf_size, NULL ); + mlt_log_debug( MLT_CONSUMER_SERVICE( consumer ), "flushing video size %d\n", pkt.size ); if ( pkt.size <= 0 ) break; @@ -1285,32 +1630,37 @@ static void *consumer_thread( void *arg ) // write the compressed frame in the media file if ( av_interleaved_write_frame( oc, &pkt ) != 0 ) { - fprintf( stderr, "%s: Error while writing flushed video frame\n". __FILE__ ); - break; + mlt_log_fatal( MLT_CONSUMER_SERVICE(consumer), "error writing flushed video frame\n" ); + mlt_events_fire( properties, "consumer-fatal-error", NULL ); + goto on_fatal_error; } + // Dual pass logging + if ( mlt_properties_get_data( properties, "_logfile", NULL ) && c->stats_out ) + fprintf( mlt_properties_get_data( properties, "_logfile", NULL ), "%s", c->stats_out ); } } -#endif - - // close each codec - if (video_st) - close_video(oc, video_st); - if (audio_st) - close_audio(oc, audio_st); +on_fatal_error: + // Write the trailer, if any - av_write_trailer(oc); + av_write_trailer( oc ); + + // close each codec + if ( video_st ) + close_video(oc, video_st); + for ( i = 0; i < MAX_AUDIO_STREAMS && audio_st[i]; i++ ) + close_audio( oc, audio_st[i] ); // Free the streams - for(i = 0; i < oc->nb_streams; i++) - av_freep(&oc->streams[i]); + for ( i = 0; i < oc->nb_streams; i++ ) + av_freep( &oc->streams[i] ); // Close the output file - if (!(fmt->flags & AVFMT_NOFILE)) + if ( !( fmt->flags & AVFMT_NOFILE ) ) #if LIBAVFORMAT_VERSION_INT >= ((52<<16)+(0<<8)+0) - url_fclose(oc->pb); + url_fclose( oc->pb ); #else - url_fclose(&oc->pb); + url_fclose( &oc->pb ); #endif // Clean up input and output frames @@ -1320,17 +1670,19 @@ static void *consumer_thread( void *arg ) av_free( input->data[0] ); av_free( input ); av_free( video_outbuf ); - av_free( buffer ); + av_free( audio_buf_1 ); + av_free( audio_buf_2 ); // Free the stream - av_free(oc); + av_free( oc ); // Just in case we terminated on pause mlt_properties_set_int( properties, "running", 0 ); - mlt_consumer_stopped( this ); + mlt_consumer_stopped( consumer ); + mlt_properties_close( frame_meta_properties ); - if ( mlt_properties_get_int( properties, "pass" ) == 2 ) + if ( mlt_properties_get_int( properties, "pass" ) > 1 ) { // Remove the dual pass log file if ( mlt_properties_get( properties, "_logfilename" ) ) @@ -1348,6 +1700,11 @@ static void *consumer_thread( void *arg ) sprintf( full, "%s/%s", cwd, file ); remove( full ); free( full ); + file = "x264_2pass.log.mbtree"; + full = malloc( strlen( cwd ) + strlen( file ) + 2 ); + sprintf( full, "%s/%s", cwd, file ); + remove( full ); + free( full ); free( cwd ); remove( "x264_2pass.log.temp" ); } @@ -1358,14 +1715,14 @@ static void *consumer_thread( void *arg ) /** Close the consumer. */ -static void consumer_close( mlt_consumer this ) +static void consumer_close( mlt_consumer consumer ) { // Stop the consumer - mlt_consumer_stop( this ); + mlt_consumer_stop( consumer ); // Close the parent - mlt_consumer_close( this ); + mlt_consumer_close( consumer ); // Free the memory - free( this ); + free( consumer ); }