X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fmodules%2Fcore%2Ffilter_data_show.c;h=47f09f26645677737ca4297bc1ee95942c899f26;hb=3d2a637f044b478e962eaf704243b4c15529e67d;hp=73d7d778f243fcc6c599be29da3e8258de637955;hpb=b698c58e57643e9df6941d91b07a40c997bd7e64;p=mlt

diff --git a/src/modules/core/filter_data_show.c b/src/modules/core/filter_data_show.c
index 73d7d778..47f09f26 100644
--- a/src/modules/core/filter_data_show.c
+++ b/src/modules/core/filter_data_show.c
@@ -55,7 +55,10 @@ static mlt_filter obtain_filter( mlt_filter filter, char *type )
 		else if ( strchr( profile, '%' ) )
 			sprintf( temp, "%s/feeds/%s/%s", mlt_environment( "MLT_DATA" ), mlt_environment( "MLT_NORMALISATION" ), strchr( profile, '%' ) + 1 );
 		else
-			strcpy( temp, profile );
+		{
+			strncpy( temp, profile, sizeof( temp ) );
+			temp[ sizeof( temp ) - 1 ] = '\0';
+		}
 
 		// Load the specified profile or use the default
 		profile_properties = mlt_properties_load( temp );
@@ -207,7 +210,7 @@ static int process_feed( mlt_properties feed, mlt_filter filter, mlt_frame frame
 									// special case: replace #timecode# with current frame timecode
 									int pos = mlt_properties_get_int( feed, "position" );
 									char *tc = frame_to_timecode( pos, mlt_profile_fps( mlt_service_profile( MLT_FILTER_SERVICE( filter ) ) ) );
-									strcat( result, tc );
+									strncat( result, tc, sizeof( result ) - strlen( result ) - 1 );
 									free( tc );
 								}
 								else if ( !strcmp( keywords, "frame" ) )
@@ -216,13 +219,14 @@ static int process_feed( mlt_properties feed, mlt_filter filter, mlt_frame frame
 									int pos = mlt_properties_get_int( feed, "position" );
 									char s[12];
 									snprintf( s, sizeof(s) - 1, "%d", pos );
+									s[sizeof( s ) - 1] = '\0';
 									strcat( result, s );
 								}
 								else
 								{
 									// replace keyword with metadata value
 									char *metavalue = metadata_value( MLT_FRAME_PROPERTIES( frame ), keywords );
-									strcat( result, metavalue ? metavalue : "-" );
+									strncat( result, metavalue ? metavalue : "-", sizeof( result ) - strlen( result ) -1 );
 								}
 								keywords = strtok( NULL, "#" );
 								ct++;