X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fplaylist%2Fthread.c;h=b0d9be2c4aa8bebe43a9a2a06681de77a02d470a;hb=7fa10ce696573f2be5ba3684c7cdfa88021282f6;hp=fc9617aca3edf1dccb9c6918e61de49c9d25c66f;hpb=1ca4b2a3c4598a411ddbc8a2d8ff2b93e10e0c76;p=vlc diff --git a/src/playlist/thread.c b/src/playlist/thread.c index fc9617aca3..b0d9be2c4a 100644 --- a/src/playlist/thread.c +++ b/src/playlist/thread.c @@ -25,11 +25,14 @@ # include "config.h" #endif +#include + #include #include #include #include #include +#include #include "stream_output/stream_output.h" #include "playlist_internal.h" @@ -55,16 +58,6 @@ void playlist_Activate( playlist_t *p_playlist ) /* */ playlist_private_t *p_sys = pl_priv(p_playlist); - /* Fetcher */ - p_sys->p_fetcher = playlist_fetcher_New( p_playlist ); - if( !p_sys->p_fetcher ) - msg_Err( p_playlist, "cannot create playlist fetcher" ); - - /* Preparse */ - p_sys->p_preparser = playlist_preparser_New( p_playlist, p_sys->p_fetcher ); - if( !p_sys->p_preparser ) - msg_Err( p_playlist, "cannot create playlist preparser" ); - /* Start the playlist thread */ if( vlc_clone( &p_sys->thread, Thread, p_playlist, VLC_THREAD_PRIORITY_LOW ) ) @@ -81,34 +74,21 @@ void playlist_Deactivate( playlist_t *p_playlist ) msg_Dbg( p_playlist, "Deactivate" ); - vlc_object_kill( p_playlist ); PL_LOCK; + vlc_object_kill( p_playlist ); vlc_cond_signal( &p_sys->signal ); PL_UNLOCK; vlc_join( p_sys->thread, NULL ); assert( !p_sys->p_input ); - PL_LOCK; - playlist_preparser_t *p_preparser = p_sys->p_preparser; - playlist_fetcher_t *p_fetcher = p_sys->p_fetcher; - - p_sys->p_preparser = NULL; - p_sys->p_fetcher = NULL; - PL_UNLOCK; - - if( p_preparser ) - playlist_preparser_Delete( p_preparser ); - if( p_fetcher ) - playlist_fetcher_Delete( p_fetcher ); - /* release input resources */ if( p_sys->p_input_resource ) input_resource_Delete( p_sys->p_input_resource ); p_sys->p_input_resource = NULL; - /* */ - playlist_MLDump( p_playlist ); + if( var_InheritBool( p_playlist, "media-library" ) ) + playlist_MLDump( p_playlist ); PL_LOCK; @@ -207,13 +187,12 @@ static void ResetCurrentlyPlaying( playlist_t *p_playlist, PL_DEBUG("rebuild done - %i items, index %i", p_playlist->current.i_size, p_playlist->i_current_index); - if( var_GetBool( p_playlist, "random" ) ) + if( var_GetBool( p_playlist, "random" ) && ( p_playlist->current.i_size > 0 ) ) { /* Shuffle the array */ - srand( (unsigned int)mdate() ); - for( int j = p_playlist->current.i_size - 1; j > 0; j-- ) + for( unsigned j = p_playlist->current.i_size - 1; j > 0; j-- ) { - int i = rand() % (j+1); /* between 0 and j */ + unsigned i = ((unsigned)vlc_mrand48()) % (j+1); /* between 0 and j */ playlist_item_t *p_tmp; /* swap the two items */ p_tmp = ARRAY_VAL(p_playlist->current, i); @@ -251,14 +230,19 @@ static int PlayItem( playlist_t *p_playlist, playlist_item_t *p_item ) assert( p_sys->p_input == NULL ); - input_thread_t *p_input_thread = - input_CreateThreadExtended( p_playlist, p_input, NULL, p_sys->p_input_resource ); - + input_thread_t *p_input_thread = input_Create( p_playlist, p_input, NULL, p_sys->p_input_resource ); if( p_input_thread ) { p_sys->p_input = p_input_thread; - var_AddCallback( p_input_thread, "intf-event", InputEvent, p_playlist ); + + var_SetAddress( p_playlist, "input-current", p_input_thread ); + + if( input_Start( p_sys->p_input ) ) + { + vlc_object_release( p_input_thread ); + p_sys->p_input = p_input_thread = NULL; + } } p_sys->p_input_resource = NULL; @@ -287,14 +271,14 @@ static int PlayItem( playlist_t *p_playlist, playlist_item_t *p_item ) if( !b_has_art || strncmp( psz_arturl, "attachment://", 13 ) ) { PL_DEBUG( "requesting art for %s", psz_name ); - playlist_AskForArtEnqueue( p_playlist, p_input, pl_Locked ); + playlist_AskForArtEnqueue( p_playlist, p_input ); } free( psz_arturl ); free( psz_name ); } - + /* FIXME: this is not safe !!*/ PL_UNLOCK; - var_SetInteger( p_playlist, "item-current", p_input->i_id ); + var_SetAddress( p_playlist, "item-current", p_input ); PL_LOCK; return VLC_SUCCESS; @@ -473,7 +457,7 @@ static int LoopInput( playlist_t *p_playlist ) if( ( p_sys->request.b_request || !vlc_object_alive( p_playlist ) ) && !p_input->b_die ) { PL_DEBUG( "incoming request - stopping current input" ); - input_StopThread( p_input ); + input_Stop( p_input, true ); } /* This input is dead. Remove it ! */ @@ -514,7 +498,7 @@ static int LoopInput( playlist_t *p_playlist ) else if( p_input->b_error || p_input->b_eof ) { PL_DEBUG( "finished input" ); - input_StopThread( p_input ); + input_Stop( p_input, false ); } return VLC_SUCCESS; } @@ -552,8 +536,7 @@ static void LoopRequest( playlist_t *p_playlist ) else { if( vlc_object_alive( p_playlist ) ) - vlc_cond_wait( &pl_priv(p_playlist)->signal, - &vlc_internals(p_playlist)->lock ); + vlc_cond_wait( &p_sys->signal, &p_sys->lock ); } return; } @@ -584,7 +567,7 @@ static void *Thread ( void *data ) playlist_t *p_playlist = data; playlist_private_t *p_sys = pl_priv(p_playlist); - vlc_object_lock( p_playlist ); + playlist_Lock( p_playlist ); while( vlc_object_alive( p_playlist ) || p_sys->p_input ) { /* FIXME: what's that ! */ @@ -598,12 +581,11 @@ static void *Thread ( void *data ) /* If there is an input, check that it doesn't need to die. */ while( !LoopInput( p_playlist ) ) - vlc_cond_wait( &pl_priv(p_playlist)->signal, - &vlc_internals(p_playlist)->lock ); + vlc_cond_wait( &p_sys->signal, &p_sys->lock ); LoopRequest( p_playlist ); } - vlc_object_unlock( p_playlist ); + playlist_Unlock( p_playlist ); return NULL; }