X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fslideshowclip.cpp;h=c4c88cdaea75d6c6e84c8a23a7eb7a7a44400ac8;hb=c3302003093710ee247ad84c0fe2ef3c579d417f;hp=eb203f13fc07bb092900393a81793cc3eba7e234;hpb=32c8c40056e65b230f058b168e8e078ba066038b;p=kdenlive

diff --git a/src/slideshowclip.cpp b/src/slideshowclip.cpp
index eb203f13..c4c88cda 100644
--- a/src/slideshowclip.cpp
+++ b/src/slideshowclip.cpp
@@ -28,7 +28,7 @@
 #include <QDir>
 
 
-SlideshowClip::SlideshowClip(Timecode tc, QWidget * parent) :
+SlideshowClip::SlideshowClip(const Timecode &tc, QWidget * parent) :
     QDialog(parent),
     m_count(0),
     m_timecode(tc),
@@ -112,9 +112,7 @@ SlideshowClip::SlideshowClip(Timecode tc, QWidget * parent) :
 
 SlideshowClip::~SlideshowClip()
 {
-    if (m_thumbJob) {
-        delete m_thumbJob;
-    }
+    delete m_thumbJob;
 }
 
 void SlideshowClip::slotEnableLuma(int state)
@@ -192,7 +190,7 @@ void SlideshowClip::parseFolder()
         int firstFrame = m_view.pattern_url->url().fileName().section('.', 0, -2).right(precision).toInt();
         QString path;
         int gap = 0;
-        for (int i = firstFrame; gap < 100; i++) {
+        for (int i = firstFrame; gap < 100; ++i) {
             path = filter + QString::number(i).rightJustified(precision, '0', false) + ext;
             if (dir.exists(path)) {
                 result.append(path);
@@ -221,7 +219,7 @@ void SlideshowClip::slotGenerateThumbs()
         delete m_thumbJob;
     };
     KFileItemList fileList;
-    for (int i = 0; i < m_view.icon_list->count(); i++) {
+    for (int i = 0; i < m_view.icon_list->count(); ++i) {
         QListWidgetItem* item = m_view.icon_list->item(i);
         if (item) {
             QString path = item->data(Qt::UserRole).toString();
@@ -244,7 +242,7 @@ void SlideshowClip::slotGenerateThumbs()
 
 void SlideshowClip::slotSetPixmap(const KFileItem &fileItem, const QPixmap &pix)
 {
-    for (int i = 0; i < m_view.icon_list->count(); i++) {
+    for (int i = 0; i < m_view.icon_list->count(); ++i) {
         QListWidgetItem* item = m_view.icon_list->item(i);
         if (item) {
             QString path = item->data(Qt::UserRole).toString();
@@ -271,7 +269,7 @@ QString SlideshowClip::selectedPath()
 }
 
 // static
-int SlideshowClip::getFrameNumberFromPath(KUrl path)
+int SlideshowClip::getFrameNumberFromPath(const KUrl &path)
 {
     QString filter = path.fileName();
     filter = filter.section('.', 0, -2);
@@ -283,7 +281,7 @@ int SlideshowClip::getFrameNumberFromPath(KUrl path)
 }
 
 // static
-QString SlideshowClip::selectedPath(KUrl url, bool isMime, QString extension, QStringList *list)
+QString SlideshowClip::selectedPath(const KUrl &url, bool isMime, QString extension, QStringList *list)
 {
     QString folder;
     if (isMime) {
@@ -314,7 +312,7 @@ QString SlideshowClip::selectedPath(KUrl url, bool isMime, QString extension, QS
         QDir dir(folder);
         QString path;
         int gap = 0;
-        for (int i = firstFrame; gap < 100; i++) {
+        for (int i = firstFrame; gap < 100; ++i) {
             path = filter + QString::number(i).rightJustified(precision, '0', false) + ext;
             if (dir.exists(path)) {
                 (*list).append(folder + path);