X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fstream_output%2Fstream_output.c;h=93267f7958dc68508c89c7c8bc6b2ba247c68b81;hb=6da90a1716250d282f16dc6bc9dacec5b9514caf;hp=61e911f06394f7f36683954ec4e7e5f53a452021;hpb=99fab9089e9e1709d9c3a4bc5ced0c137ac59134;p=vlc diff --git a/src/stream_output/stream_output.c b/src/stream_output/stream_output.c index 61e911f063..93267f7958 100644 --- a/src/stream_output/stream_output.c +++ b/src/stream_output/stream_output.c @@ -52,7 +52,7 @@ *****************************************************************************/ #define sout_stream_url_to_chain( p, s ) \ _sout_stream_url_to_chain( VLC_OBJECT(p), s ) -static char *_sout_stream_url_to_chain( vlc_object_t *, char * ); +static char *_sout_stream_url_to_chain( vlc_object_t *, const char * ); /* * Generic MRL parser @@ -92,7 +92,7 @@ sout_instance_t *__sout_NewInstance( vlc_object_t *p_parent, char * psz_dest ) p_sout->i_out_pace_nocontrol = 0; p_sout->p_sys = NULL; - vlc_mutex_init( p_sout, &p_sout->lock ); + vlc_mutex_init( &p_sout->lock ); if( psz_dest && psz_dest[0] == '#' ) { p_sout->psz_chain = strdup( &psz_dest[1] ); @@ -120,7 +120,7 @@ sout_instance_t *__sout_NewInstance( vlc_object_t *p_parent, char * psz_dest ) FREENULL( p_sout->psz_chain ); vlc_object_detach( p_sout ); - vlc_object_destroy( p_sout ); + vlc_object_release( p_sout ); return NULL; } @@ -148,7 +148,7 @@ void sout_DeleteInstance( sout_instance_t * p_sout ) vlc_mutex_destroy( &p_sout->lock ); /* *** free structure *** */ - vlc_object_destroy( p_sout ); + vlc_object_release( p_sout ); } /***************************************************************************** @@ -212,13 +212,13 @@ sout_packetizer_input_t *sout_InputNew( sout_instance_t *p_sout, { sout_packetizer_input_t *p_input; - msg_Dbg( p_sout, "adding a new input" ); - /* *** create a packetizer input *** */ p_input = malloc( sizeof( sout_packetizer_input_t ) ); p_input->p_sout = p_sout; p_input->p_fmt = p_fmt; + msg_Dbg( p_sout, "adding a new sout input (sout_input:%p)", p_input ); + if( p_fmt->i_codec == VLC_FOURCC( 'n', 'u', 'l', 'l' ) ) { vlc_object_release( p_sout ); @@ -246,7 +246,7 @@ int sout_InputDelete( sout_packetizer_input_t *p_input ) { sout_instance_t *p_sout = p_input->p_sout; - msg_Dbg( p_sout, "removing an input" ); + msg_Dbg( p_sout, "removing a sout input (sout_input:%p)", p_input ); if( p_input->p_fmt->i_codec != VLC_FOURCC( 'n', 'u', 'l', 'l' ) ) { @@ -307,10 +307,7 @@ sout_access_out_t *sout_AccessOutNew( sout_instance_t *p_sout, psz_next = config_ChainCreate( &p_access->psz_access, &p_access->p_cfg, psz_access ); - if( psz_next ) - { - free( psz_next ); - } + free( psz_next ); p_access->psz_path = strdup( psz_name ? psz_name : "" ); p_access->p_sout = p_sout; p_access->p_sys = NULL; @@ -326,14 +323,14 @@ sout_access_out_t *sout_AccessOutNew( sout_instance_t *p_sout, vlc_object_attach( p_access, p_sout ); p_access->p_module = - module_Need( p_access, "sout access", p_access->psz_access, VLC_TRUE ); + module_Need( p_access, "sout access", p_access->psz_access, true ); if( !p_access->p_module ) { free( p_access->psz_access ); free( p_access->psz_path ); vlc_object_detach( p_access ); - vlc_object_destroy( p_access ); + vlc_object_release( p_access ); return( NULL ); } @@ -355,7 +352,7 @@ void sout_AccessOutDelete( sout_access_out_t *p_access ) free( p_access->psz_path ); - vlc_object_destroy( p_access ); + vlc_object_release( p_access ); } /***************************************************************************** @@ -419,7 +416,7 @@ sout_mux_t * sout_MuxNew( sout_instance_t *p_sout, char *psz_mux, p_mux->p_sout = p_sout; psz_next = config_ChainCreate( &p_mux->psz_mux, &p_mux->p_cfg, psz_mux ); - if( psz_next ) free( psz_next ); + free( psz_next ); p_mux->p_access = p_access; p_mux->pf_control = NULL; @@ -432,58 +429,58 @@ sout_mux_t * sout_MuxNew( sout_instance_t *p_sout, char *psz_mux, p_mux->p_sys = NULL; p_mux->p_module = NULL; - p_mux->b_add_stream_any_time = VLC_FALSE; - p_mux->b_waiting_stream = VLC_TRUE; + p_mux->b_add_stream_any_time = false; + p_mux->b_waiting_stream = true; p_mux->i_add_stream_start = -1; vlc_object_attach( p_mux, p_sout ); p_mux->p_module = - module_Need( p_mux, "sout mux", p_mux->psz_mux, VLC_TRUE ); + module_Need( p_mux, "sout mux", p_mux->psz_mux, true ); if( p_mux->p_module == NULL ) { FREENULL( p_mux->psz_mux ); vlc_object_detach( p_mux ); - vlc_object_destroy( p_mux ); + vlc_object_release( p_mux ); return NULL; } /* *** probe mux capacity *** */ if( p_mux->pf_control ) { - int b_answer = VLC_FALSE; + int b_answer = false; if( sout_MuxControl( p_mux, MUX_CAN_ADD_STREAM_WHILE_MUXING, &b_answer ) ) { - b_answer = VLC_FALSE; + b_answer = false; } if( b_answer ) { msg_Dbg( p_sout, "muxer support adding stream at any time" ); - p_mux->b_add_stream_any_time = VLC_TRUE; - p_mux->b_waiting_stream = VLC_FALSE; + p_mux->b_add_stream_any_time = true; + p_mux->b_waiting_stream = false; /* If we control the output pace then it's better to wait before * starting muxing (generates better streams/files). */ if( !p_sout->i_out_pace_nocontrol ) { - b_answer = VLC_TRUE; + b_answer = true; } else if( sout_MuxControl( p_mux, MUX_GET_ADD_STREAM_WAIT, &b_answer ) ) { - b_answer = VLC_FALSE; + b_answer = false; } if( b_answer ) { msg_Dbg( p_sout, "muxer prefers to wait for all ES before " "starting to mux" ); - p_mux->b_waiting_stream = VLC_TRUE; + p_mux->b_waiting_stream = true; } } } @@ -505,7 +502,7 @@ void sout_MuxDelete( sout_mux_t *p_mux ) config_ChainDestroy( p_mux->p_cfg ); - vlc_object_destroy( p_mux ); + vlc_object_release( p_mux ); } /***************************************************************************** @@ -526,19 +523,24 @@ sout_input_t *sout_MuxAddStream( sout_mux_t *p_mux, es_format_t *p_fmt ) /* create a new sout input */ p_input = malloc( sizeof( sout_input_t ) ); + if( !p_input ) + { + msg_Err( p_mux, "out of memory" ); + return NULL; + } p_input->p_sout = p_mux->p_sout; p_input->p_fmt = p_fmt; - p_input->p_fifo = block_FifoNew( p_mux->p_sout ); + p_input->p_fifo = block_FifoNew(); p_input->p_sys = NULL; TAB_APPEND( p_mux->i_nb_inputs, p_mux->pp_inputs, p_input ); if( p_mux->pf_addstream( p_mux, p_input ) < 0 ) { - msg_Err( p_mux, "cannot add this stream" ); - TAB_REMOVE( p_mux->i_nb_inputs, p_mux->pp_inputs, p_input ); - block_FifoRelease( p_input->p_fifo ); - free( p_input ); - return NULL; + msg_Err( p_mux, "cannot add this stream" ); + TAB_REMOVE( p_mux->i_nb_inputs, p_mux->pp_inputs, p_input ); + block_FifoRelease( p_input->p_fifo ); + free( p_input ); + return NULL; } return p_input; @@ -556,7 +558,7 @@ void sout_MuxDeleteStream( sout_mux_t *p_mux, sout_input_t *p_input ) { /* We stop waiting, and call the muxer for taking care of the data * before we remove this es */ - p_mux->b_waiting_stream = VLC_FALSE; + p_mux->b_waiting_stream = false; p_mux->pf_mux( p_mux ); } @@ -593,13 +595,13 @@ void sout_MuxSendBuffer( sout_mux_t *p_mux, sout_input_t *p_input, { mtime_t current_date = mdate(); if ( current_date > p_buffer->i_dts ) - msg_Warn( p_mux, "late buffer for mux input ("I64Fd")", + msg_Warn( p_mux, "late buffer for mux input (%"PRId64")", current_date - p_buffer->i_dts ); } if( p_mux->b_waiting_stream ) { - const int64_t i_caching = var_GetInteger( p_mux->p_sout, "sout-mux-caching" ) * I64C(1000); + const int64_t i_caching = var_GetInteger( p_mux->p_sout, "sout-mux-caching" ) * INT64_C(1000); if( p_mux->i_add_stream_start < 0 ) p_mux->i_add_stream_start = p_buffer->i_dts; @@ -608,7 +610,7 @@ void sout_MuxSendBuffer( sout_mux_t *p_mux, sout_input_t *p_input, if( p_mux->i_add_stream_start < 0 || p_buffer->i_dts < p_mux->i_add_stream_start + i_caching ) return; - p_mux->b_waiting_stream = VLC_FALSE; + p_mux->b_waiting_stream = false; } p_mux->pf_mux( p_mux ); } @@ -827,7 +829,7 @@ sout_stream_t *sout_StreamNew( sout_instance_t *p_sout, char *psz_chain ) vlc_object_attach( p_stream, p_sout ); p_stream->p_module = - module_Need( p_stream, "sout stream", p_stream->psz_name, VLC_TRUE ); + module_Need( p_stream, "sout stream", p_stream->psz_name, true ); if( !p_stream->p_module ) { @@ -851,32 +853,52 @@ void sout_StreamDelete( sout_stream_t *p_stream ) config_ChainDestroy( p_stream->p_cfg ); msg_Dbg( p_stream, "destroying chain done" ); - vlc_object_destroy( p_stream ); + vlc_object_release( p_stream ); } -static char *_sout_stream_url_to_chain( vlc_object_t *p_this, char *psz_url ) +static char *_sout_stream_url_to_chain( vlc_object_t *p_this, + const char *psz_url ) { mrl_t mrl; - char *psz_chain, *p; + char *psz_chain; + const char *fmt = "standard{mux=\"%s\",access=\"%s\",dst=\"%s\"}"; + static const char rtpfmt[] = "rtp{mux=\"%s\",proto=\"%s\",dst=\"%s\"}"; mrl_Parse( &mrl, psz_url ); - p = psz_chain = malloc( 500 + strlen( mrl.psz_way ) + - strlen( mrl.psz_access ) + - strlen( mrl.psz_name ) ); - - if( config_GetInt( p_this, "sout-display" ) ) + /* Check if the URLs goes #rtp - otherwise we'll use #standard */ + if (strcmp (mrl.psz_access, "rtp") == 0) { - p += sprintf( p, "duplicate{dst=display,dst=std{mux=\"%s\"," - "access=\"%s\",dst=\"%s\"}}", - mrl.psz_way, mrl.psz_access, mrl.psz_name ); + /* For historical reasons, rtp:// means RTP over UDP */ + strcpy (mrl.psz_access, "udp"); + fmt = rtpfmt; } else { - p += sprintf( p, "std{mux=\"%s\",access=\"%s\",dst=\"%s\"}", - mrl.psz_way, mrl.psz_access, mrl.psz_name ); + static const char list[] = "dccp\0sctp\0tcp\0udplite\0"; + for (const char *a = list; *a; a += strlen (a) + 1) + if (strcmp (a, mrl.psz_access) == 0) + { + fmt = rtpfmt; + break; + } + } + + /* Convert the URL to a basic sout chain */ + if (asprintf (&psz_chain, fmt, + mrl.psz_way, mrl.psz_access, mrl.psz_name) == -1) + psz_chain = NULL; + + /* Duplicate and wrap if sout-display is on */ + if (psz_chain && (config_GetInt( p_this, "sout-display" ) > 0)) + { + char *tmp; + if (asprintf (&tmp, "duplicate{dst=display,dst=%s}", tmp) == -1) + tmp = NULL; + free (psz_chain); + psz_chain = tmp; } mrl_Clean( &mrl ); - return( psz_chain ); + return psz_chain; }