X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Ftransition.cpp;h=35982a1c182ada216b9d07078fe12c49f6cfcf11;hb=e0fa1332f109b6455207ea701da386b2fddddf09;hp=ecdd7086ac2c1b9179e6089cba53f432527257bc;hpb=f3d9d916c7df8860f70a91645577c9590d08d36e;p=kdenlive

diff --git a/src/transition.cpp b/src/transition.cpp
index ecdd7086..35982a1c 100644
--- a/src/transition.cpp
+++ b/src/transition.cpp
@@ -33,7 +33,7 @@
 #include <QPropertyAnimation>
 #endif
 
-Transition::Transition(const ItemInfo &info, int transitiontrack, double fps, QDomElement params, bool automaticTransition) :
+Transition::Transition(const ItemInfo &info, int transitiontrack, double fps, const QDomElement &params, bool automaticTransition) :
         AbstractClipItem(info, QRectF(), fps),
         m_forceTransitionTrack(false),
         m_automaticTransition(automaticTransition),
@@ -238,7 +238,7 @@ QVariant Transition::itemChange(GraphicsItemChange change, const QVariant &value
         bool forwardMove = newPos.x() > pos().x();
         int offset = 0;
         if (!items.isEmpty()) {
-            for (int i = 0; i < items.count(); i++) {
+            for (int i = 0; i < items.count(); ++i) {
                 if (!items.at(i)->isEnabled()) continue;
                 if (items.at(i)->type() == type()) {
                     // Collision!
@@ -331,7 +331,7 @@ QDomElement Transition::toXML()
 bool Transition::hasGeometry()
 {
     QDomNodeList namenode = m_parameters.elementsByTagName("parameter");
-    for (int i = 0; i < namenode.count() ; i++) {
+    for (int i = 0; i < namenode.count() ; ++i) {
         QDomElement pa = namenode.item(i).toElement();
         if (pa.attribute("type") == "geometry") return true;
     }
@@ -349,7 +349,7 @@ bool Transition::updateKeyframes(int oldEnd)
     QDomElement pa;
     bool modified = false;
     QDomNodeList namenode = m_parameters.elementsByTagName("parameter");
-    for (int i = 0; i < namenode.count() ; i++) {
+    for (int i = 0; i < namenode.count() ; ++i) {
         pa = namenode.item(i).toElement();
         if (pa.attribute("type") == "geometry") {
             keyframes = pa.attribute("value");
@@ -365,7 +365,7 @@ bool Transition::updateKeyframes(int oldEnd)
 	// Transition was expanded, check if we had a keyframe at end position
 	foreach(QString pos, values) {
 	    if (!pos.contains('=')) {
-		i++;
+		++i;
 		continue;
 	    }
 	    frame = pos.section('=', 0, 0).toInt();
@@ -375,7 +375,7 @@ bool Transition::updateKeyframes(int oldEnd)
 		pa.setAttribute("value", values.join(";"));
 		return true;
 	    }
-	    i++;
+	    ++i;
 	}
 	return false;
     }
@@ -383,7 +383,7 @@ bool Transition::updateKeyframes(int oldEnd)
 	// Transition was shortened, check for out of bounds keyframes
 	foreach(const QString &pos, values) {
 	    if (!pos.contains('=')) {
-		i++;
+		++i;
 		continue;
 	    }
 	    frame = pos.section('=', 0, 0).toInt();
@@ -391,7 +391,7 @@ bool Transition::updateKeyframes(int oldEnd)
 		modified = true;
 		break;
 	    }
-	    i++;
+	    ++i;
 	}
     }
     if (modified) {