X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=src%2Fvlc.c;h=c884610acb7e4070184e6767f06b29af4b4dab16;hb=27348412c7a6a11136921b9daa5243ae0746fd28;hp=67e9a19b5c32b2a00a51499754d0c1f404711e82;hpb=c59fd2bb91a48cec804943d955062ac1098f0627;p=vlc diff --git a/src/vlc.c b/src/vlc.c index 67e9a19b5c..c884610acb 100644 --- a/src/vlc.c +++ b/src/vlc.c @@ -22,27 +22,38 @@ * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111, USA. + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA. *****************************************************************************/ #include "config.h" -#include /* fprintf() */ -#include /* putenv(), strtol(), */ -#ifdef HAVE_SIGNAL_H -# include /* SIGHUP, SIGINT, SIGKILL */ -#endif -#ifdef HAVE_TIME_H -# include /* time() */ -#endif - #include +#include +#include +#include + + +/* Explicit HACK */ +extern void LocaleFree (const char *); +extern char *FromLocale (const char *); + /***************************************************************************** * Local prototypes. *****************************************************************************/ -#if !defined(WIN32) && !defined(UNDER_CE) -static void SigHandler ( int i_signal ); +#ifdef WIN32 +#include +extern void __wgetmainargs(int *argc, wchar_t ***wargv, wchar_t ***wenviron, + int expand_wildcards, int *startupinfo); +static inline void Kill(void) { } +#else + +# include +# include +# include + +static void Kill (void); +static void *SigHandler (void *set); #endif /***************************************************************************** @@ -52,7 +63,9 @@ int main( int i_argc, char *ppsz_argv[] ) { int i_ret; -#ifndef SYS_DARWIN + setlocale (LC_ALL, ""); + +#ifndef __APPLE__ /* This clutters OSX GUI error logs */ fprintf( stderr, "VLC media player %s\n", VLC_Version() ); #endif @@ -60,46 +73,128 @@ int main( int i_argc, char *ppsz_argv[] ) #ifdef HAVE_PUTENV # ifdef DEBUG /* Activate malloc checking routines to detect heap corruptions. */ - putenv( "MALLOC_CHECK_=2" ); + putenv( (char*)"MALLOC_CHECK_=2" ); /* Disable the ugly Gnome crash dialog so that we properly segfault */ - putenv( "GNOME_DISABLE_CRASH_DIALOG=1" ); + putenv( (char *)"GNOME_DISABLE_CRASH_DIALOG=1" ); # endif /* If the user isn't using VLC_VERBOSE, set it to 0 by default */ if( getenv( "VLC_VERBOSE" ) == NULL ) { - putenv( "VLC_VERBOSE=0" ); + putenv( (char *)"VLC_VERBOSE=0" ); } #endif +#if defined (HAVE_GETEUID) && !defined (SYS_BEOS) + /* FIXME: rootwrap (); */ +#endif + /* Create a libvlc structure */ i_ret = VLC_Create(); if( i_ret < 0 ) { - return i_ret; + return -i_ret; } #if !defined(WIN32) && !defined(UNDER_CE) - /* Set the signal handlers. SIGTERM is not intercepted, because we need at - * least one method to kill the program when all other methods failed, and - * when we don't want to use SIGKILL. + /* Synchronously intercepted POSIX signals. + * + * In a threaded program such as VLC, the only sane way to handle signals + * is to block them in all thread but one - this is the only way to + * predict which thread will receive them. If any piece of code depends + * on delivery of one of this signal it is intrinsically not thread-safe + * and MUST NOT be used in VLC, whether we like it or not. + * There is only one exception: if the signal is raised with + * pthread_kill() - we do not use this in LibVLC but some pthread + * implementations use them internally. You should really use conditions + * for thread synchronization anyway. + * + * Signal that request a clean shutdown, and force an unclean shutdown + * if they are triggered again 2+ seconds later. + * We have to handle SIGTERM cleanly because of daemon mode. * Note that we set the signals after the vlc_create call. */ - signal( SIGINT, SigHandler ); - signal( SIGHUP, SigHandler ); - signal( SIGQUIT, SigHandler ); + static const int exitsigs[] = { SIGINT, SIGHUP, SIGQUIT, SIGTERM }; + /* Signals that cause a no-op: + * - SIGALRM should not happen, but lets stay on the safe side. + * - SIGPIPE might happen with sockets and would crash VLC. It MUST be + * blocked by any LibVLC-dependant application, in addition to VLC. + * - SIGCHLD is comes after exec*() (such as httpd CGI support) and must + * be dequeued to cleanup zombie processes. + */ + static const int dummysigs[] = { SIGALRM, SIGPIPE, SIGCHLD }; + + sigset_t set; + pthread_t sigth; + + sigemptyset (&set); + for (unsigned i = 0; i < sizeof (exitsigs) / sizeof (exitsigs[0]); i++) + sigaddset (&set, exitsigs[i]); + for (unsigned i = 0; i < sizeof (dummysigs) / sizeof (dummysigs[0]); i++) + sigaddset (&set, dummysigs[i]); + + /* Block all these signals */ + pthread_sigmask (SIG_BLOCK, &set, NULL); + + for (unsigned i = 0; i < sizeof (dummysigs) / sizeof (dummysigs[0]); i++) + sigdelset (&set, dummysigs[i]); - /* Other signals */ - signal( SIGALRM, SIG_IGN ); - signal( SIGPIPE, SIG_IGN ); + pthread_create (&sigth, NULL, SigHandler, &set); +#endif + +#ifdef WIN32 + /* Replace argv[1..n] with unicode for Windows NT and above */ + if( GetVersion() < 0x80000000 ) + { + wchar_t **wargv, **wenvp; + int i,i_wargc; + int si = { 0 }; + __wgetmainargs(&i_wargc, &wargv, &wenvp, 0, &si); + + for( i = 0; i < i_wargc; i++ ) + { + int len = WideCharToMultiByte(CP_UTF8, 0, wargv[i], -1, NULL, 0, NULL, NULL); + if( len > 0 ) + { + if( len > 1 ) { + char *utf8arg = (char *)malloc(len); + if( NULL != utf8arg ) + { + WideCharToMultiByte(CP_UTF8, 0, wargv[i], -1, utf8arg, len, NULL, NULL); + ppsz_argv[i] = utf8arg; + } + else + { + /* failed!, quit */ + return 1; + } + } + else + { + ppsz_argv[i] = strdup (""); + } + } + else + { + /* failed!, quit */ + return 1; + } + } + } + else #endif + { + for (int i = 0; i < i_argc; i++) + if ((ppsz_argv[i] = FromLocale (ppsz_argv[i])) == NULL) + return 1; // BOOM! + } /* Initialize libvlc */ i_ret = VLC_Init( 0, i_argc, ppsz_argv ); if( i_ret < 0 ) { VLC_Destroy( 0 ); - return i_ret == VLC_EEXITSUCCESS ? 0 : i_ret; + return i_ret == VLC_EEXITSUCCESS ? 0 : -i_ret; } i_ret = VLC_AddIntf( 0, NULL, VLC_TRUE, VLC_TRUE ); @@ -107,53 +202,98 @@ int main( int i_argc, char *ppsz_argv[] ) /* Finish the threads */ VLC_CleanUp( 0 ); + Kill (); + /* Destroy the libvlc structure */ VLC_Destroy( 0 ); - return i_ret; + for (int i = 0; i < i_argc; i++) + LocaleFree (ppsz_argv[i]); + +#if !defined(WIN32) && !defined(UNDER_CE) + pthread_cancel (sigth); +# ifdef __APPLE__ + /* In Mac OS X up to 10.4.8 sigwait (among others) is not a pthread + * cancellation point, so we throw a dummy quit signal to end + * sigwait() in the sigth thread */ + pthread_kill (sigth, SIGQUIT); +# endif + pthread_join (sigth, NULL); +#endif + + return -i_ret; } #if !defined(WIN32) && !defined(UNDER_CE) /***************************************************************************** * SigHandler: system signal handler ***************************************************************************** - * This function is called when a fatal signal is received by the program. + * This thread receives all handled signals synchronously. * It tries to end the program in a clean way. *****************************************************************************/ -static void SigHandler( int i_signal ) +static void *SigHandler (void *data) { - static time_t abort_time = 0; - static volatile vlc_bool_t b_die = VLC_FALSE; + const sigset_t *exitset = (sigset_t *)data; + sigset_t fullset; + time_t abort_time = 0; - /* Once a signal has been trapped, the termination sequence will be - * armed and subsequent signals will be ignored to avoid sending signals - * to a libvlc structure having been destroyed */ + pthread_sigmask (SIG_BLOCK, exitset, &fullset); - if( !b_die ) + for (;;) { - b_die = VLC_TRUE; - abort_time = time( NULL ); + int i_signal, state; + (void)sigwait (&fullset, &i_signal); - fprintf( stderr, "signal %d received, terminating vlc - do it " - "again in case it gets stuck\n", i_signal ); +#ifdef __APPLE__ + /* In Mac OS X up to 10.4.8 sigwait (among others) is not a pthread + * cancellation point */ + pthread_testcancel(); +#endif - /* Acknowledge the signal received */ - VLC_Die( 0 ); - } - else if( time( NULL ) > abort_time + 2 ) - { - /* If user asks again 1 or 2 seconds later, die badly */ - signal( SIGINT, SIG_DFL ); - signal( SIGHUP, SIG_DFL ); - signal( SIGQUIT, SIG_DFL ); - signal( SIGALRM, SIG_DFL ); - signal( SIGPIPE, SIG_DFL ); + if (!sigismember (exitset, i_signal)) + continue; /* Ignore "dummy" signals */ - fprintf( stderr, "user insisted too much, dying badly\n" ); + /* Once a signal has been trapped, the termination sequence will be + * armed and subsequent signals will be ignored to avoid sending + * signals to a libvlc structure having been destroyed */ - abort(); + pthread_setcancelstate (PTHREAD_CANCEL_DISABLE, &state); + if (abort_time == 0) + { + time (&abort_time); + abort_time += 2; + + fprintf (stderr, "signal %d received, terminating vlc - do it " + "again in case it gets stuck\n", i_signal); + + /* Acknowledge the signal received */ + Kill (); + } + else + if (time (NULL) <= abort_time) + { + /* If user asks again more than 2 seconds later, die badly */ + pthread_sigmask (SIG_UNBLOCK, exitset, NULL); + fprintf (stderr, "user insisted too much, dying badly\n"); + abort (); + } + pthread_setcancelstate (state, NULL); } + /* Never reached */ +} + + +static void KillOnce (void) +{ + VLC_Die (0); } + +static void Kill (void) +{ + static pthread_once_t once = PTHREAD_ONCE_INIT; + pthread_once (&once, KillOnce); +} + #endif #if defined(UNDER_CE)