X-Git-Url: https://git.sesse.net/?a=blobdiff_plain;f=updatedb.cpp;h=8d524c6872038b4c72829de3d12cbb354f6fc760;hb=4f01649b82aca67fe3f5bf0192cf25c6903282fa;hp=17067b8d0d10e705048f7d76ab2cc0081a94027e;hpb=654a776cf218202dd10ccfba8f0be46016b1edde;p=plocate

diff --git a/updatedb.cpp b/updatedb.cpp
index 17067b8..8d524c6 100644
--- a/updatedb.cpp
+++ b/updatedb.cpp
@@ -92,7 +92,11 @@ int opendir_noatime(int dirfd, const char *path)
 	static bool noatime_failed = false;
 
 	if (!noatime_failed) {
+#ifdef O_NOATIME
 		int fd = openat(dirfd, path, O_RDONLY | O_DIRECTORY | O_NOATIME);
+#else
+		int fd = openat(dirfd, path, O_RDONLY | O_DIRECTORY);
+#endif
 		if (fd != -1) {
 			return fd;
 		} else if (errno == EPERM) {
@@ -526,7 +530,7 @@ string ExistingDB::read_next_dictionary() const
 // “parent_dev” must be the device of the parent directory of “path”.
 //
 // Takes ownership of fd.
-int scan(const string &path, int fd, dev_t parent_dev, dir_time modified, dir_time db_modified, ExistingDB *existing_db, Corpus *corpus, DictionaryBuilder *dict_builder)
+int scan(const string &path, int fd, dev_t parent_dev, dir_time modified, dir_time db_modified, ExistingDB *existing_db, DatabaseReceiver *corpus, DictionaryBuilder *dict_builder)
 {
 	if (string_list_contains_dir_path(&conf_prunepaths, &conf_prunepaths_index, path)) {
 		if (conf_debug_pruning) {
@@ -624,7 +628,23 @@ int scan(const string &path, int fd, dev_t parent_dev, dir_time modified, dir_ti
 
 			entry e;
 			e.name = de->d_name;
-			e.is_directory = (de->d_type == DT_DIR);
+			if (de->d_type == DT_UNKNOWN) {
+				// Evidently some file systems, like older versions of XFS
+				// (mkfs.xfs -m crc=0 -n ftype=0), can return this,
+				// and we need a stat(). If we wanted to optimize for this,
+				// we could probably defer it to later (we're stat-ing directories
+				// when recursing), but this is rare, and not really worth it --
+				// the second stat() will be cached anyway.
+				struct stat buf;
+				if (fstatat(fd, de->d_name, &buf, AT_SYMLINK_NOFOLLOW) == 0 &&
+				    S_ISDIR(buf.st_mode)) {
+					e.is_directory = true;
+				} else {
+					e.is_directory = false;
+				}
+			} else {
+				e.is_directory = (de->d_type == DT_DIR);
+			}
 
 			if (conf_verbose) {
 				printf("%s/%s\n", path.c_str(), de->d_name);
@@ -778,7 +798,7 @@ int main(int argc, char **argv)
 
 	DatabaseBuilder db(conf_output.c_str(), owner, conf_block_size, existing_db.read_next_dictionary(), conf_check_visibility);
 	db.set_conf_block(conf_block);
-	Corpus *corpus = db.start_corpus(/*store_dir_times=*/true);
+	DatabaseReceiver *corpus = db.start_corpus(/*store_dir_times=*/true);
 
 	int root_fd = opendir_noatime(AT_FDCWD, conf_scan_root);
 	if (root_fd == -1) {