From: Rémi Duraffort <ivoire@videolan.org>
Date: Wed, 13 Feb 2008 00:14:37 +0000 (+0000)
Subject: Check asprintf return value.
X-Git-Tag: 0.9.0-test0~2677
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;ds=sidebyside;h=1c4de827a688d2b8198c9ff603be0d1dd2f89bb4;p=vlc

Check asprintf return value.
---

diff --git a/src/misc/update.c b/src/misc/update.c
index 8a2e9b34cd..b85a9cda42 100644
--- a/src/misc/update.c
+++ b/src/misc/update.c
@@ -1178,15 +1178,17 @@ int update_CompareReleaseToCurrent( update_t *p_update )
 static char *size_str( long int l_size )
 {
     char *psz_tmp = NULL;
+    int i_retval = 0;
     if( l_size >> 30 )
-        asprintf( &psz_tmp, "%.1f GB", (float)l_size/(1<<30) );
+        i_retval = asprintf( &psz_tmp, "%.1f GB", (float)l_size/(1<<30) );
     else if( l_size >> 20 )
-        asprintf( &psz_tmp, "%.1f MB", (float)l_size/(1<<20) );
+        i_retval = asprintf( &psz_tmp, "%.1f MB", (float)l_size/(1<<20) );
     else if( l_size >> 10 )
-        asprintf( &psz_tmp, "%.1f kB", (float)l_size/(1<<10) );
+        i_retval = asprintf( &psz_tmp, "%.1f kB", (float)l_size/(1<<10) );
     else
-        asprintf( &psz_tmp, "%ld B", l_size );
-    return psz_tmp;
+        i_retval = asprintf( &psz_tmp, "%ld B", l_size );
+
+    return i_retval == -1 ? NULL : psz_tmp;
 }