From: Jean-Baptiste Mardelle Date: Fri, 9 Sep 2011 23:47:12 +0000 (+0000) Subject: cppcheck fixes, patch by Mikko Rapeli [13/27] X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;ds=sidebyside;h=d5aa0756b523b7e9b7f0af70f1779872e63d7a7e;p=kdenlive cppcheck fixes, patch by Mikko Rapeli [13/27] svn path=/trunk/kdenlive/; revision=5886 --- diff --git a/src/effectstackedit.cpp b/src/effectstackedit.cpp index 00ebba69..17111289 100644 --- a/src/effectstackedit.cpp +++ b/src/effectstackedit.cpp @@ -205,7 +205,7 @@ void EffectStackEdit::updateParameter(const QString &name, const QString &value) } } -void EffectStackEdit::transferParamDesc(const QDomElement d, ItemInfo info, bool isEffect) +void EffectStackEdit::transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect) { clearAllItems(); if (m_keyframeEditor) delete m_keyframeEditor; diff --git a/src/effectstackedit.h b/src/effectstackedit.h index d2770598..ea41b30f 100644 --- a/src/effectstackedit.h +++ b/src/effectstackedit.h @@ -87,7 +87,7 @@ private: public slots: /** @brief Called when an effect is selected, builds the UI for this effect. */ - void transferParamDesc(const QDomElement d, ItemInfo info, bool isEffect = true); + void transferParamDesc(const QDomElement &d, ItemInfo info, bool isEffect = true); /** @brief Called whenever(?) some parameter is changed in the gui. * @@ -98,7 +98,7 @@ public slots: void slotSyncEffectsPos(int pos); signals: - void parameterChanged(const QDomElement, const QDomElement); + void parameterChanged(const QDomElement &, const QDomElement &); void seekTimeline(int); void displayMessage(const QString&, int); void checkMonitorPosition(int); diff --git a/src/effectstackview.cpp b/src/effectstackview.cpp index d1887625..5726f846 100644 --- a/src/effectstackview.cpp +++ b/src/effectstackview.cpp @@ -91,7 +91,7 @@ EffectStackView::EffectStackView(Monitor *monitor, QWidget *parent) : connect(m_ui.buttonReset, SIGNAL(clicked()), this, SLOT(slotResetEffect())); connect(m_ui.checkAll, SIGNAL(stateChanged(int)), this, SLOT(slotCheckAll(int))); connect(m_ui.buttonShowComments, SIGNAL(clicked()), this, SLOT(slotShowComments())); - connect(m_effectedit, SIGNAL(parameterChanged(const QDomElement, const QDomElement)), this , SLOT(slotUpdateEffectParams(const QDomElement, const QDomElement))); + connect(m_effectedit, SIGNAL(parameterChanged(const QDomElement &, const QDomElement &)), this , SLOT(slotUpdateEffectParams(const QDomElement &, const QDomElement &))); connect(m_effectedit, SIGNAL(seekTimeline(int)), this , SLOT(slotSeekTimeline(int))); connect(m_effectedit, SIGNAL(displayMessage(const QString&, int)), this, SIGNAL(displayMessage(const QString&, int))); connect(m_effectedit, SIGNAL(checkMonitorPosition(int)), this, SLOT(slotCheckMonitorPosition(int)));