From: Dan Dennedy Date: Sun, 7 Jun 2009 07:05:47 +0000 (+0000) Subject: Rename non-frei0r transitions to more common names: X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=1143bc671aaf2ae46521ce374993b8fd7fd2d4c2;p=kdenlive Rename non-frei0r transitions to more common names: Wipe -> Slide Luma -> Wipe And add Dissolve as the default transition. svn path=/trunk/kdenlive/; revision=3496 --- diff --git a/src/customtrackview.cpp b/src/customtrackview.cpp index a995f28f..9837561b 100644 --- a/src/customtrackview.cpp +++ b/src/customtrackview.cpp @@ -854,7 +854,7 @@ void CustomTrackView::mousePressEvent(QMouseEvent * event) info.startPos = transitionClip->startPos(); } else info.startPos = info.endPos - GenTime(65, m_document->fps()); if (info.endPos == info.startPos) info.startPos = info.endPos - GenTime(65, m_document->fps()); - QDomElement transition = MainWindow::transitions.getEffectByName("Luma").cloneNode().toElement(); + QDomElement transition = MainWindow::transitions.getEffectByName("Dissolve").cloneNode().toElement(); EffectsList::setParameter(transition, "reverse", "1"); // Check there is no other transition at that place @@ -1024,7 +1024,7 @@ void CustomTrackView::mouseDoubleClickEvent(QMouseEvent *event) } else { getClipAvailableSpace(m_dragItem, minimum, maximum); } - //kDebug()<<"// GOT MOVE POS: "<type() == TRANSITIONWIDGET) { @@ -1124,7 +1124,7 @@ void CustomTrackView::dragEnterEvent(QDragEnterEvent * event) m_selectionGroup = new AbstractGroupItem(m_document->fps()); QPoint pos; DocClipBase *clip = m_document->getBaseClip(list.at(0)); - if (clip == NULL) kDebug() << " WARNING))))))))) CLIP NOT FOUND : " << list.at(0); + if (clip == NULL) kDebug() << " WARNING))))))))) CLIP NOT FOUND : " << list.at(0); ItemInfo info; info.startPos = GenTime(); info.cropStart = GenTime(list.at(1).toInt(), m_document->fps()); @@ -1152,7 +1152,7 @@ void CustomTrackView::dragEnterEvent(QDragEnterEvent * event) QList offsetList; for (int i = 0; i < ids.size(); ++i) { DocClipBase *clip = m_document->getBaseClip(ids.at(i)); - if (clip == NULL) kDebug() << " WARNING))))))))) CLIP NOT FOUND : " << ids.at(i); + if (clip == NULL) kDebug() << " WARNING))))))))) CLIP NOT FOUND : " << ids.at(i); ItemInfo info; info.startPos = start; info.endPos = info.startPos + clip->duration(); @@ -1169,7 +1169,7 @@ void CustomTrackView::dragEnterEvent(QDragEnterEvent * event) scene()->addItem(m_selectionGroup); event->acceptProposedAction(); } else { - // the drag is not a clip (may be effect, ...) + // the drag is not a clip (may be effect, ...) m_clipDrag = false; QGraphicsView::dragEnterEvent(event); } @@ -1237,7 +1237,7 @@ void CustomTrackView::deleteEffect(int track, GenTime pos, QDomElement effect) { QString index = effect.attribute("kdenlive_ix"); if (!m_document->renderer()->mltRemoveEffect(track, pos, index, true) && effect.attribute("disabled") != "1") { - kDebug() << "// ERROR REMOV EFFECT: " << index << ", DISABLE: " << effect.attribute("disabled"); + kDebug() << "// ERROR REMOV EFFECT: " << index << ", DISABLE: " << effect.attribute("disabled"); emit displayMessage(i18n("Problem deleting effect"), ErrorMessage); return; } @@ -1300,7 +1300,7 @@ void CustomTrackView::slotAddEffect(QDomElement effect, GenTime pos, int track) if (clip) itemList.append(clip); else emit displayMessage(i18n("Select a clip if you want to apply an effect"), ErrorMessage); } - kDebug() << "// REQUESTING EFFECT ON CLIP: " << pos.frames(25) << ", TRK: " << track << "SELECTED ITEMS: " << itemList.count(); + kDebug() << "// REQUESTING EFFECT ON CLIP: " << pos.frames(25) << ", TRK: " << track << "SELECTED ITEMS: " << itemList.count(); for (int i = 0; i < itemList.count(); i++) { if (itemList.at(i)->type() == AVWIDGET) { ClipItem *item = (ClipItem *)itemList.at(i); @@ -1633,7 +1633,7 @@ void CustomTrackView::deleteTransition(ItemInfo transitionInfo, int endTrack, QD void CustomTrackView::slotTransitionUpdated(Transition *tr, QDomElement old) { - kDebug() << "TRANS UPDATE, TRACKS: " << old.attribute("transition_btrack") << ", NEW: " << tr->toXML().attribute("transition_btrack"); + kDebug() << "TRANS UPDATE, TRACKS: " << old.attribute("transition_btrack") << ", NEW: " << tr->toXML().attribute("transition_btrack"); EditTransitionCommand *command = new EditTransitionCommand(this, tr->track(), tr->startPos(), old, tr->toXML(), false); m_commandStack->push(command); m_document->setModified(true); @@ -1647,7 +1647,7 @@ void CustomTrackView::updateTransition(int track, GenTime pos, QDomElement oldTr return; } m_document->renderer()->mltUpdateTransition(oldTransition.attribute("tag"), transition.attribute("tag"), transition.attribute("transition_btrack").toInt(), m_document->tracksCount() - transition.attribute("transition_atrack").toInt(), item->startPos(), item->endPos(), transition); - //kDebug() << "ORIGINAL TRACK: "<< oldTransition.attribute("transition_btrack") << ", NEW TRACK: "<setTransitionParameters(transition); if (updateTransitionWidget) { ItemInfo info = item->info(); @@ -2248,7 +2248,7 @@ void CustomTrackView::mouseReleaseEvent(QMouseEvent * event) InsertSpaceCommand *command = new InsertSpaceCommand(this, clipsToMove, transitionsToMove, track, timeOffset, false); m_commandStack->push(command); if (track != -1) track = m_document->tracksCount() - track; - kDebug() << "SPACER TRACK:" << track; + kDebug() << "SPACER TRACK:" << track; m_document->renderer()->mltInsertSpace(trackClipStartList, trackTransitionStartList, track, timeOffset, GenTime()); } resetSelectionGroup(false); @@ -2470,7 +2470,7 @@ void CustomTrackView::mouseReleaseEvent(QMouseEvent * event) } } else if (m_operationMode == RESIZESTART && m_dragItem->startPos() != m_dragItemInfo.startPos) { - // resize start + // resize start if (m_dragItem->type() == AVWIDGET) { ItemInfo resizeinfo = m_dragItemInfo; resizeinfo.track = m_document->tracksCount() - resizeinfo.track; @@ -2531,7 +2531,7 @@ void CustomTrackView::mouseReleaseEvent(QMouseEvent * event) } //m_document->renderer()->doRefresh(); } else if (m_operationMode == RESIZEEND && m_dragItem->endPos() != m_dragItemInfo.endPos) { - // resize end + // resize end if (m_dragItem->type() == AVWIDGET) { ItemInfo resizeinfo = info; resizeinfo.track = m_document->tracksCount() - resizeinfo.track; @@ -2592,7 +2592,7 @@ void CustomTrackView::mouseReleaseEvent(QMouseEvent * event) } //m_document->renderer()->doRefresh(); } else if (m_operationMode == FADEIN) { - // resize fade in effect + // resize fade in effect ClipItem * item = (ClipItem *) m_dragItem; int ix = item->hasEffect("volume", "fadein"); if (ix != -1) { @@ -2631,7 +2631,7 @@ void CustomTrackView::mouseReleaseEvent(QMouseEvent * event) } } } else if (m_operationMode == FADEOUT) { - // resize fade in effect + // resize fade in effect ClipItem * item = (ClipItem *) m_dragItem; int ix = item->hasEffect("volume", "fadeout"); if (ix != -1) { @@ -3088,7 +3088,7 @@ void CustomTrackView::moveClip(const ItemInfo start, const ItemInfo end) ClipItem *item = getClipItemAt((int) start.startPos.frames(m_document->fps()) + 1, start.track); if (!item) { emit displayMessage(i18n("Cannot move clip at time: %1 on track %2", m_document->timecode().getTimecodeFromFrames(start.startPos.frames(m_document->fps())), start.track), ErrorMessage); - kDebug() << "----------------  ERROR, CANNOT find clip to move at.. "; + kDebug() << "---------------- ERROR, CANNOT find clip to move at.. "; return; } Mlt::Producer *prod; @@ -3141,14 +3141,14 @@ void CustomTrackView::moveGroup(QList startClip, QList sta startClip[i].startPos = startClip.at(i).startPos - offset; startClip[i].track = startClip.at(i).track - trackOffset; } - //kDebug()<<"//LKING FR CLIP AT:"<setItemLocked(false); if (clip->parentItem()) clip->parentItem()->setSelected(true); else clip->setSelected(true); m_document->renderer()->mltRemoveClip(m_document->tracksCount() - startClip.at(i).track, startClip.at(i).startPos); - } else kDebug() << "//MISSING CLIP AT: " << startClip.at(i).startPos.frames(25); + } else kDebug() << "//MISSING CLIP AT: " << startClip.at(i).startPos.frames(25); } for (int i = 0; i < startTransition.count(); i++) { if (reverseMove) { @@ -3161,7 +3161,7 @@ void CustomTrackView::moveGroup(QList startClip, QList sta if (tr->parentItem()) tr->parentItem()->setSelected(true); else tr->setSelected(true); m_document->renderer()->mltDeleteTransition(tr->transitionTag(), tr->transitionEndTrack(), m_document->tracksCount() - startTransition.at(i).track, startTransition.at(i).startPos, startTransition.at(i).endPos, tr->toXML()); - } else kDebug() << "//MISSING TRANSITION AT: " << startTransition.at(i).startPos.frames(25); + } else kDebug() << "//MISSING TRANSITION AT: " << startTransition.at(i).startPos.frames(25); } groupSelectedItems(true); if (m_selectionGroup) { @@ -3201,7 +3201,7 @@ void CustomTrackView::moveGroup(QList startClip, QList sta else if (clip->isVideoOnly()) prod = clip->baseClip()->videoProducer(); else prod = clip->baseClip()->producer(info.track); m_document->renderer()->mltInsertClip(info, clip->xml(), prod); - kDebug() << "// inserting new clp: " << info.startPos.frames(25); + kDebug() << "// inserting new clp: " << info.startPos.frames(25); } else if (item->type() == TRANSITIONWIDGET) { Transition *tr = static_cast (item); int newTrack = tr->transitionEndTrack(); @@ -3216,7 +3216,7 @@ void CustomTrackView::moveGroup(QList startClip, QList sta } } KdenliveSettings::setSnaptopoints(snap); - } else kDebug() << "///////// WARNING; NO GROUP TO MOVE"; + } else kDebug() << "///////// WARNING; NO GROUP TO MOVE"; } void CustomTrackView::moveTransition(const ItemInfo start, const ItemInfo end) @@ -3224,13 +3224,13 @@ void CustomTrackView::moveTransition(const ItemInfo start, const ItemInfo end) Transition *item = getTransitionItemAt(start.startPos, start.track); if (!item) { emit displayMessage(i18n("Cannot move transition at time: %1 on track %2", m_document->timecode().getTimecodeFromFrames(start.startPos.frames(m_document->fps())), start.track), ErrorMessage); - kDebug() << "----------------  ERROR, CANNOT find transition to move... ";// << startPos.x() * m_scale * FRAME_SIZE + 1 << ", " << startPos.y() * m_tracksHeight + m_tracksHeight / 2; + kDebug() << "---------------- ERROR, CANNOT find transition to move... ";// << startPos.x() * m_scale * FRAME_SIZE + 1 << ", " << startPos.y() * m_tracksHeight + m_tracksHeight / 2; return; } - //kDebug() << "----------------  Move TRANSITION FROM: " << startPos.x() << ", END:" << endPos.x() << ",TRACKS: " << oldtrack << " TO " << newtrack; + //kDebug() << "---------------- Move TRANSITION FROM: " << startPos.x() << ", END:" << endPos.x() << ",TRACKS: " << oldtrack << " TO " << newtrack; bool snap = KdenliveSettings::snaptopoints(); KdenliveSettings::setSnaptopoints(false); - //kDebug()<<"/// RESIZE TRANS START: ("<< startPos.x()<<"x"<< startPos.y()<<") / ("<setPos((int) end.startPos.frames(m_document->fps()), (end.track) * m_tracksHeight + 1); @@ -3262,7 +3262,7 @@ void CustomTrackView::resizeClip(const ItemInfo start, const ItemInfo end) ClipItem *item = getClipItemAt((int)(start.startPos.frames(m_document->fps())), start.track); if (!item) { emit displayMessage(i18n("Cannot move clip at time: %1 on track %2", m_document->timecode().getTimecodeFromFrames(start.startPos.frames(m_document->fps())), start.track), ErrorMessage); - kDebug() << "----------------  ERROR, CANNOT find clip to resize at... "; // << startPos; + kDebug() << "---------------- ERROR, CANNOT find clip to resize at... "; // << startPos; return; } if (item->parentItem()) { @@ -4426,13 +4426,13 @@ void CustomTrackView::doSplitAudio(const GenTime &pos, int track, bool split) } else { // unsplit clip: remove audio part and change video part to normal clip if (clip->parentItem() == NULL || clip->parentItem()->type() != GROUPWIDGET) { - kDebug() << "//CANNOT FIND CLP GRP"; + kDebug() << "//CANNOT FIND CLP GRP"; return; } AbstractGroupItem *grp = static_cast (clip->parentItem()); QList children = grp->childItems(); if (children.count() != 2) { - kDebug() << "//SOMETHING IS WRONG WITH CLP GRP"; + kDebug() << "//SOMETHING IS WRONG WITH CLP GRP"; return; } for (int i = 0; i < children.count(); i++) { diff --git a/src/initeffects.cpp b/src/initeffects.cpp index 70b669ea..dcdc2158 100644 --- a/src/initeffects.cpp +++ b/src/initeffects.cpp @@ -90,7 +90,7 @@ void initEffects::refreshLumas() imagenamelist.append(fname); imagefiles.append(folder + '/' + fname); } - QDomElement lumaTransition = MainWindow::transitions.getEffectByTag("luma", QString()); + QDomElement lumaTransition = MainWindow::transitions.getEffectByName("Wipe"); QDomNodeList params = lumaTransition.elementsByTagName("parameter"); for (int i = 0; i < params.count(); i++) { QDomElement e = params.item(i).toElement(); @@ -658,8 +658,8 @@ void initEffects::fillTransitionsList(Mlt::Repository * repository, EffectsList* if (name == "luma") { - tname.appendChild(ret.createTextNode("Luma")); - desc.appendChild(ret.createTextNode("Applies a luma transition between the current and next frames")); + tname.appendChild(ret.createTextNode("Wipe")); + desc.appendChild(ret.createTextNode("Applies a stationary transition between the current and next frames")); paramList.append(quickParameterFill(ret, "Softness", "softness", "double", "0", "0", "100", "", "", "100")); paramList.append(quickParameterFill(ret, "Invert", "invert", "bool", "0", "0", "1")); @@ -674,9 +674,9 @@ void initEffects::fillTransitionsList(Mlt::Repository * repository, EffectsList* paramList.append(quickParameterFill(ret, "Align", "aligned", "bool", "1", "0", "1")); paramList.append(quickParameterFill(ret, "Fill", "fill", "bool", "0", "0", "1")); paramList.append(quickParameterFill(ret, "Distort", "distort", "bool", "0", "0", "1")); - paramList.append(quickParameterFill(ret, "Luma Image File", "luma", "list", "", "", "", imagefiles.join(","), imagenamelist.join(","))); - paramList.append(quickParameterFill(ret, "Luma Softness", "softness", "double", "0", "0", "100", "", "", "100")); - paramList.append(quickParameterFill(ret, "Luma Invert", "luma_invert", "bool", "0", "0", "1")); + paramList.append(quickParameterFill(ret, "Wipe File", "luma", "list", "", "", "", imagefiles.join(","), imagenamelist.join(","))); + paramList.append(quickParameterFill(ret, "Wipe Softness", "softness", "double", "0", "0", "100", "", "", "100")); + paramList.append(quickParameterFill(ret, "Wipe Invert", "luma_invert", "bool", "0", "0", "1")); paramList.append(quickParameterFill(ret, "Force Progressive Rendering", "progressive", "bool", "1", "0", "1")); paramList.append(quickParameterFill(ret, "Force Deinterlace Overlay", "deinterlace", "bool", "0", "0", "1")); tname.appendChild(ret.createTextNode("Composite")); @@ -732,11 +732,16 @@ void initEffects::fillTransitionsList(Mlt::Repository * repository, EffectsList* */ } - QString wipetrans = "WipeSlide image from one side to anotherDirection AlignForce Progressive RenderingForce Deinterlace Overlay"; + QString wipetrans = "SlideSlide image from one side to anotherDirection AlignForce Progressive RenderingForce Deinterlace Overlay"; QDomDocument ret; ret.setContent(wipetrans); transitions->append(ret.documentElement()); + QString dissolve = "DissolveFade out one video while fading in the other videoReverse"; + QDomDocument dissolveDoc; + dissolveDoc.setContent(dissolve); + transitions->append(dissolveDoc.documentElement()); + /*QString alphatrans = "Alpha transparencyMake alpha channel transparentDirectionRescaleAlign"; QDomDocument ret2; ret2.setContent(alphatrans); diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp index d2bc4b01..0cdc7e1f 100644 --- a/src/mainwindow.cpp +++ b/src/mainwindow.cpp @@ -801,7 +801,7 @@ void MainWindow::setupActions() collection->addAction("manage_profiles", profilesAction); connect(profilesAction, SIGNAL(triggered(bool)), this, SLOT(slotEditProfiles())); - KNS::standardAction(i18n("Download New Lumas..."), this, SLOT(slotGetNewLumaStuff()), actionCollection(), "get_new_lumas"); + KNS::standardAction(i18n("Download New Wipes..."), this, SLOT(slotGetNewLumaStuff()), actionCollection(), "get_new_lumas"); KNS::standardAction(i18n("Download New Render Profiles..."), this, SLOT(slotGetNewRenderStuff()), actionCollection(), "get_new_profiles"); diff --git a/src/renderer.cpp b/src/renderer.cpp index 65207372..7689a11d 100644 --- a/src/renderer.cpp +++ b/src/renderer.cpp @@ -809,7 +809,7 @@ void Render::setSceneList(QString playlist, int position) //kWarning() << "////// RENDER, SET SCENE LIST: " << playlist; if (m_mltConsumer == NULL) { - kWarning() << "/////// ERROR, TRYING TO USE NULL MLT CONSUMER"; + kWarning() << "/////// ERROR, TRYING TO USE NULL MLT CONSUMER"; m_isBlocked = false; return; } @@ -2831,6 +2831,8 @@ bool Render::mltAddTransition(QString tag, int a_track, int b_track, GenTime in, QString key; if (xml.attribute("automatic") == "1") transition->set("automatic", 1); //kDebug() << " ------ ADDING TRANSITION PARAMs: " << args.count(); + if (xml.hasAttribute("id")) + transition->set("kdenlive_id", xml.attribute("id").toUtf8().constData()); for (it = args.begin(); it != args.end(); ++it) { key = it.key(); @@ -2838,7 +2840,6 @@ bool Render::mltAddTransition(QString tag, int a_track, int b_track, GenTime in, char *value = decodedString(it.value()); if (it.value().isEmpty() == false) transition->set(name, value); //kDebug() << " ------ ADDING TRANS PARAM: " << name << ": " << value; - //filter->set("kdenlive_id", id); delete[] name; delete[] value; } diff --git a/src/trackview.cpp b/src/trackview.cpp index 2a7224b5..e93a0f6d 100644 --- a/src/trackview.cpp +++ b/src/trackview.cpp @@ -239,6 +239,7 @@ void TrackView::parseDocument(QDomDocument doc) bool forceTrack = false; QString mlt_geometry; QString mlt_service; + QString transitionId; for (int k = 0; k < transitionparams.count(); k++) { p = transitionparams.item(k).toElement(); if (!p.isNull()) { @@ -251,6 +252,7 @@ void TrackView::parseDocument(QDomDocument doc) } else if (paramName == "a_track") a_track = p.text().toInt(); else if (paramName == "b_track") b_track = p.text().toInt(); else if (paramName == "mlt_service") mlt_service = p.text(); + else if (paramName == "kdenlive_id") transitionId = p.text(); else if (paramName == "geometry") mlt_geometry = p.text(); else if (paramName == "automatic" && p.text() == "1") isAutomatic = true; else if (paramName == "force_track" && p.text() == "1") forceTrack = true; @@ -259,8 +261,7 @@ void TrackView::parseDocument(QDomDocument doc) if (transitionAdd || mlt_service != "mix") { // Transition should be added to the scene ItemInfo transitionInfo; - QString transitionId; - if (mlt_service == "composite") { + if (mlt_service == "composite" && transitionId.isEmpty()) { // When adding composite transition, check if it is a wipe transition if (mlt_geometry.count(';') == 1) { mlt_geometry.remove(QChar('%'), Qt::CaseInsensitive); @@ -282,7 +283,7 @@ void TrackView::parseDocument(QDomDocument doc) break; } } - if (isWipeTransition) transitionId = "wipe"; + if (isWipeTransition) transitionId = "slide"; } } QDomElement base = MainWindow::transitions.getEffectByTag(mlt_service, transitionId).cloneNode().toElement(); diff --git a/src/transition.cpp b/src/transition.cpp index 25ec6dd4..6a6d5f18 100644 --- a/src/transition.cpp +++ b/src/transition.cpp @@ -50,7 +50,7 @@ Transition::Transition(const ItemInfo info, int transitiontrack, double fps, QDo //m_referenceClip = clipa; if (params.isNull()) { - m_parameters = MainWindow::transitions.getEffectByName("Luma").cloneNode().toElement(); + m_parameters = MainWindow::transitions.getEffectByName("Dissolve").cloneNode().toElement(); } else { m_parameters = params; } diff --git a/src/widgets/clipproperties_ui.ui b/src/widgets/clipproperties_ui.ui index 32a48fb7..2a6d8a88 100644 --- a/src/widgets/clipproperties_ui.ui +++ b/src/widgets/clipproperties_ui.ui @@ -102,7 +102,7 @@ - 0 + 3 @@ -341,7 +341,7 @@ - Crossfade + Dissolve @@ -375,7 +375,7 @@ - Luma file + Wipe @@ -674,30 +674,30 @@ - KIntSpinBox - QSpinBox -
knuminput.h
+ KColorButton + QPushButton +
kcolorbutton.h
+
+ + KComboBox + QComboBox +
kcombobox.h
KDoubleNumInput QWidget
knuminput.h
+ + KIntSpinBox + QSpinBox +
knuminput.h
+
KLineEdit QLineEdit
klineedit.h
- - KComboBox - QComboBox -
kcombobox.h
-
- - KColorButton - QPushButton -
kcolorbutton.h
-
KRestrictedLine KLineEdit diff --git a/src/widgets/slideshowclip_ui.ui b/src/widgets/slideshowclip_ui.ui index 7c212e19..9fb045d8 100644 --- a/src/widgets/slideshowclip_ui.ui +++ b/src/widgets/slideshowclip_ui.ui @@ -91,7 +91,7 @@ - Crossfade + Dissolve @@ -134,7 +134,7 @@ false - Luma File + Wipe
@@ -191,36 +191,36 @@ + + KComboBox + QComboBox +
kcombobox.h
+
KIntSpinBox QSpinBox
knuminput.h
- - KUrlRequester - QFrame -
kurlrequester.h
-
- - KListWidget - QListWidget -
klistwidget.h
-
KLineEdit QLineEdit
klineedit.h
- KComboBox - QComboBox -
kcombobox.h
+ KListWidget + QListWidget +
klistwidget.h
KRestrictedLine KLineEdit
krestrictedline.h
+ + KUrlRequester + QFrame +
kurlrequester.h
+