From: Simon A. Eugster <simon.eu@gmail.com>
Date: Mon, 27 Dec 2010 18:51:19 +0000 (+0000)
Subject: Light Graffiti effect: Parameters and descriptions added
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=33ab6d85f3310fc1f71005e48c1f08acc13f38d1;p=kdenlive

Light Graffiti effect: Parameters and descriptions added

svn path=/trunk/kdenlive/; revision=5210
---

diff --git a/effects/frei0r_lightgraffiti.xml b/effects/frei0r_lightgraffiti.xml
index f836de22..e53c1e10 100644
--- a/effects/frei0r_lightgraffiti.xml
+++ b/effects/frei0r_lightgraffiti.xml
@@ -3,12 +3,32 @@
         <name>Light Graffiti</name>
         <description>Light Graffiti effect.</description>
         <author>Simon A. Eugster (Granjow)</author>
-        <parameter type="constant" name="longAlpha" default="2" min="0" max="256" factor="256">
+        <parameter type="constant" name="longAlpha" default="0" min="0" max="256" factor="256">
                 <name>α</name>
-                <comment>Determines how the effect tries to adapt to background changes. If the background does not change, then try to use 0.</comment>
+                <comment><![CDATA[Determines how the effect tries to adapt to background changes. <br/>
+                If the background does not change, then try to use 0 (requires the first frame to represent background only, without your light sources).]]></comment>
         </parameter>
 	<parameter type="constant" name="lightOpacity" default="40" min="0" max="100" factor="100">
-          <name>Opacity</name>
-          <comment><![CDATA[Basic opacity for a light source.]]></comment>
+            <name>Opacity</name>
+            <comment><![CDATA[Basic opacity for a light source.<br/>
+            For slowly moving light source try to use a lower opacity value to obtain smoother results.]]></comment>
 	</parameter>
+        <parameter type="constant" name="backgroundWeight" default="0" min="0" max="100" factor="100">
+            <name>Background Weight</name>
+            <comment>Strength of the (calculated) background image. Setting it to 100 paints the light mask directly over the background, without any person in the image if the video starts with a «clean» background image.</comment>
+        </parameter>
+        <parameter type="constant" name="thresholdBrightness" default="450" min="0" max="765" factor="1">
+            <name>Brightness Threshold</name>
+            <comment><![CDATA[Determines how bright (<code>R+G+B</code>) a light source needs to be in order to be recognized as light source.<br/>
+            Increasing this threshold requires brighter light sources (i.e. more white or less color, respectively) but prevents some «false alarms» where semi-bright parts, e.g. hands where colors can change quite a lot compared to the background, are incorrectly recognized as light source.]]></comment>
+        </parameter>
+        <parameter type="constant" name="thresholdDifference" default="80" min="0" max="255" factor="1">
+            <name>Difference Threshold</name>
+            <comment><![CDATA[Similar to the brightness threshold, but for the brightness difference (<code>max(dR, dG, dB)</code>) <em>relative to the calculated background.</em><br/>
+            Increasing this threshold makes it harder for light sources to be accepted on bright backgrounds, but decreases the danger of noise counting as light source.]]></comment>
+        </parameter>
+        <parameter type="constant" name="dim" default="0" min="0" max="100" factor="100">
+            <name>Dimming</name>
+            <comment>Dims the light mask. Lights will leave a fainting trail if it is set to a value > 0.</comment>
+        </parameter>
 </effect>
diff --git a/effects/frei0r_sopsat.xml b/effects/frei0r_sopsat.xml
index c4e63215..ef21802f 100644
--- a/effects/frei0r_sopsat.xml
+++ b/effects/frei0r_sopsat.xml
@@ -5,7 +5,8 @@
         <author>Simon A. Eugster (Granjow)</author>
         <parameter type="simplekeyframe" name="rSlope" default="100" min="0" max="1000" factor="100">
                 <name>Slope Red</name>
-                <comment>Changing the slope means multiplying the pixel value with a constant value.</comment>
+                <comment><![CDATA[Changing the slope means multiplying the pixel value with a constant value. Black pixels will remain black, whileas brighter ones will be changed.<br/>
+                All effects can be observed well when applied on a greyscale gradient and looking at the RGB Parade monitor.]]></comment>
         </parameter>
         <parameter type="simplekeyframe" name="gSlope" default="100" min="0" max="1000" factor="100">
                 <name>Slope Green</name>