From: Michael Niedermayer <michael@niedermayer.cc>
Date: Thu, 16 May 2019 09:03:59 +0000 (+0200)
Subject: avcodec/aacdec_fixed: ssign seems always -1 in noise_scale(), simplify
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=3d5863d73915748013975cac8d2148c5fc3d01c3;p=ffmpeg

avcodec/aacdec_fixed: ssign seems always -1 in noise_scale(), simplify
---

diff --git a/libavcodec/aacdec_fixed.c b/libavcodec/aacdec_fixed.c
index b051e75709a..0808c810058 100644
--- a/libavcodec/aacdec_fixed.c
+++ b/libavcodec/aacdec_fixed.c
@@ -195,12 +195,12 @@ static void subband_scale(int *dst, int *src, int scale, int offset, int len, vo
 
 static void noise_scale(int *coefs, int scale, int band_energy, int len)
 {
-    int ssign = scale < 0 ? -1 : 1;
-    int s = FFABS(scale);
+    int s = -scale;
     unsigned int round;
     int i, out, c = exp2tab[s & 3];
     int nlz = 0;
 
+    av_assert0(s >= 0);
     while (band_energy > 0x7fff) {
         band_energy >>= 1;
         nlz++;
@@ -216,7 +216,7 @@ static void noise_scale(int *coefs, int scale, int band_energy, int len)
         round = s ? 1 << (s-1) : 0;
         for (i=0; i<len; i++) {
             out = (int)(((int64_t)coefs[i] * c) >> 32);
-            coefs[i] = ((int)(out+round) >> s) * ssign;
+            coefs[i] = -((int)(out+round) >> s);
         }
     }
     else {
@@ -224,7 +224,7 @@ static void noise_scale(int *coefs, int scale, int band_energy, int len)
         round = s ? 1 << (s-1) : 0;
         for (i=0; i<len; i++) {
             out = (int)((int64_t)((int64_t)coefs[i] * c + round) >> s);
-            coefs[i] = out * ssign;
+            coefs[i] = -out;
         }
     }
 }