From: Jean-Paul Saman <jpsaman@videolan.org>
Date: Thu, 6 Dec 2007 16:26:46 +0000 (+0000)
Subject: CodingStyle fixes, use ; when using macros and do not write it in the macro definition.
X-Git-Tag: 0.9.0-test0~4250
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=75a0a1de8718cd38cfea5b5117df8dca02be8eea;p=vlc

CodingStyle fixes, use ; when using macros and do not write it in the macro definition.
---

diff --git a/include/vlc_playlist.h b/include/vlc_playlist.h
index 75d095b447..68e7786b04 100644
--- a/include/vlc_playlist.h
+++ b/include/vlc_playlist.h
@@ -269,8 +269,8 @@ struct playlist_add_t
  *****************************************************************************/
 
 /* Helpers */
-#define PL_LOCK vlc_object_lock( p_playlist );
-#define PL_UNLOCK vlc_object_unlock( p_playlist );
+#define PL_LOCK vlc_object_lock( p_playlist )
+#define PL_UNLOCK vlc_object_unlock( p_playlist )
 
 #define pl_Get( a ) a->p_libvlc->p_playlist
 
@@ -278,7 +278,7 @@ VLC_EXPORT( playlist_t *, __pl_Yield, ( vlc_object_t * ) );
 #define pl_Yield( a ) __pl_Yield( VLC_OBJECT(a) )
 
 VLC_EXPORT( void, __pl_Release, ( vlc_object_t * ) );
-#define pl_Release(a) __pl_Release( VLC_OBJECT(a) );
+#define pl_Release(a) __pl_Release( VLC_OBJECT(a) )
 
 /* Playlist control */
 #define playlist_Play(p) playlist_Control(p,PLAYLIST_PLAY, VLC_FALSE )
diff --git a/modules/gui/qt4/playlist_model.cpp b/modules/gui/qt4/playlist_model.cpp
index 2b7a35092a..3c19329176 100644
--- a/modules/gui/qt4/playlist_model.cpp
+++ b/modules/gui/qt4/playlist_model.cpp
@@ -913,7 +913,7 @@ void PLModel::sort( int column, Qt::SortOrder order )
                                         order == Qt::AscendingOrder ?
                                             ORDER_NORMAL : ORDER_REVERSE );
     }
-    PL_UNLOCK
+    PL_UNLOCK;
     rebuild();
 }
 
diff --git a/src/input/input.c b/src/input/input.c
index 91d72eafc8..e81234c01f 100644
--- a/src/input/input.c
+++ b/src/input/input.c
@@ -2095,7 +2095,7 @@ static void UpdateItemLength( input_thread_t *p_input, int64_t i_length )
         pl_Yield( p_input );
         var_SetInteger( pl_Get( p_input ), "item-change",
                         p_input->p->input.p_item->i_id );
-        pl_Release( p_input )
+        pl_Release( p_input );
     }
 }
 
diff --git a/src/playlist/engine.c b/src/playlist/engine.c
index 79ee6e8d4c..92d7aafc8c 100644
--- a/src/playlist/engine.c
+++ b/src/playlist/engine.c
@@ -256,7 +256,7 @@ check_input:
 
             /* Release the playlist lock, because we may get stuck
              * in input_DestroyThread() for some time. */
-            PL_UNLOCK
+            PL_UNLOCK;
 
             /* Destroy input */
             input_DestroyThread( p_input );
@@ -287,7 +287,7 @@ check_input:
         {
             PL_DEBUG( "dying input" );
             PL_UNLOCK;
-            msleep( 25000 ); // 25 ms
+            msleep( 25000 ); /* 25 ms */
             PL_LOCK;
             goto check_input;
         }
@@ -327,7 +327,7 @@ check_input:
              {
                 msg_Dbg( p_playlist, "nothing to play" );
                 p_playlist->status.i_status = PLAYLIST_STOPPED;
-                PL_UNLOCK
+                PL_UNLOCK;
 
                 if( b_playexit == VLC_TRUE )
                 {
@@ -358,7 +358,7 @@ check_input:
             PL_LOCK;
         }
     }
-    PL_UNLOCK
+    PL_UNLOCK;
 }
 
 /** Playlist dying last loop */
@@ -369,11 +369,10 @@ void playlist_LastLoop( playlist_t *p_playlist )
     /* If there is an input, kill it */
     while( 1 )
     {
-        PL_LOCK
-
+        PL_LOCK;
         if( p_playlist->p_input == NULL )
         {
-            PL_UNLOCK
+            PL_UNLOCK;
             break;
         }
 
@@ -384,7 +383,7 @@ void playlist_LastLoop( playlist_t *p_playlist )
             /* Unlink current input */
             p_input = p_playlist->p_input;
             p_playlist->p_input = NULL;
-            PL_UNLOCK
+            PL_UNLOCK;
 
             /* Destroy input */
             input_DestroyThread( p_input );
@@ -398,15 +397,14 @@ void playlist_LastLoop( playlist_t *p_playlist )
         else if( p_playlist->p_input->b_error || p_playlist->p_input->b_eof )
         {
             input_StopThread( p_playlist->p_input );
-            PL_UNLOCK
+            PL_UNLOCK;
             continue;
         }
         else
         {
             p_playlist->p_input->b_eof = 1;
         }
-
-        PL_UNLOCK
+        PL_UNLOCK;
 
         msleep( INTF_IDLE_SLEEP );
     }