From: Thomas Guillem Date: Tue, 16 Dec 2014 12:02:27 +0000 (+0000) Subject: swscale: fix memory corruption when i_extend_factor != 1 X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=868f5b89056218030b690621e89ca97b46635f6c;p=vlc swscale: fix memory corruption when i_extend_factor != 1 This led to a random crash when resizing video on a small display (or when resizing small video). Signed-off-by: Jean-Baptiste Kempf --- diff --git a/modules/video_chroma/swscale.c b/modules/video_chroma/swscale.c index c53cce5906..c99e5696aa 100644 --- a/modules/video_chroma/swscale.c +++ b/modules/video_chroma/swscale.c @@ -561,7 +561,7 @@ static void CopyPad( picture_t *p_dst, const picture_t *p_src ) const plane_t *s = &p_src->p[n]; plane_t *d = &p_dst->p[n]; - for( int y = 0; y < s->i_lines; y++ ) + for( int y = 0; y < s->i_lines && y < d->i_lines; y++ ) { for( int x = s->i_visible_pitch; x < d->i_visible_pitch; x += s->i_pixel_pitch ) memcpy( &d->p_pixels[y*d->i_pitch + x], &d->p_pixels[y*d->i_pitch + s->i_visible_pitch - s->i_pixel_pitch], s->i_pixel_pitch );