From: Montel Laurent <montel@kde.org>
Date: Sun, 12 May 2013 18:00:56 +0000 (+0200)
Subject: const'ify/use reference. Remove unused variable
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=8ad7ae9512af232388f1f31b69c671ce72f6b48d;p=kdenlive

const'ify/use reference. Remove unused variable
---

diff --git a/src/abstractclipitem.cpp b/src/abstractclipitem.cpp
index 0abf87aa..b333427f 100644
--- a/src/abstractclipitem.cpp
+++ b/src/abstractclipitem.cpp
@@ -261,7 +261,7 @@ GenTime AbstractClipItem::maxDuration() const
     return m_maxDuration;
 }
 
-void AbstractClipItem::drawKeyFrames(QPainter *painter, const QTransform transformation, bool limitedKeyFrames)
+void AbstractClipItem::drawKeyFrames(QPainter *painter, const QTransform &transformation, bool limitedKeyFrames)
 {
     if (m_keyframes.count() < 1)
         return;
diff --git a/src/abstractclipitem.h b/src/abstractclipitem.h
index db71b10e..4d26679c 100644
--- a/src/abstractclipitem.h
+++ b/src/abstractclipitem.h
@@ -127,7 +127,7 @@ protected:
       *        "simplekeyframe" type, the effect always starts on clip start and ends on clip end. With the
       *        "keyframe" type, the effect starts on the first keyframe and ends on the last keyframe
       */
-    void drawKeyFrames(QPainter *painter, const QTransform transformation, bool limitedKeyFrames);
+    void drawKeyFrames(QPainter *painter, const QTransform &transformation, bool limitedKeyFrames);
     int mouseOverKeyFrames(QPointF pos, double maxOffset);
     virtual void mousePressEvent(QGraphicsSceneMouseEvent * event);
 
diff --git a/src/archivewidget.cpp b/src/archivewidget.cpp
index 14ef2b75..e942b152 100644
--- a/src/archivewidget.cpp
+++ b/src/archivewidget.cpp
@@ -325,7 +325,7 @@ bool ArchiveWidget::closeAccepted()
 }
 
 
-void ArchiveWidget::generateItems(QTreeWidgetItem *parentItem, QStringList items)
+void ArchiveWidget::generateItems(QTreeWidgetItem *parentItem, const QStringList& items)
 {
     QStringList filesList;
     QString fileName;
@@ -343,7 +343,6 @@ void ArchiveWidget::generateItems(QTreeWidgetItem *parentItem, QStringList items
             if (slideUrl.fileName().startsWith(".all.")) {
                 // mimetype slideshow (for example *.png)
                     QStringList filters;
-                    QString extension;
                     // TODO: improve jpeg image detection with extension like jpeg, requires change in MLT image producers
                     filters << "*." + slideUrl.fileName().section('.', -1);
                     dir.setNameFilters(filters);
diff --git a/src/archivewidget.h b/src/archivewidget.h
index bc79c09f..0f09084f 100644
--- a/src/archivewidget.h
+++ b/src/archivewidget.h
@@ -107,7 +107,7 @@ private:
 #endif
 
     /** @brief Generate tree widget subitems from a string list of urls. */
-    void generateItems(QTreeWidgetItem *parentItem, QStringList items);
+    void generateItems(QTreeWidgetItem *parentItem, const QStringList &items);
     /** @brief Generate tree widget subitems from a map of clip ids / urls. */
     void generateItems(QTreeWidgetItem *parentItem, const QMap<QString, QString> &items);
     /** @brief Replace urls in project file. */
diff --git a/src/unicodedialog.cpp b/src/unicodedialog.cpp
index 7576c3b2..1a954897 100644
--- a/src/unicodedialog.cpp
+++ b/src/unicodedialog.cpp
@@ -73,7 +73,7 @@ void UnicodeDialog::showLastUnicode()
     slotTextChanged(m_lastUnicodeNumber);
 }
 
-bool UnicodeDialog::controlCharacter(QString text)
+bool UnicodeDialog::controlCharacter(const QString &text)
 {
     bool isControlCharacter = false;
     QString t = text.toLower();
diff --git a/src/unicodedialog.h b/src/unicodedialog.h
index 4a8579a2..ba84005d 100644
--- a/src/unicodedialog.h
+++ b/src/unicodedialog.h
@@ -48,7 +48,7 @@ private:
     /** \brief Removes all leading zeros */
     QString trimmedUnicodeNumber(QString text);
     /** \brief Checks whether the given string is a control character */
-    bool controlCharacter(QString text);
+    bool controlCharacter(const QString& text);
     /** \brief Checks whether the given uint is a control character */
     bool controlCharacter(uint value);