From: Laurent Aimar <fenrir@videolan.org>
Date: Sat, 28 Jun 2008 21:40:12 +0000 (+0000)
Subject: Fixed use of freed memory every time rtmp access is probed/used.
X-Git-Tag: 0.9.0-test1~62
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=9512f7de73883472b39a712748c33e9a51074a02;p=vlc

Fixed use of freed memory every time rtmp access is probed/used.
(for example, on invalid file ...)
---

diff --git a/modules/access/rtmp/access.c b/modules/access/rtmp/access.c
index 8be1e0d27c..e0416aebf7 100644
--- a/modules/access/rtmp/access.c
+++ b/modules/access/rtmp/access.c
@@ -242,10 +242,11 @@ error2:
 
     net_Close( p_sys->p_thread->fd );
 error:
+    vlc_UrlClean( &p_sys->p_thread->url );
+
     vlc_object_detach( p_sys->p_thread );
     vlc_object_release( p_sys->p_thread );
 
-    vlc_UrlClean( &p_sys->p_thread->url );
     free( p_sys );
 
     return VLC_EGENERIC;
@@ -286,12 +287,12 @@ static void Close( vlc_object_t * p_this )
 
     var_Destroy( p_access, "rtmp-caching" );
 
-    vlc_object_detach( p_sys->p_thread );
-    vlc_object_release( p_sys->p_thread );
-
     vlc_UrlClean( &p_sys->p_thread->url );
     free( p_sys->p_thread->psz_application );
     free( p_sys->p_thread->psz_media );
+
+    vlc_object_detach( p_sys->p_thread );
+    vlc_object_release( p_sys->p_thread );
     free( p_sys );
 }