From: Rémi Denis-Courmont <rem@videolan.org>
Date: Tue, 27 May 2008 15:02:45 +0000 (+0300)
Subject: Fix strcasen?cmp overflow
X-Git-Tag: 0.9.0-test0~678
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=a043d59ab6243e51b7bbee3a3fc22ab45f2113e8;p=vlc

Fix strcasen?cmp overflow

Pointed out by Hannes Domani
---

diff --git a/include/vlc_fixups.h b/include/vlc_fixups.h
index f72ee528d0..b5a46a9d55 100644
--- a/include/vlc_fixups.h
+++ b/include/vlc_fixups.h
@@ -146,7 +146,7 @@ static inline int strcasecmp (const char *s1, const char *s2)
     for (size_t i = 0;; i++)
     {
         int d = tolower (s1[i]) - tolower (s2[i]);
-        if (d) return d;
+        if (d || !s1[i]) return d;
     }
     return 0;
 }
@@ -163,7 +163,7 @@ static inline int strncasecmp (const char *s1, const char *s2, size_t n)
     for (size_t i = 0; i < n; i++)
     {
         int d = tolower (s1[i]) - tolower (s2[i]);
-        if (d) return d;
+        if (d || !s1[i]) return d;
     }
     return 0;
 }