From: Rémi Duraffort <ivoire@videolan.org>
Date: Wed, 25 Mar 2009 13:21:50 +0000 (+0100)
Subject: visual: avoid a strdup/free.
X-Git-Tag: 1.0.0-pre2~390
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=a1358b0ceedcd0abb1bc14fc8d3d2ae329c39fcf;p=vlc

visual: avoid a strdup/free.
---

diff --git a/modules/visualization/visual/visual.c b/modules/visualization/visual/visual.c
index 857d33ae41..3ee95a8b22 100644
--- a/modules/visualization/visual/visual.c
+++ b/modules/visualization/visual/visual.c
@@ -189,12 +189,10 @@ static int Open( vlc_object_t *p_this )
 {
     aout_filter_t     *p_filter = (aout_filter_t *)p_this;
     aout_filter_sys_t *p_sys;
-    vlc_value_t        val;
 
     char *psz_effects, *psz_parser;
     video_format_t fmt;
 
-
     if( ( p_filter->input.i_format != VLC_FOURCC('f','l','3','2') &&
           p_filter->input.i_format != VLC_FOURCC('f','i','3','2') ) )
     {
@@ -217,11 +215,7 @@ static int Open( vlc_object_t *p_this )
     p_sys->effect   = NULL;
 
     /* Parse the effect list */
-    var_Create( p_filter, "effect-list", VLC_VAR_STRING | VLC_VAR_DOINHERIT );
-    var_Get( p_filter, "effect-list", &val);
-    psz_parser = psz_effects = strdup( val.psz_string );
-    free( val.psz_string );
-
+    psz_parser = psz_effects = var_CreateGetString( p_filter, "effect-list" );
     var_AddCallback( p_filter, "effect-list", FilterCallback, NULL );
 
     while( psz_parser && *psz_parser != '\0' )