From: Montel Laurent <montel@kde.org>
Date: Sun, 12 May 2013 11:46:26 +0000 (+0200)
Subject: const'ify when necessary
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=af4fd26ba0a921d518c27367ef983f8436fba8b0;p=kdenlive

const'ify when necessary
---

diff --git a/src/documentvalidator.cpp b/src/documentvalidator.cpp
index ec04f385..989d5ffa 100644
--- a/src/documentvalidator.cpp
+++ b/src/documentvalidator.cpp
@@ -975,7 +975,7 @@ bool DocumentValidator::upgrade(double version, const double currentVersion)
     return true;
 }
 
-QStringList DocumentValidator::getInfoFromEffectName(const QString oldName)
+QStringList DocumentValidator::getInfoFromEffectName(const QString &oldName)
 {
     QStringList info;
     // Returns a list to convert old Kdenlive ladspa effects
diff --git a/src/documentvalidator.h b/src/documentvalidator.h
index aaa3b3a9..fa9ab288 100644
--- a/src/documentvalidator.h
+++ b/src/documentvalidator.h
@@ -42,7 +42,7 @@ private:
     KUrl m_url;
     bool m_modified;
     bool upgrade(double version, const double currentVersion);
-    QStringList getInfoFromEffectName(const QString oldName);
+    QStringList getInfoFromEffectName(const QString &oldName);
     QString colorToString(const QColor& c);
     /** @brief Updates effects that were created using a different version of the underlaying filter than the one installed. */
     void updateEffects();
diff --git a/src/effectslist.cpp b/src/effectslist.cpp
index d6777eb7..4479371c 100644
--- a/src/effectslist.cpp
+++ b/src/effectslist.cpp
@@ -55,7 +55,7 @@ QDomElement EffectsList::getEffectByName(const QString & name) const
 }
 
 
-void EffectsList::initEffect(QDomElement effect) const
+void EffectsList::initEffect(const QDomElement &effect) const
 {
     QDomNodeList params = effect.elementsByTagName("parameter");
     for (int i = 0; i < params.count(); i++) {
diff --git a/src/effectslist.h b/src/effectslist.h
index cbb58d6b..7119448c 100644
--- a/src/effectslist.h
+++ b/src/effectslist.h
@@ -100,7 +100,7 @@ private:
     bool m_useIndex;
     
     /** @brief Init effect default parameter values. */
-    void initEffect(QDomElement effect) const;
+    void initEffect(const QDomElement &effect) const;
 
 };
 
diff --git a/src/effectslistwidget.cpp b/src/effectslistwidget.cpp
index 374414ba..2e6af1f7 100644
--- a/src/effectslistwidget.cpp
+++ b/src/effectslistwidget.cpp
@@ -260,7 +260,7 @@ void EffectsListWidget::loadEffects(const EffectsList *effectlist, KIcon icon, Q
     }
 }
 
-QTreeWidgetItem *EffectsListWidget::findFolder(const QString name)
+QTreeWidgetItem *EffectsListWidget::findFolder(const QString &name)
 {
     QTreeWidgetItem *item = NULL;
     QList<QTreeWidgetItem *> result = findItems(name, Qt::MatchExactly);
diff --git a/src/effectslistwidget.h b/src/effectslistwidget.h
index 0e6ba5b8..c44d0f65 100644
--- a/src/effectslistwidget.h
+++ b/src/effectslistwidget.h
@@ -50,7 +50,7 @@ protected:
 private:
     QMenu *m_menu;
     /** @brief Returns the folder item whose name == @param name. */
-    QTreeWidgetItem *findFolder(const QString name);
+    QTreeWidgetItem *findFolder(const QString &name);
 
     /** @brief Loads the effects from the given effectlist as item of this widget.
      * @param effectlist effectlist containing the effects that should be loaded