From: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Date: Thu, 26 Dec 2019 10:53:35 +0000 (+0100)
Subject: avformat/flvenc: Fix leak of oversized packets
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=b0d0d7e4d0581ccfeea37cc3fd0d3ca9d999fbfc;p=ffmpeg

avformat/flvenc: Fix leak of oversized packets

Might happen for annex B H.264.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---

diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c
index f6379cbe058..1aaf0333caf 100644
--- a/libavformat/flvenc.c
+++ b/libavformat/flvenc.c
@@ -992,7 +992,8 @@ static int flv_write_packet(AVFormatContext *s, AVPacket *pkt)
     if (size + flags_size >= 1<<24) {
         av_log(s, AV_LOG_ERROR, "Too large packet with size %u >= %u\n",
                size + flags_size, 1<<24);
-        return AVERROR(EINVAL);
+        ret = AVERROR(EINVAL);
+        goto fail;
     }
 
     avio_wb24(pb, size + flags_size);