From: Pierre d'Herbemont <pdherbemont@free.fr>
Date: Fri, 21 Aug 2009 00:16:45 +0000 (+0200)
Subject: visual: Fix bad function return value cast.
X-Git-Tag: 1.1.0-ff~4054
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=be3d7a79bd8abb7f12db00e6d6b8a9f09782df17;p=vlc

visual: Fix bad function return value cast.
---

diff --git a/modules/visualization/visual/effects.c b/modules/visualization/visual/effects.c
index 267611ab55..9943771348 100644
--- a/modules/visualization/visual/effects.c
+++ b/modules/visualization/visual/effects.c
@@ -487,8 +487,11 @@ int spectrometer_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
             p_buffs = p_s16_buff;
     }
     fft_perform( p_buffer1, p_output, p_state);
-    for(i= 0; i< FFT_BUFFER_SIZE ; i++ )
-        p_dest[i] = ( (int) sqrt( p_output [ i ] ) ) >> 8;
+    for(i = 0; i < FFT_BUFFER_SIZE; i++)
+    {
+        int sqrti = sqrt(p_output[i]);
+        p_dest[i] = sqrti >> 8;
+    }
 
     i_nb_bands *= i_sections;
 
@@ -504,9 +507,10 @@ int spectrometer_Run(visual_effect_t * p_effect, aout_instance_t *p_aout,
         y >>=7;/* remove some noise */
         if( y != 0)
         {
-            height[i] = (int)log(y)* y_scale;
-               if(height[i] > 150)
-                  height[i] = 150;
+            int logy = log(y);
+            height[i] = logy * y_scale;
+            if(height[i] > 150)
+                height[i] = 150;
         }
         else
         {