From: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
Date: Mon, 28 Nov 2016 23:43:27 +0000 (+0100)
Subject: idroqdec: fix leaking pkt on failure
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=c0175fa92b7edd45a06e4ab16c8e83da0c94a9f6;p=ffmpeg

idroqdec: fix leaking pkt on failure

The code calls av_new_packet a few lines above and the allocated memory
has to be freed in case of an error.

Reviewed-by: Michael Niedermayer <michael@niedermayer.cc>
Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun@googlemail.com>
---

diff --git a/libavformat/idroqdec.c b/libavformat/idroqdec.c
index 83701b59c52..8fd67a6818b 100644
--- a/libavformat/idroqdec.c
+++ b/libavformat/idroqdec.c
@@ -222,8 +222,10 @@ static int roq_read_packet(AVFormatContext *s,
             pkt->pos= avio_tell(pb);
             ret = avio_read(pb, pkt->data + RoQ_CHUNK_PREAMBLE_SIZE,
                 chunk_size);
-            if (ret != chunk_size)
+            if (ret != chunk_size) {
+                av_packet_unref(pkt);
                 ret = AVERROR(EIO);
+            }
 
             packet_read = 1;
             break;