From: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Date: Sun, 14 Jun 2020 01:23:27 +0000 (+0200)
Subject: avformat/srtdec: Fix memleak upon read header failure
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=c70409957c7332971f0e147729d769f6d2f95390;p=ffmpeg

avformat/srtdec: Fix memleak upon read header failure

The already parsed subtitles (contained in an FFDemuxSubtitlesQueue)
would leak if an error happened upon reading a subsequent subtitle.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---

diff --git a/libavformat/srtdec.c b/libavformat/srtdec.c
index 40d324b44d1..d6ff00ba6d3 100644
--- a/libavformat/srtdec.c
+++ b/libavformat/srtdec.c
@@ -207,6 +207,8 @@ static int srt_read_header(AVFormatContext *s)
     ff_subtitles_queue_finalize(s, &srt->q);
 
 end:
+    if (res < 0)
+        ff_subtitles_queue_clean(&srt->q);
     av_bprint_finalize(&buf, NULL);
     return res;
 }