From: Rémi Duraffort <ivoire@videolan.org>
Date: Sat, 27 Dec 2008 14:10:39 +0000 (+0100)
Subject: Fix a segfault when parsing meta data in ogg.
X-Git-Tag: 1.0.0-pre1~1662
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=c93083157256930a2a0a582d016ab0e7baf7c545;p=vlc

Fix a segfault when parsing meta data in ogg.
Thanks to Vincent Penquerc'h.
---

diff --git a/include/vlc_meta.h b/include/vlc_meta.h
index b5fc8c38c8..124b8ec1ac 100644
--- a/include/vlc_meta.h
+++ b/include/vlc_meta.h
@@ -135,11 +135,8 @@ static inline void vlc_meta_AddExtra( vlc_meta_t *m, const char *psz_name, const
 {
     char *psz_oldvalue = (char *)vlc_dictionary_value_for_key( &m->extra_tags, psz_name );
     if( psz_oldvalue != kVLCDictionaryNotFound )
-    {
-        free( psz_oldvalue );
         vlc_dictionary_remove_value_for_key( &m->extra_tags, psz_name,
                                              vlc_meta_FreeExtraKey, NULL );
-    }
     vlc_dictionary_insert( &m->extra_tags, psz_name, strdup(psz_value) );
 }