From: Rémi Denis-Courmont <remi@remlab.net>
Date: Thu, 25 Feb 2010 21:56:45 +0000 (+0200)
Subject: Remove error/warnings from module_need()
X-Git-Tag: 1.1.0-pre1~671
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=ca6b633e9b398864ad0e4b6f125c7e30c3bf0221;p=vlc

Remove error/warnings from module_need()

They caused much confusion from bug reporters and support requestors.
Feel free to add more explicit and specific errors after module_need()
call sites in failure cases.
---

diff --git a/src/modules/modules.c b/src/modules/modules.c
index a1eba6ba3d..894168fa06 100644
--- a/src/modules/modules.c
+++ b/src/modules/modules.c
@@ -590,30 +590,11 @@ found_shortcut:
                                                : p_module->psz_object_name );
     }
     else if( count == 0 )
-    {
-        if( !strcmp( psz_capability, "access_demux" )
-         || !strcmp( psz_capability, "stream_filter" )
-         || !strcmp( psz_capability, "vout_window" ) )
-        {
-            msg_Dbg( p_this, "no %s module matched \"%s\"",
-                psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-        }
-        else
-        {
-            msg_Err( p_this, "no %s module matched \"%s\"",
-                 psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-
-            msg_StackSet( VLC_EGENERIC, "no %s module matched \"%s\"",
+        msg_Dbg( p_this, "no %s module matched \"%s\"",
                  psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-        }
-    }
-    else if( psz_name != NULL && *psz_name )
-    {
-        msg_Warn( p_this, "no %s module matching \"%s\" could be loaded",
-                  psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
-    }
     else
-        msg_StackSet( VLC_EGENERIC, "no suitable %s module", psz_capability );
+        msg_Dbg( p_this, "no %s module matching \"%s\" could be loaded",
+                  psz_capability, (psz_name && *psz_name) ? psz_name : "any" );
 
     free( psz_shortcuts );
     free( psz_var );