From: Götz Waschk Date: Thu, 15 Jul 2010 18:04:24 +0000 (+0200) Subject: Fix taglib compilation. X-Git-Tag: 1.2.0-pre1~5818 X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=d456bb4a261fbdc47989c25538f9f2072d7f9c76;p=vlc Fix taglib compilation. 1.6.0 does not support cover arts but the later version does support it. Signed-off-by: Rémi Duraffort --- diff --git a/configure.ac b/configure.ac index 0e7a5a2334..4ed7c065e0 100644 --- a/configure.ac +++ b/configure.ac @@ -1696,7 +1696,11 @@ AC_ARG_ENABLE(taglib, PKG_CHECK_MODULES(TAGLIB, taglib >= 1.5, [ VLC_ADD_PLUGIN([taglib]) VLC_ADD_LIBS([taglib],[$TAGLIB_LIBS -lz]) - VLC_ADD_CXXFLAGS([taglib],[$TAGLIB_CFLAGS]) ], + VLC_ADD_CXXFLAGS([taglib],[$TAGLIB_CFLAGS]) + AC_LANG_PUSH(C++) + AC_CHECK_HEADERS(taglib/mp4coverart.h) + AC_LANG_POP(C++) + ], [AC_MSG_WARN(TagLib library not found)]) ]) diff --git a/modules/meta_engine/taglib.cpp b/modules/meta_engine/taglib.cpp index 4e25b50de9..a75756823d 100644 --- a/modules/meta_engine/taglib.cpp +++ b/modules/meta_engine/taglib.cpp @@ -322,7 +322,7 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_t* p_demux, demux_met vlc_meta_SetArtURL( p_meta, "attachment://cover" ); } -#ifdef TAGLIB_WITH_MP4 +#if defined(TAGLIB_WITH_MP4) && defined(HAVE_TAGLIB_MP4COVERART_H) static void ReadMetaFromMP4( MP4::Tag* tag, demux_t *p_demux, demux_meta_t *p_demux_meta, vlc_meta_t* p_meta ) { if( tag->itemListMap().contains("covr") ) @@ -430,7 +430,7 @@ static int ReadMeta( vlc_object_t* p_this) else if( flac->xiphComment() ) ReadMetaFromXiph( flac->xiphComment(), p_demux, p_demux_meta, p_meta ); } -#ifdef TAGLIB_WITH_MP4 +#if defined(TAGLIB_WITH_MP4) && defined(HAVE_TAGLIB_MP4COVERART_H) else if( MP4::File *mp4 = dynamic_cast(f.file()) ) { if( mp4->tag() )