From: Zane van Iperen Date: Mon, 2 Nov 2020 05:47:21 +0000 (+1000) Subject: avcodec/adpcm_ima_amv: restrict to 1 channel X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=d6912294d39b5d15cba0236e06e5a3710e57a1a0;p=ffmpeg avcodec/adpcm_ima_amv: restrict to 1 channel The format doesn't allow for anything else. Signed-off-by: Zane van Iperen --- diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index d018c1f91bb..7b618dba17f 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -110,6 +110,7 @@ static av_cold int adpcm_decode_init(AVCodecContext * avctx) unsigned int max_channels = 2; switch(avctx->codec->id) { + case AV_CODEC_ID_ADPCM_IMA_AMV: case AV_CODEC_ID_ADPCM_IMA_CUNNING: max_channels = 1; break; @@ -1681,6 +1682,8 @@ static int adpcm_decode_frame(AVCodecContext *avctx, void *data, } break; case AV_CODEC_ID_ADPCM_IMA_AMV: + av_assert0(avctx->channels == 1); + c->status[0].predictor = sign_extend(bytestream2_get_le16u(&gb), 16); c->status[0].step_index = bytestream2_get_byteu(&gb); bytestream2_skipu(&gb, 5); @@ -1690,7 +1693,7 @@ static int adpcm_decode_frame(AVCodecContext *avctx, void *data, return AVERROR_INVALIDDATA; } - for (n = nb_samples >> (1 - st); n > 0; n--) { + for (n = nb_samples >> 1; n > 0; n--) { int v = bytestream2_get_byteu(&gb); *samples++ = adpcm_ima_expand_nibble(&c->status[0], v >> 4, 3); diff --git a/libavcodec/utils.c b/libavcodec/utils.c index db51512e153..008e95c2393 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -1696,7 +1696,7 @@ static int get_audio_frame_duration(enum AVCodecID id, int sr, int ch, int ba, case AV_CODEC_ID_ADPCM_IMA_SMJPEG: return (frame_bytes - 4) * 2 / ch; case AV_CODEC_ID_ADPCM_IMA_AMV: - return (frame_bytes - 8) * 2 / ch; + return (frame_bytes - 8) * 2; case AV_CODEC_ID_ADPCM_THP: case AV_CODEC_ID_ADPCM_THP_LE: if (extradata)