From: Rémi Denis-Courmont <remi@remlab.net>
Date: Sat, 28 Dec 2013 11:03:53 +0000 (+0200)
Subject: SOCKSv5: fix inverted logic (fixes #10247)
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=dcfe8660d41dbb2b519949ff767c7088a969525a;hp=644b1d06da5b0aee153b0438d9121be77d29bbaf;p=vlc

SOCKSv5: fix inverted logic (fixes #10247)
---

diff --git a/src/network/tcp.c b/src/network/tcp.c
index 78ab113260..9cf1c44e73 100644
--- a/src/network/tcp.c
+++ b/src/network/tcp.c
@@ -349,17 +349,14 @@ static int SocksNegotiate( vlc_object_t *p_obj,
         return VLC_SUCCESS;
 
     /* We negotiate authentication */
-
-    if( ( psz_socks_user == NULL ) && ( psz_socks_passwd == NULL ) )
-        b_auth = true;
-
     buffer[0] = i_socks_version;    /* SOCKS version */
-    if( b_auth )
+    if( psz_socks_user != NULL && psz_socks_passwd != NULL )
     {
         buffer[1] = 2;                  /* Number of methods */
         buffer[2] = 0x00;               /* - No auth required */
         buffer[3] = 0x02;               /* - USer/Password */
         i_len = 4;
+        b_auth = true;
     }
     else
     {