From: Rémi Duraffort <ivoire@videolan.org>
Date: Sun, 26 Oct 2008 21:41:49 +0000 (+0100)
Subject: Use asprintf and check it.
X-Git-Tag: 1.0.0-pre1~2306
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=de3f8c025b7bcee3d784a8b9c43d6f1fc1bbb62e;p=vlc

Use asprintf and check it.
---

diff --git a/src/interface/interface.c b/src/interface/interface.c
index b850eeb410..3e3cc36b07 100644
--- a/src/interface/interface.c
+++ b/src/interface/interface.c
@@ -271,13 +271,14 @@ static void * MonitorLibVLCDeath( vlc_object_t * p_this )
 static int AddIntfCallback( vlc_object_t *p_this, char const *psz_cmd,
                          vlc_value_t oldval, vlc_value_t newval, void *p_data )
 {
-    intf_thread_t *p_intf;
-    char *psz_intf = malloc( strlen(newval.psz_string) + sizeof(",none") );
-
     (void)psz_cmd; (void)oldval; (void)p_data;
+    intf_thread_t *p_intf;
+    char* psz_intf;
 
     /* Try to create the interface */
-    sprintf( psz_intf, "%s,none", newval.psz_string );
+    if( asprintf( &psz_intf, "%s,none", newval.psz_string ) == -1 )
+        return VLC_ENOMEM;
+
     p_intf = intf_Create( p_this->p_libvlc, psz_intf );
     free( psz_intf );
     if( p_intf == NULL )