From: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
Date: Sun, 14 Jun 2020 01:24:23 +0000 (+0200)
Subject: avformat/stldec: Fix memleak upon read header failure
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=e13874b9eae4e156ca1c478e6d59d3461bbdc09f;p=ffmpeg

avformat/stldec: Fix memleak upon read header failure

The already parsed subtitles (contained in an FFDemuxSubtitlesQueue)
would leak if an error happened upon reading a subsequent subtitle.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
---

diff --git a/libavformat/stldec.c b/libavformat/stldec.c
index d6e0713f8c1..fb67407ac56 100644
--- a/libavformat/stldec.c
+++ b/libavformat/stldec.c
@@ -97,8 +97,10 @@ static int stl_read_header(AVFormatContext *s)
         if (pts_start != AV_NOPTS_VALUE) {
             AVPacket *sub;
             sub = ff_subtitles_queue_insert(&stl->q, p, strlen(p), 0);
-            if (!sub)
+            if (!sub) {
+                ff_subtitles_queue_clean(&stl->q);
                 return AVERROR(ENOMEM);
+            }
             sub->pos = pos;
             sub->pts = pts_start;
             sub->duration = duration;