From: Till Theato <root@ttill.de>
Date: Sun, 20 Jun 2010 21:41:44 +0000 (+0000)
Subject: Fix possible clip corruption due to insufficient checking in duration dialog
X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=eccb12f89d018f2d0524c869f91d854f85960635;p=kdenlive

Fix possible clip corruption due to insufficient checking in duration dialog

svn path=/trunk/kdenlive/; revision=4536
---

diff --git a/src/clipdurationdialog.cpp b/src/clipdurationdialog.cpp
index 18838af4..920ca288 100644
--- a/src/clipdurationdialog.cpp
+++ b/src/clipdurationdialog.cpp
@@ -144,13 +144,14 @@ void ClipDurationDialog::slotCheckEnd()
 {
     GenTime cropStart = m_cropStart->gentime();
     GenTime cropEnd = m_cropEnd->gentime();
-    GenTime duration = m_clip->maxDuration() - cropStart - cropEnd;
+    GenTime duration = m_clip->maxDuration() - cropEnd - cropStart;
 
     if (duration >= GenTime()) {
         m_dur->setValue(duration);
+        slotCheckDuration();
     } else {
         m_cropEnd->blockSignals(true);
-        m_cropEnd->setValue(m_clip->maxDuration() - cropStart - m_dur->gentime());
+        m_cropEnd->setValue(m_clip->maxDuration() - m_dur->gentime() - cropStart);
         m_cropEnd->blockSignals(false);
     }
 }
diff --git a/src/clipdurationdialog.h b/src/clipdurationdialog.h
index 7033c8f4..27a8ee18 100644
--- a/src/clipdurationdialog.h
+++ b/src/clipdurationdialog.h
@@ -26,6 +26,11 @@
 #include "timecodedisplay.h"
 #include "ui_clipdurationdialog_ui.h"
 
+/**
+ * @class ClipDurationDialog
+ * @brief A dialog for modifying an item's (clip or transition) duration. 
+ * @author Jean-Baptiste Mardelle
+ */
 
 class ClipDurationDialog : public QDialog, public Ui::ClipDurationDialog_UI
 {