From: RĂ©mi Duraffort Date: Fri, 28 Aug 2009 17:15:25 +0000 (+0200) Subject: libvlc: fix logic '||' and not '&&'. X-Git-Tag: 1.1.0-ff~3793 X-Git-Url: https://git.sesse.net/?a=commitdiff_plain;h=f2287d1016b46b3bd582ff31c1b5e6ca3bd97977;p=vlc libvlc: fix logic '||' and not '&&'. --- diff --git a/src/control/audio.c b/src/control/audio.c index 0146bbe901..a6298af417 100644 --- a/src/control/audio.c +++ b/src/control/audio.c @@ -454,7 +454,7 @@ void libvlc_audio_set_track( libvlc_media_player_t *p_mi, int i_track, return; var_Change( p_input_thread, "audio-es", VLC_VAR_GETCHOICES, &val_list, NULL ); - if( (i_track < 0) && (i_track > val_list.p_list->i_count) ) + if( (i_track < 0) || (i_track > val_list.p_list->i_count) ) { libvlc_exception_raise( p_e, "Audio track out of range" ); goto end; @@ -509,5 +509,4 @@ void libvlc_audio_set_channel( libvlc_instance_t *p_instance, vlc_object_release( p_aout ); } - } diff --git a/src/control/video.c b/src/control/video.c index 7878698844..ffe7e56b8d 100644 --- a/src/control/video.c +++ b/src/control/video.c @@ -320,7 +320,7 @@ void libvlc_video_set_spu( libvlc_media_player_t *p_mi, int i_spu, goto end; } - if( (i_spu < 0) && (i_spu > val_list.p_list->i_count) ) + if( (i_spu < 0) || (i_spu > val_list.p_list->i_count) ) { libvlc_exception_raise( p_e, "Subtitle value out of range" ); goto end; @@ -699,7 +699,7 @@ int libvlc_video_get_marquee_option_as_int( libvlc_media_player_t *p_mi, vlc_object_release(marquee); return isEnabled; } - + /* Generic case */ if(!identifier) { @@ -724,7 +724,7 @@ char * libvlc_video_get_marquee_option_as_string( libvlc_media_player_t *p_mi, libvlc_exception_raise( p_e, "This option is not available" ); return 0; } - + vlc_object_t * marquee = get_marquee_object(p_mi); if(!marquee) {