From 342fd6385bbe004b6152023eeba6362104664e23 Mon Sep 17 00:00:00 2001 From: Marco Costalba Date: Tue, 3 Dec 2013 11:06:59 +0100 Subject: [PATCH] Remove redundant argument from hidden_checkers() No functional change. --- src/position.cpp | 7 ++++--- src/position.h | 10 +++++----- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/position.cpp b/src/position.cpp index d2aeb822..6088477d 100644 --- a/src/position.cpp +++ b/src/position.cpp @@ -415,20 +415,21 @@ const string Position::pretty(Move move) const { /// pieces, according to the call parameters. Pinned pieces protect our king and /// discovered check pieces attack the enemy king. -Bitboard Position::hidden_checkers(Square ksq, Color c, Color toMove) const { +Bitboard Position::hidden_checkers(Color c, Color kingColor) const { Bitboard b, pinners, result = 0; + Square ksq = king_square(kingColor); // Pinners are sliders that give check when a pinned piece is removed pinners = ( (pieces( ROOK, QUEEN) & PseudoAttacks[ROOK ][ksq]) - | (pieces(BISHOP, QUEEN) & PseudoAttacks[BISHOP][ksq])) & pieces(c); + | (pieces(BISHOP, QUEEN) & PseudoAttacks[BISHOP][ksq])) & pieces(~kingColor); while (pinners) { b = between_bb(ksq, pop_lsb(&pinners)) & pieces(); if (!more_than_one(b)) - result |= b & pieces(toMove); + result |= b & pieces(c); } return result; } diff --git a/src/position.h b/src/position.h index 64cb349a..907463d4 100644 --- a/src/position.h +++ b/src/position.h @@ -108,7 +108,7 @@ public: // Checking Bitboard checkers() const; Bitboard discovered_check_candidates() const; - Bitboard pinned_pieces(Color toMove) const; + Bitboard pinned_pieces(Color c) const; // Attacks to/from a given square Bitboard attackers_to(Square s) const; @@ -174,7 +174,7 @@ private: // Helper functions void do_castling(Square kfrom, Square kto, Square rfrom, Square rto); - Bitboard hidden_checkers(Square ksq, Color c, Color toMove) const; + Bitboard hidden_checkers(Color c, Color kingColor) const; void put_piece(Square s, Color c, PieceType pt); void remove_piece(Square s, Color c, PieceType pt); void move_piece(Square from, Square to, Color c, PieceType pt); @@ -315,11 +315,11 @@ inline Bitboard Position::checkers() const { } inline Bitboard Position::discovered_check_candidates() const { - return hidden_checkers(king_square(~sideToMove), sideToMove, sideToMove); + return hidden_checkers(sideToMove, ~sideToMove); } -inline Bitboard Position::pinned_pieces(Color toMove) const { - return hidden_checkers(king_square(toMove), ~toMove, toMove); +inline Bitboard Position::pinned_pieces(Color c) const { + return hidden_checkers(c, c); } inline bool Position::pawn_passed(Color c, Square s) const { -- 2.39.5