From 063bfc5c7ebca857aeeb1c7f4bed1c9c66ce9edb Mon Sep 17 00:00:00 2001 From: =?utf8?q?R=C3=A9mi=20Denis-Courmont?= Date: Sun, 18 Jul 2010 18:46:07 +0300 Subject: [PATCH] ALSA: use plughw rather than hw for manually selected output plughw provides transparent userspace format conversion if needed. That is much safer. In fact, I doubt VLC would support all raw hardware drivers - some have rather weird format requirements. --- modules/audio_output/alsa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/audio_output/alsa.c b/modules/audio_output/alsa.c index 62693b3f41..146e11d802 100644 --- a/modules/audio_output/alsa.c +++ b/modules/audio_output/alsa.c @@ -1005,13 +1005,13 @@ static void GetDevicesForCard( vlc_object_t *obj, module_config_t *p_item, continue; } - if( asprintf( &psz_device, "hw:%d,%d", i_card, i_pcm_device ) == -1 ) - break; + if( asprintf( &psz_device, "plughw:%u,%u", i_card, i_pcm_device ) == -1 ) + continue; if( asprintf( &psz_descr, "%s: %s (%s)", psz_card_name, snd_pcm_info_get_name(p_pcm_info), psz_device ) == -1 ) { free( psz_device ); - break; + continue; } msg_Dbg( obj, " %s", psz_descr ); -- 2.39.2