From 1144af45baae4cbc6609c46d771f314ce84ddcef Mon Sep 17 00:00:00 2001 From: Antoine Cellerier Date: Sat, 18 Aug 2007 10:44:20 +0000 Subject: [PATCH] Freeing stuff before using it is *stupid*. (<-- funman) --- modules/meta_engine/musicbrainz.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/modules/meta_engine/musicbrainz.c b/modules/meta_engine/musicbrainz.c index 3365d7dd6a..ed6ce43af7 100644 --- a/modules/meta_engine/musicbrainz.c +++ b/modules/meta_engine/musicbrainz.c @@ -89,8 +89,6 @@ static int GetData( vlc_object_t *p_obj, input_item_t *p_item, free( psz_album ); return VLC_EGENERIC; } - free( psz_artist ); - free( psz_album ); musicbrainz_t p_mb; @@ -112,10 +110,14 @@ static int GetData( vlc_object_t *p_obj, input_item_t *p_item, "\n", ppsz_args ) ) { mb_GetQueryError( p_mb, psz_buf, 256 ); - msg_Err( p_obj, "Query failed: %s\n", psz_buf ); + msg_Err( p_obj, "Query failed: %s", psz_buf ); mb_Delete( p_mb ); + free( psz_artist ); + free( psz_album ); return VLC_EGENERIC; } + free( psz_artist ); + free( psz_album ); i_album_count = mb_GetResultInt( p_mb, MBE_GetNumAlbums ); if( i_album_count < 1 ) -- 2.39.2