From 1e48aaaa8518860bc63d02feca5d556b49c919ed Mon Sep 17 00:00:00 2001 From: "Steinar H. Gunderson" Date: Sun, 15 Nov 2015 18:01:48 +0100 Subject: [PATCH] Reduce the default cutoff a bit; we have no instruments below, so better to give the voice a bit extra depth down there. Also fix so that the default is set only one place. --- mainwindow.cpp | 2 ++ mixer.cpp | 7 ++++--- ui_mainwindow.ui | 4 ++-- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/mainwindow.cpp b/mainwindow.cpp index 34db733..8a91a3f 100644 --- a/mainwindow.cpp +++ b/mainwindow.cpp @@ -99,6 +99,8 @@ void MainWindow::mixer_created(Mixer *mixer) ui->compressor_threshold_db_display->setText(buf); connect(ui->locut_cutoff_knob, &QDial::valueChanged, this, &MainWindow::cutoff_knob_changed); + cutoff_knob_changed(ui->locut_cutoff_knob->value()); + connect(ui->limiter_threshold_knob, &QDial::valueChanged, this, &MainWindow::limiter_threshold_knob_changed); connect(ui->compressor_threshold_knob, &QDial::valueChanged, this, &MainWindow::compressor_threshold_knob_changed); connect(ui->limiter_enabled, &QCheckBox::stateChanged, [this](int state){ diff --git a/mixer.cpp b/mixer.cpp index 239575f..72ae215 100644 --- a/mixer.cpp +++ b/mixer.cpp @@ -572,9 +572,10 @@ void Mixer::process_audio_one_frame(int64_t frame_pts_int) } } - // Cut away everything under 150 Hz; we don't need it for voice, - // and it will reduce headroom and confuse the compressor. - // (In particular, any hums at 50 or 60 Hz should be dampened.) + // Cut away everything under 120 Hz (or whatever the cutoff is); + // we don't need it for voice, and it will reduce headroom + // and confuse the compressor. (In particular, any hums at 50 or 60 Hz + // should be dampened.) locut.render(samples_out.data(), samples_out.size() / 2, locut_cutoff_hz * 2.0 * M_PI / OUTPUT_FREQUENCY, 0.5f); // Apply a level compressor to get the general level right. diff --git a/ui_mainwindow.ui b/ui_mainwindow.ui index 858771e..db3a368 100644 --- a/ui_mainwindow.ui +++ b/ui_mainwindow.ui @@ -480,7 +480,7 @@ 60 - 29 + 26 @@ -501,7 +501,7 @@ - 150 Hz + 120 Hz Qt::AlignCenter -- 2.39.2