From 379e5603f4131e677ecf5ba79973dcd5603f28ea Mon Sep 17 00:00:00 2001 From: wm4 Date: Fri, 8 May 2015 18:19:12 +0200 Subject: [PATCH] id3v2: Do not export empty APIC description APIC tags always have a description. Tag writers obviously leave it empty if there is no description. In this case, libavformat would export "" as title. Do not set the title instead. --- libavformat/id3v2.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/id3v2.c b/libavformat/id3v2.c index b8994b22263..799eafee7cc 100644 --- a/libavformat/id3v2.c +++ b/libavformat/id3v2.c @@ -763,7 +763,10 @@ int ff_id3v2_parse_apic(AVFormatContext *s, ID3v2ExtraMeta **extra_meta) st->disposition |= AV_DISPOSITION_ATTACHED_PIC; st->codec->codec_type = AVMEDIA_TYPE_VIDEO; st->codec->codec_id = apic->id; - av_dict_set(&st->metadata, "title", apic->description, 0); + + if (apic->description[0]) + av_dict_set(&st->metadata, "title", apic->description, 0); + av_dict_set(&st->metadata, "comment", apic->type, 0); av_init_packet(&st->attached_pic); -- 2.39.2