From 46b03bc5e15ae8c6cece41ef3850cdb91afbba25 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Mardelle <jb@kdenlive.org>
Date: Fri, 7 Mar 2008 14:08:06 +0000
Subject: [PATCH] =?utf8?q?Cleanup=20+=C2=A0fix=20i18n=20with=20args?=
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

svn path=/branches/KDE4/; revision=2005
---
 src/addeffectcommand.cpp  |  8 ++++++--
 src/editeffectcommand.cpp |  6 +++++-
 src/effectslist.cpp       | 10 +++++-----
 src/projectlist.cpp       |  2 +-
 4 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/src/addeffectcommand.cpp b/src/addeffectcommand.cpp
index 48a234dc..1f8fac4e 100644
--- a/src/addeffectcommand.cpp
+++ b/src/addeffectcommand.cpp
@@ -23,8 +23,12 @@
 
 AddEffectCommand::AddEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement effect, bool doIt)
         : m_view(view), m_track(track), m_pos(pos), m_effect(effect), m_doIt(doIt) {
-    if (doIt) setText(i18n("Add effect"));
-    else setText(i18n("Delete effect"));
+    QString effectName;
+    QDomNode namenode = effect.elementsByTagName("name").item(0);
+    if (!namenode.isNull()) effectName = i18n(namenode.toElement().text().toUtf8().data());
+    else effectName = i18n("effect");
+    if (doIt) setText(i18n("Add %1", effectName));
+    else setText(i18n("Delete %1", effectName));
 }
 
 
diff --git a/src/editeffectcommand.cpp b/src/editeffectcommand.cpp
index 7359614b..679cf75b 100644
--- a/src/editeffectcommand.cpp
+++ b/src/editeffectcommand.cpp
@@ -24,7 +24,11 @@
 EditEffectCommand::EditEffectCommand(CustomTrackView *view, const int track, GenTime pos, QDomElement oldeffect, QDomElement effect, bool doIt)
         : m_view(view), m_track(track), m_pos(pos), m_oldeffect(oldeffect), m_doIt(doIt) {
     m_effect = effect.cloneNode().toElement();
-    setText(i18n("Edit effect"));
+    QString effectName;
+    QDomNode namenode = effect.elementsByTagName("name").item(0);
+    if (!namenode.isNull()) effectName = i18n(namenode.toElement().text().toUtf8().data());
+    else effectName = i18n("effect");
+    setText(i18n("Edit effect %1", effectName));
 }
 
 // virtual
diff --git a/src/effectslist.cpp b/src/effectslist.cpp
index 9d309955..f17de756 100644
--- a/src/effectslist.cpp
+++ b/src/effectslist.cpp
@@ -36,7 +36,7 @@ QMap <QString, QString> EffectsList::effect(const QString & name) {
         effect =  this->at(i);
         QDomNode namenode = effect.elementsByTagName("name").item(0);
         if (!namenode.isNull()) {
-            effectName = i18n(qstrdup(namenode.toElement().text().toUtf8()));
+            effectName = i18n(namenode.toElement().text().toUtf8().data());
             if (name == effectName) break;
         }
     }
@@ -50,7 +50,7 @@ QDomElement EffectsList::getEffectByName(const QString & name) {
     for (int i = 0; i < this->size(); ++i) {
         QDomElement effect =  this->at(i);
         QDomNode namenode = effect.elementsByTagName("name").item(0);
-        if (!namenode.isNull()) effectName = i18n(qstrdup(namenode.toElement().text().toUtf8()));
+        if (!namenode.isNull()) effectName = i18n(namenode.toElement().text().toUtf8().data());
         if (name == effectName) {
             QDomNodeList params = effect.elementsByTagName("parameter");
             for (int i = 0; i < params.count(); i++) {
@@ -69,7 +69,7 @@ QStringList EffectsList::effectNames() {
     for (int i = 0; i < this->size(); ++i) {
         QDomElement effect =  this->at(i);
         QDomNode namenode = effect.elementsByTagName("name").item(0);
-        if (!namenode.isNull()) list.append(i18n(qstrdup(namenode.toElement().text().toUtf8())));
+        if (!namenode.isNull()) list.append(i18n(namenode.toElement().text().toUtf8().data()));
     }
     return list;
 }
@@ -78,9 +78,9 @@ QString EffectsList::getInfo(QString effectName) {
     QString info;
     QDomElement effect = getEffectByName(effectName);
     QDomNode namenode = effect.elementsByTagName("description").item(0);
-    if (!namenode.isNull()) info = i18n(qstrdup(namenode.toElement().text().toUtf8()));
+    if (!namenode.isNull()) info = i18n(namenode.toElement().text().toUtf8().data());
     namenode = effect.elementsByTagName("author").item(0);
-    if (!namenode.isNull()) info.append(i18n("<br><b>Author:</b> ") + i18n(qstrdup(namenode.toElement().text().toUtf8())));
+    if (!namenode.isNull()) info.append(i18n("<br><b>Author:</b> ") + i18n(namenode.toElement().text().toUtf8().data()));
     return info;
 }
 
diff --git a/src/projectlist.cpp b/src/projectlist.cpp
index 0e6a04af..d5e8c894 100644
--- a/src/projectlist.cpp
+++ b/src/projectlist.cpp
@@ -181,7 +181,7 @@ void ProjectList::slotRemoveClip() {
     if (!listView->currentItem()) return;
     ProjectItem *item = ((ProjectItem *)listView->currentItem());
     if (item->numReferences() > 0) {
-        if (KMessageBox::questionYesNo(this, i18n("Delete clip <b>%1</b> ?<br>This will also remove its %2 clips in timeline").arg(item->names().at(1)).arg(item->numReferences()), i18n("Delete Clip")) != KMessageBox::Yes) return;
+        if (KMessageBox::questionYesNo(this, i18n("Delete clip <b>%1</b> ?<br>This will also remove its %2 clips in timeline", item->names().at(1), item->numReferences()), i18n("Delete Clip")) != KMessageBox::Yes) return;
     }
     m_doc->deleteProjectClip(item->clipId());
 }
-- 
2.39.5