From 4c07340284eed65a8eac6053c84f0aac520c5b33 Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Mardelle Date: Fri, 9 Sep 2011 23:55:47 +0000 Subject: [PATCH] cppcheck fixes, patch by Mikko Rapeli [18/27] svn path=/trunk/kdenlive/; revision=5892 --- src/mltdevicecapture.h | 2 +- src/stopmotion/capturehandler.h | 2 +- src/stopmotion/stopmotion.cpp | 10 +++++----- src/stopmotion/stopmotion.h | 6 +++--- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mltdevicecapture.h b/src/mltdevicecapture.h index 9603326e..30d695c3 100644 --- a/src/mltdevicecapture.h +++ b/src/mltdevicecapture.h @@ -139,7 +139,7 @@ signals: /** @brief This signal contains the audio of the current frame. */ void audioSamplesSignal(const QVector&, int freq, int num_channels, int num_samples); - void frameSaved(const QString); + void frameSaved(const QString &); void droppedFrames(int); diff --git a/src/stopmotion/capturehandler.h b/src/stopmotion/capturehandler.h index 9e1e3502..b2ea249d 100644 --- a/src/stopmotion/capturehandler.h +++ b/src/stopmotion/capturehandler.h @@ -52,7 +52,7 @@ protected: signals: void gotTimeCode(ulong); void gotMessage(const QString &); - void frameSaved(const QString); + void frameSaved(const QString &); void gotFrame(QImage); }; diff --git a/src/stopmotion/stopmotion.cpp b/src/stopmotion/stopmotion.cpp index a018fe76..f76f9c29 100644 --- a/src/stopmotion/stopmotion.cpp +++ b/src/stopmotion/stopmotion.cpp @@ -276,7 +276,7 @@ StopmotionWidget::StopmotionWidget(MonitorManager *manager, KUrl projectFolder, connect(capture_device, SIGNAL(currentIndexChanged(int)), this, SLOT(slotUpdateDeviceHandler())); /*if (m_bmCapture) { - connect(m_bmCapture, SIGNAL(frameSaved(const QString)), this, SLOT(slotNewThumb(const QString))); + connect(m_bmCapture, SIGNAL(frameSaved(const QString &)), this, SLOT(slotNewThumb(const QString &))); connect(m_bmCapture, SIGNAL(gotFrame(QImage)), this, SIGNAL(gotFrame(QImage))); } else live_button->setEnabled(false);*/ @@ -303,7 +303,7 @@ StopmotionWidget::StopmotionWidget(MonitorManager *manager, KUrl projectFolder, m_captureDevice = new MltDeviceCapture(profilePath, m_videoBox, this); m_captureDevice->sendFrameForAnalysis = KdenliveSettings::analyse_stopmotion(); m_monitor->setRender(m_captureDevice); - connect(m_captureDevice, SIGNAL(frameSaved(const QString)), this, SLOT(slotNewThumb(const QString))); + connect(m_captureDevice, SIGNAL(frameSaved(const QString &)), this, SLOT(slotNewThumb(const QString &))); live_button->setChecked(false); button_addsequence->setEnabled(false); @@ -488,7 +488,7 @@ void StopmotionWidget::slotLive(bool isOn) m_captureDevice = new MltDeviceCapture(profilePath, m_videoBox, this); m_captureDevice->sendFrameForAnalysis = KdenliveSettings::analyse_stopmotion(); m_monitor->setRender(m_captureDevice); - connect(m_captureDevice, SIGNAL(frameSaved(const QString)), this, SLOT(slotNewThumb(const QString))); + connect(m_captureDevice, SIGNAL(frameSaved(const QString &)), this, SLOT(slotNewThumb(const QString &))); } m_manager->activateMonitor("stopmotion"); @@ -664,7 +664,7 @@ void StopmotionWidget::slotPreNotify() } -void StopmotionWidget::slotNewThumb(const QString path) +void StopmotionWidget::slotNewThumb(const QString &path) { if (!KdenliveSettings::showstopmotionthumbs()) return; m_filesList.append(path); @@ -883,7 +883,7 @@ void StopmotionWidget::slotSwitchMirror(bool isOn) if (m_captureDevice) m_captureDevice->mirror(isOn); } -const QString StopmotionWidget::createProducer(MltVideoProfile profile, const QString service, const QString resource) +const QString StopmotionWidget::createProducer(MltVideoProfile profile, const QString &service, const QString &resource) { Q_UNUSED(profile) diff --git a/src/stopmotion/stopmotion.h b/src/stopmotion/stopmotion.h index 1ddb4c5a..3e115276 100644 --- a/src/stopmotion/stopmotion.h +++ b/src/stopmotion/stopmotion.h @@ -152,7 +152,7 @@ private: StopmotionMonitor *m_monitor; /** @brief Create the XML playlist. */ - const QString createProducer(MltVideoProfile profile, const QString service, const QString resource); + const QString createProducer(MltVideoProfile profile, const QString &service, const QString &resource); /** @brief A new frame arrived, reload overlay. */ void reloadOverlay(); @@ -225,7 +225,7 @@ private slots: void slotConfigure(); /** @brief Prepare to crete thumb for newly captured frame. */ - void slotNewThumb(const QString path); + void slotNewThumb(const QString &path); /** @brief Set the effect to be applied to overlay frame. */ void slotUpdateOverlayEffect(QAction* act); @@ -247,7 +247,7 @@ private slots: signals: /** @brief Ask to add sequence to current project. */ - void addOrUpdateSequence(const QString); + void addOrUpdateSequence(const QString &); void doCreateThumbs(QImage, int); void gotFrame(QImage); -- 2.39.2