From 50dcbaa6453e2a902003829c5f67577355daa4fe Mon Sep 17 00:00:00 2001 From: Marco Gittler Date: Tue, 31 Mar 2009 21:30:24 +0000 Subject: [PATCH] Patches from Ray Lehtiniemi - Missing include guards in a header file - Add braces and update indentation to clarify ambiguous if/else svn path=/trunk/kdenlive/; revision=3200 --- src/parameterplotter.h | 5 +++++ src/titledocument.cpp | 46 ++++++++++++++++++++---------------------- 2 files changed, 27 insertions(+), 24 deletions(-) diff --git a/src/parameterplotter.h b/src/parameterplotter.h index 8f1a070b..a5c8816e 100644 --- a/src/parameterplotter.h +++ b/src/parameterplotter.h @@ -15,6 +15,9 @@ * * ***************************************************************************/ +#ifndef _PARAMETERPLOTTER_H_ +#define _PARAMETERPLOTTER_H_ + #include #include #include @@ -58,3 +61,5 @@ signals: void parameterList(QStringList); }; + +#endif diff --git a/src/titledocument.cpp b/src/titledocument.cpp index 3a841510..0a90afbc 100644 --- a/src/titledocument.cpp +++ b/src/titledocument.cpp @@ -194,7 +194,7 @@ int TitleDocument::loadFromXml(QDomDocument doc, QGraphicsPolygonItem* /*startv* QGraphicsItem *gitem = NULL; kDebug() << items.item(i).attributes().namedItem("type").nodeValue(); int zValue = items.item(i).attributes().namedItem("z-index").nodeValue().toInt(); - if (zValue > -1000) + if (zValue > -1000) { if (items.item(i).attributes().namedItem("type").nodeValue() == "QGraphicsTextItem") { QDomNamedNodeMap txtProperties = items.item(i).namedItem("content").attributes(); QFont font(txtProperties.namedItem("font").nodeValue()); @@ -212,29 +212,27 @@ int TitleDocument::loadFromXml(QDomDocument doc, QGraphicsPolygonItem* /*startv* txt->setDefaultTextColor(col); txt->setTextInteractionFlags(Qt::NoTextInteraction); gitem = txt; - } else - if (items.item(i).attributes().namedItem("type").nodeValue() == "QGraphicsRectItem") { - QString rect = items.item(i).namedItem("content").attributes().namedItem("rect").nodeValue(); - QString br_str = items.item(i).namedItem("content").attributes().namedItem("brushcolor").nodeValue(); - QString pen_str = items.item(i).namedItem("content").attributes().namedItem("pencolor").nodeValue(); - double penwidth = items.item(i).namedItem("content").attributes().namedItem("penwidth").nodeValue().toDouble(); - QGraphicsRectItem *rec = scene->addRect(stringToRect(rect), QPen(QBrush(stringToColor(pen_str)), penwidth), QBrush(stringToColor(br_str))); - gitem = rec; - } else - if (items.item(i).attributes().namedItem("type").nodeValue() == "QGraphicsPixmapItem") { - QString url = items.item(i).namedItem("content").attributes().namedItem("url").nodeValue(); - QPixmap pix(url); - QGraphicsPixmapItem *rec = scene->addPixmap(pix); - rec->setData(Qt::UserRole, url); - gitem = rec; - } else - if (items.item(i).attributes().namedItem("type").nodeValue() == "QGraphicsSvgItem") { - QString url = items.item(i).namedItem("content").attributes().namedItem("url").nodeValue(); - QGraphicsSvgItem *rec = new QGraphicsSvgItem(url); - scene->addItem(rec); - rec->setData(Qt::UserRole, url); - gitem = rec; - } + } else if (items.item(i).attributes().namedItem("type").nodeValue() == "QGraphicsRectItem") { + QString rect = items.item(i).namedItem("content").attributes().namedItem("rect").nodeValue(); + QString br_str = items.item(i).namedItem("content").attributes().namedItem("brushcolor").nodeValue(); + QString pen_str = items.item(i).namedItem("content").attributes().namedItem("pencolor").nodeValue(); + double penwidth = items.item(i).namedItem("content").attributes().namedItem("penwidth").nodeValue().toDouble(); + QGraphicsRectItem *rec = scene->addRect(stringToRect(rect), QPen(QBrush(stringToColor(pen_str)), penwidth), QBrush(stringToColor(br_str))); + gitem = rec; + } else if (items.item(i).attributes().namedItem("type").nodeValue() == "QGraphicsPixmapItem") { + QString url = items.item(i).namedItem("content").attributes().namedItem("url").nodeValue(); + QPixmap pix(url); + QGraphicsPixmapItem *rec = scene->addPixmap(pix); + rec->setData(Qt::UserRole, url); + gitem = rec; + } else if (items.item(i).attributes().namedItem("type").nodeValue() == "QGraphicsSvgItem") { + QString url = items.item(i).namedItem("content").attributes().namedItem("url").nodeValue(); + QGraphicsSvgItem *rec = new QGraphicsSvgItem(url); + scene->addItem(rec); + rec->setData(Qt::UserRole, url); + gitem = rec; + } + } //pos and transform if (gitem) { QPointF p(items.item(i).namedItem("position").attributes().namedItem("x").nodeValue().toDouble(), -- 2.39.5