From 5d854b3643a0673aaaf44fb73c880d537b2edbde Mon Sep 17 00:00:00 2001 From: Jean-Baptiste Kempf Date: Tue, 19 May 2009 18:54:07 +0200 Subject: [PATCH] x11: Show popup menu on click, not on release, as KDE and GNOME seem to do it. Close #2573 --- modules/video_output/x11/xcommon.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/video_output/x11/xcommon.c b/modules/video_output/x11/xcommon.c index ea973d8663..9cd132c91c 100644 --- a/modules/video_output/x11/xcommon.c +++ b/modules/video_output/x11/xcommon.c @@ -1232,6 +1232,8 @@ static int ManageVideo( vout_thread_t *p_vout ) val.i_int |= 1; var_Set( p_vout, "mouse-button-down", val ); + var_SetBool( p_vout->p_libvlc, "intf-popupmenu", false ); + /* detect double-clicks */ if( ( ((XButtonEvent *)&xevent)->time - p_vout->p_sys->i_time_button_last_pressed ) < 300 ) @@ -1252,6 +1254,7 @@ static int ManageVideo( vout_thread_t *p_vout ) var_Get( p_vout, "mouse-button-down", &val ); val.i_int |= 4; var_Set( p_vout, "mouse-button-down", val ); + var_SetBool( p_vout->p_libvlc, "intf-popupmenu", true ); break; case Button4: @@ -1279,7 +1282,6 @@ static int ManageVideo( vout_thread_t *p_vout ) var_Set( p_vout, "mouse-button-down", val ); var_SetBool( p_vout, "mouse-clicked", true ); - var_SetBool( p_vout->p_libvlc, "intf-popupmenu", false ); } break; @@ -1301,7 +1303,6 @@ static int ManageVideo( vout_thread_t *p_vout ) val.i_int &= ~4; var_Set( p_vout, "mouse-button-down", val ); - var_SetBool( p_vout->p_libvlc, "intf-popupmenu", true ); } break; -- 2.39.2